Re: James spool and threads

2005-04-29 Thread Gabor Kincses
--- [EMAIL PROTECTED] wrote: > > > the only notify is at the end of store() but > there is no > > notify at the > > > unlock() > > > > store() would be called elsewhere in the code to > put it into > > the next processor, and processor.service() > doesn't return > > until the processor has fi

Re: James spool and threads

2005-04-29 Thread apache
> > the only notify is at the end of store() but there is no > notify at the > > unlock() > > store() would be called elsewhere in the code to put it into > the next processor, and processor.service() doesn't return > until the processor has finished with the message. Ok, I found the call to

RE: James spool and threads

2005-04-29 Thread Noel J. Bergman
> > > JDBCSpoolRepository has a 60 seconds wait > > Which should get terminated when notify is called(). > I know how notify() works but james does not call it. Then we should fix that part. > the only notify is at the end of store() but there is no notify at > the unlock() store() would be cal

Re: James spool and threads

2005-04-29 Thread apache
> it would be easier to review if you send a diff -u there is a > reason why we like diffs compared to random blocks of code. You can find the diff at the end of this email. > > JDBCSpoolRepository has a 60 seconds wait > Which should get terminated when notify is called(). I know how notify(

Re: James spool and threads

2005-04-29 Thread Danny Angus
> One possible change, hinted at in comments I left in the code, would be for > the spool manager to become single threaded, dishing off messages to worker > threads. This would be quite similar to a common usage pattern with NIO, > should eliminate contention and synchronization issues, and impro

RE: James spool and threads

2005-04-29 Thread Noel J. Bergman
> JDBCSpoolRepository has a 60 seconds wait Which should get terminated when notify is called(). ref: http://java.sun.com/j2se/1.4.2/docs/api/java/lang/Object.html#wait(long) http://java.sun.com/j2se/1.4.2/docs/api/java/lang/Object.html#notify( ) > the spool threads only complete 1 proc

Re: James spool and threads

2005-04-29 Thread Danny Angus
it would be easier to review if you send a diff -u there is a reason why we like diffs compared to random blocks of code. On 29/04/05, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > When james is configured with many processors then the spooling processing > is really slow. > > It takes a minimum

James spool and threads

2005-04-29 Thread apache
When james is configured with many processors then the spooling processing is really slow. It takes a minimum of 1 minute per processor to fully spool a single email. JDBCSpoolRepository has a 60 seconds wait, and the spool threads only complete 1 processor and return the mail to the spool. Look