RE: building from james head

2003-08-24 Thread Noel J. Bergman
> If I do a cvs diff I don't see anything different (diff invoked at 20:49 > Paris time). Look again. My changes were all complete by 14:09 EDT. > I replaced the cornerstone-xxx-1.0.jar with corenerstone-xxx-api-1.0.jar > and corenerstone-xxx-impl-1.0.jar. I agree with your premise, but if you

RE: building from james head

2003-08-24 Thread Noel J. Bergman
Richard O. Hammer wrote: > This is valid source as far as the Java language is concerned. > InetNetwork is not an inner class, but rather is another class > in the same package. Correct. > While it is customary to put each class in its own file > this is not required by Java standards. Unnecessa

RE: building from james head

2003-08-24 Thread Noel J. Bergman
> The class org.apache.james.util.NetMatcher includes references to the > inner class InetNetwork. It isn't an inner class. Nor is it a public class. The language and usage are perfectly legal. See section 6.6.4 of the Java Language Specification. ref: http://java.sun.com/docs/books/jls/firs

Re: building from james head

2003-08-24 Thread Stephen McConnell
Noel J. Bergman wrote: Stephen, In the meantime I'm be committing updates to the build.xml so we are all in sync. I hadn't committed my changes because I couldn't get things to work here, but I believe that I had everything you do. I'll commit now so that we're not stepping on each oth

Re: building from james head

2003-08-24 Thread Richard O. Hammer
This is valid source as far as the Java language is concerned. InetNetwork is not an inner class, but rather is another class in the same package. While it is customary to put each class in its own file this is not required by Java standards. But, from scanning the Exception message which you

RE: building from james head

2003-08-24 Thread Noel J. Bergman
Stephen, > In the meantime I'm be committing updates to the build.xml so we are all > in sync. I hadn't committed my changes because I couldn't get things to work here, but I believe that I had everything you do. I'll commit now so that we're not stepping on each other. Please review, and let m

Re: building from james head

2003-08-24 Thread Stephen McConnell
Hi: Have just committed a change to NetMatcher. I moved the InetNetwork class to be a proper inner class of NetMatcher and changed it to a static class. I have not idea if this is what was intended - but now it compiles *and* James runtime works. Stephen. Stephen McConnell wrote: This one is

Re: building from james head

2003-08-24 Thread Stephen McConnell
This one is interesting: The class org.apache.james.util.NetMatcher includes references to the inner class InetNetwork. However, if we look at the source we see that InetNetwork is not defined as an inner class (at least not in a way I am familiar with). What we have is : public class N

Re: building from james head

2003-08-24 Thread Stephen McConnell
Seems that commons-pool is required but not included in the lib directory. Have fixed this and am moving on with testing. Stephen. Stephen McConnell wrote: Earlier today I tested James against a local version of the james CVS using the final cornerstone builds. That worked fine and James buil

building from james head

2003-08-24 Thread Stephen McConnell
Earlier today I tested James against a local version of the james CVS using the final cornerstone builds. That worked fine and James built and run without problem. Following that I started to put in place the changes to the james build.xml and validate against the latest state of James HEAD.