svn commit: r1724381 - in /james/project/trunk/server/protocols/jmap/src: main/java/org/apache/james/jmap/methods/JmapResponse.java test/java/org/apache/james/jmap/methods/JmapResponseWriterImplTest.java

[aduprat]

Author: aduprat
Date: Wed Jan 13 10:11:27 2016
New Revision: 1724381

URL: http://svn.apache.org/viewvc?rev=1724381&view=rev
Log:
JAMES-1648 Stronger typing for Response in JmapResponse. Contributed by Ouazana 
<raphael.ouaz...@linagora.com>

Modified:
    
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/JmapResponse.java
    
james/project/trunk/server/protocols/jmap/src/test/java/org/apache/james/jmap/methods/JmapResponseWriterImplTest.java

Modified: 
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/JmapResponse.java
URL: 
http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/JmapResponse.java?rev=1724381&r1=1724380&r2=1724381&view=diff
==============================================================================
--- 
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/JmapResponse.java
 (original)
+++ 
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/JmapResponse.java
 Wed Jan 13 10:11:27 2016
@@ -33,7 +33,7 @@ public class JmapResponse {
         
         private Method.Response.Name responseName;
         private ClientId id;
-        private Object response;
+        private Method.Response response;
 
         private Builder() {
         }
@@ -48,7 +48,7 @@ public class JmapResponse {
             return this;
         }
         
-        public Builder response(Object response) {
+        public Builder response(Method.Response response) {
             this.response = response;
             return this;
         }
@@ -69,7 +69,7 @@ public class JmapResponse {
         }
     }
 
-    public static class ErrorResponse {
+    public static class ErrorResponse implements Method.Response {
         
         private final String type;
 
@@ -88,9 +88,9 @@ public class JmapResponse {
     
     private final Method.Response.Name method;
     private final ClientId clientId;
-    private final Object response;
+    private final Method.Response response;
     
-    private JmapResponse(Method.Response.Name method, ClientId clientId, 
Object response) {
+    private JmapResponse(Method.Response.Name method, ClientId clientId, 
Method.Response response) {
         this.method = method;
         this.clientId = clientId;
         this.response = response;

Modified: 
james/project/trunk/server/protocols/jmap/src/test/java/org/apache/james/jmap/methods/JmapResponseWriterImplTest.java
URL: 
http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/test/java/org/apache/james/jmap/methods/JmapResponseWriterImplTest.java?rev=1724381&r1=1724380&r2=1724381&view=diff
==============================================================================
--- 
james/project/trunk/server/protocols/jmap/src/test/java/org/apache/james/jmap/methods/JmapResponseWriterImplTest.java
 (original)
+++ 
james/project/trunk/server/protocols/jmap/src/test/java/org/apache/james/jmap/methods/JmapResponseWriterImplTest.java
 Wed Jan 13 10:11:27 2016
@@ -89,7 +89,7 @@ public class JmapResponseWriterImplTest
         
assertThat(response.getClientId()).isEqualTo(ClientId.of(expectedClientId));
     }
 
-    private static class ResponseClass {
+    private static class ResponseClass implements Method.Response {
 
         @SuppressWarnings("unused")
         public String id;



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org