[MailboxAPI] MessageResult contract

2007-11-17 Thread Robert Burrell Donkin
MessageResult (see 1) is a crucial part of the mailboxAPI. however, it's behaviour is not defined. in particular, the API is silent about whether the corresponding method should return a not null value when getIncludedResults() is set for a particular datum. for example, if getIncludedResults() ==

[MailboxAPI] Eliminate MessageResult.getMail...?

2007-11-17 Thread Robert Burrell Donkin
MessageResult.getMail (see 1) is unused and MessageResultImpl lacks a concrete implementation. IMHO the API should either stick to MimeMessage or to Mail: supporting alternative representations seems an unnecessary burden on the implementor. opinions? - robert 1. http://svn.apache.org/repos/a

svn commit: r595928 - in /james/server/trunk/core-library/src: main/java/org/apache/james/mailboxmanager/ main/java/org/apache/james/mailboxmanager/impl/ test/java/org/apache/james/mailboxmanager/

2007-11-17 Thread rdonkin
Author: rdonkin Date: Sat Nov 17 01:45:57 2007 New Revision: 595928 URL: http://svn.apache.org/viewvc?rev=595928&view=rev Log: Implemented MessageResultImpl#getIncludedResults. The included results will be automatically added as data is. This means that the result will accurately reflect the dat

svn commit: r595941 - /james/server/trunk/torque-mailboxmanager-function/src/main/java/org/apache/james/mailboxmanager/torque/TorqueMailbox.java

2007-11-17 Thread rdonkin
Author: rdonkin Date: Sat Nov 17 04:30:01 2007 New Revision: 595941 URL: http://svn.apache.org/viewvc?rev=595941&view=rev Log: Fix buggy locks Modified: james/server/trunk/torque-mailboxmanager-function/src/main/java/org/apache/james/mailboxmanager/torque/TorqueMailbox.java Modified: james