Re: Code organisation: makes guice application easier to discover

2021-06-08 Thread btell...@apache.org
Hello Jean! On 08/06/2021 17:21, Jean Helou wrote: > Hi benoit ! > > On my crusade to reorganize James code related to Guice apps (and >> promote their adoption), I come to the next item of the tick list (after >> ZIP packaging, JIB packaging to enable distribution). >> > These were great

Re: What's the reason for having Username's constructor private?

2021-06-08 Thread btell...@apache.org
Hello Andreas, On 08/06/2021 21:56, Andreas Joseph Krogh wrote: > På tirsdag 08. juni 2021 kl. 16:02:22, skrev Jean Helou > mailto:jean.he...@gmail.com>>: > > Hello Andreas, > > We have an environment where usernames can be *any* character thus the > > rules enforced by Username does

Re: What's the reason for having Username's constructor private?

2021-06-08 Thread Andreas Joseph Krogh
På tirsdag 08. juni 2021 kl. 16:02:22, skrev Jean Helou mailto:jean.he...@gmail.com>>: Hello Andreas, We have an environment where usernames can be *any* character thus the > rules enforced by Username does not apply to us. We were thinking about > subclassing it, until we saw it has a

Re: What's the reason for having Username's constructor private?

2021-06-08 Thread Jean Helou
Hello Andreas, We have an environment where usernames can be *any* character thus the > rules enforced by Username does not apply to us. We were thinking about > subclassing it, until we saw it has a private constructor signaling that it > isn't meant for extending. > Do you mean

What's the reason for having Username's constructor private?

2021-06-08 Thread Andreas Joseph Krogh
We have an environment where usernames can be any character thus the rules enforced by Username does not apply to us. We were thinking about subclassing it, until we saw it has a private constructor signaling that it isn't meant for extending. I propose to change this constructor to be

[jira] [Created] (JAMES-3595) Spooler processing starts before mailetContainer initialisation

2021-06-08 Thread Benoit Tellier (Jira)
Benoit Tellier created JAMES-3595: - Summary: Spooler processing starts before mailetContainer initialisation Key: JAMES-3595 URL: https://issues.apache.org/jira/browse/JAMES-3595 Project: James

Re: Code organisation: makes guice application easier to discover

2021-06-08 Thread Jean Helou
Hi benoit ! On my crusade to reorganize James code related to Guice apps (and > promote their adoption), I come to the next item of the tick list (after > ZIP packaging, JIB packaging to enable distribution). > These were great improvements > I would like to make those application easier to