[james-project] 13/42: [Refactoring] Move ListMailboxAssertTest to JUnit 5

[rcordier]

This is an automated email from the ASF dual-hosted git repository.

rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 78952e1f65839e62bb3820e9e0a50d318f97bbbd
Author: Rene Cordier <rcord...@linagora.com>
AuthorDate: Thu Dec 5 16:24:07 2019 +0700

    [Refactoring] Move ListMailboxAssertTest to JUnit 5
---
 .../store/mail/model/ListMailboxAssert.java        |  2 +-
 .../store/mail/model/ListMailboxAssertTest.java    | 32 +++++++++++-----------
 2 files changed, 17 insertions(+), 17 deletions(-)

diff --git 
a/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/ListMailboxAssert.java
 
b/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/ListMailboxAssert.java
index 39842c5..4d0d55e 100644
--- 
a/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/ListMailboxAssert.java
+++ 
b/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/ListMailboxAssert.java
@@ -35,7 +35,7 @@ public class ListMailboxAssert {
 
     private final List<Mailbox> actual;
 
-    private final List<InnerMailbox> mailboxtoInnerMailbox(List<Mailbox> 
mailboxes) {
+    private List<InnerMailbox> mailboxtoInnerMailbox(List<Mailbox> mailboxes) {
         return mailboxes.stream()
             .map(mailbox ->
                 new InnerMailbox(mailbox.getMailboxId(), mailbox.getUser(), 
mailbox.getName(), mailbox.getNamespace()))
diff --git 
a/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/ListMailboxAssertTest.java
 
b/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/ListMailboxAssertTest.java
index ad4c5c0..ac87c08 100644
--- 
a/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/ListMailboxAssertTest.java
+++ 
b/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/ListMailboxAssertTest.java
@@ -27,36 +27,36 @@ import java.util.List;
 import org.apache.james.core.Username;
 import org.apache.james.mailbox.model.Mailbox;
 import org.apache.james.mailbox.model.MailboxPath;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 
 import com.google.common.collect.ImmutableList;
 
-public class ListMailboxAssertTest {
-    private static final String OTHER_NAMESPACE = "other_namespace";
-    private static final String NAME = "name";
-    private static final Username USER = Username.of("user");
-    private static final String NAMESPACE = "namespace";
-    private static final long UID_VALIDITY = 42;
-    private static final Mailbox mailbox1 = new Mailbox(new 
MailboxPath(NAMESPACE, USER, NAME), UID_VALIDITY);
-    private static final Mailbox mailbox2 = new Mailbox(new 
MailboxPath(OTHER_NAMESPACE, USER, NAME), UID_VALIDITY);
+class ListMailboxAssertTest {
+    static final String OTHER_NAMESPACE = "other_namespace";
+    static final String NAME = "name";
+    static final Username USER = Username.of("user");
+    static final String NAMESPACE = "namespace";
+    static final long UID_VALIDITY = 42;
+    static final Mailbox mailbox1 = new Mailbox(new MailboxPath(NAMESPACE, 
USER, NAME), UID_VALIDITY);
+    static final Mailbox mailbox2 = new Mailbox(new 
MailboxPath(OTHER_NAMESPACE, USER, NAME), UID_VALIDITY);
 
-    private ListMailboxAssert listMaiboxAssert;
-    private List<Mailbox> actualMailbox;
+    ListMailboxAssert listMaiboxAssert;
+    List<Mailbox> actualMailbox;
 
-    @Before
-    public void setUp() {
+    @BeforeEach
+    void setUp() {
         actualMailbox = ImmutableList.of(mailbox1, mailbox2);
         listMaiboxAssert = ListMailboxAssert.assertMailboxes(actualMailbox);
     }
 
     @Test
-    public void initListMailboxAssertShouldWork() {
+    void initListMailboxAssertShouldWork() {
         assertThat(listMaiboxAssert).isNotNull();
     }
 
     @Test
-    public void assertListMailboxShouldWork() {
+    void assertListMailboxShouldWork() {
         assertMailboxes(actualMailbox).containOnly(new Mailbox(new 
MailboxPath(NAMESPACE, USER, NAME), UID_VALIDITY),
             new Mailbox(new MailboxPath(OTHER_NAMESPACE, USER, NAME), 
UID_VALIDITY));
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org