Re: My thoughts on JMAP implementation

2015-12-17 Thread Benoit Tellier
+1 Le 17/12/2015 10:34, Matthieu Baechler a écrit : > > We should probably take the simplest solution : count the message size > on every folder. > - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For

Re: server/data/data-memory (was : Re: My thoughts on JMAP implementation)

2015-12-17 Thread Matthieu Baechler
On 14/12/2015 10:56, Benoit Tellier wrote: In my JAMES-1618 PR I introduced an imMemory UsersRepository (as I wanted to test SieveRepository integration). Le 14/12/2015 08:45, Matthieu Baechler a écrit : On 13/12/2015 12:43, Tellier Benoit wrote: - Why not introducing

define concept (was : Re: james-server-util* location (was : Re: My thoughts on JMAP implementation))

2015-12-17 Thread Matthieu Baechler
On 14/12/2015 11:17, Benoit Tellier wrote: [ propositions about modules location ] I don't agree on most points. It's a pretty obvious case of "we don't share the definition of each concept". So let's try to define concepts : backends-common : modules to share tools between backends.

Re: My thoughts on JMAP implementation

2015-12-17 Thread Matthieu Baechler
On 14/12/2015 10:45, Benoit Tellier wrote: I gonna start answering this one ... Le 14/12/2015 08:58, Matthieu Baechler a écrit : And the last part ... On 13/12/2015 12:43, Tellier Benoit wrote: [...] - I heard JMAP handles unique ID accross email copies. I guess you are compelled to

Re: My thoughts on JMAP implementation

2015-12-14 Thread Benoit Tellier
I gonna start answering this one ... Le 14/12/2015 08:58, Matthieu Baechler a écrit : > And the last part ... > > On 13/12/2015 12:43, Tellier Benoit wrote: > > [...] > >> - I heard JMAP handles unique ID accross email copies. I guess you are >> compelled to support it. How do you plan to

Re: server/data/data-memory (was : Re: My thoughts on JMAP implementation)

2015-12-14 Thread Benoit Tellier
In my JAMES-1618 PR I introduced an imMemory UsersRepository (as I wanted to test SieveRepository integration). Le 14/12/2015 08:45, Matthieu Baechler a écrit : > > > On 13/12/2015 12:43, Tellier Benoit wrote: > >> - Why not introducing /server/data/data-memory for your >>

Re: jmap-integration-testing (was : Re: My thoughts on JMAP implementation)

2015-12-14 Thread Benoit Tellier
Le 14/12/2015 08:42, Matthieu Baechler a écrit : > > > On 13/12/2015 12:43, Tellier Benoit wrote: > > [...] > >>- jmap-integration-testing project is strange to me. >> >>1/ Its location. I think it has nothing to do in protocols, and >> would rather see it in a new folder.

Re: server/protocols vs protocols (was Re: My thoughts on JMAP implementation)

2015-12-14 Thread Benoit Tellier
Le 14/12/2015 08:19, Matthieu Baechler a écrit : > > > On 13/12/2015 12:43, Tellier Benoit wrote: > > [...] > >> - First point, I believe /server/protocols is only here to wrap up the >> /protocols stuff. We of course should have the servlets in >> server/protocols. The responsibilities of

Re: james-server-util* location (was : Re: My thoughts on JMAP implementation)

2015-12-14 Thread Benoit Tellier
Here we have an interesting topic ;-) If I remember well; backend commons was introduced to share common code across James project without introducing meaningless / cycle prone / multiples and fast cardinality growing dependencies. I happened to be on Cassandra between data-cassandra and

My thoughts on JMAP implementation

2015-12-13 Thread Tellier Benoit
I really think JMAP is a nice protocol to use to implement a web mail as it allows user to speak directly to the e-mail server without the need of an IMAP proxy. Protocol structure is clean and well defined. JSON is easy to parse. So I am really excited to see such an implementation in James. I

jmap-integration-testing (was : Re: My thoughts on JMAP implementation)

2015-12-13 Thread Matthieu Baechler
On 13/12/2015 12:43, Tellier Benoit wrote: [...] - jmap-integration-testing project is strange to me. 1/ Its location. I think it has nothing to do in protocols, and would rather see it in a new folder. Something like /server/integration-tests/jmap/cassandra .(again

server/data/data-memory (was : Re: My thoughts on JMAP implementation)

2015-12-13 Thread Matthieu Baechler
On 13/12/2015 12:43, Tellier Benoit wrote: - Why not introducing /server/data/data-memory for your MemoryAccessTokenRepository ? I have upcoming commits to create the project, maybe moving it to data-memory would make sens. The only rational for not doing it yet is to avoid project

Re: My thoughts on JMAP implementation

2015-12-13 Thread Matthieu Baechler
And the last part ... On 13/12/2015 12:43, Tellier Benoit wrote: [...] - I heard JMAP handles unique ID accross email copies. I guess you are compelled to support it. How do you plan to manage it across implementations ? That's a very interesting question. What we think would be a good

server/protocols vs protocols (was Re: My thoughts on JMAP implementation)

2015-12-13 Thread Matthieu Baechler
On 13/12/2015 12:43, Tellier Benoit wrote: [...] - First point, I believe /server/protocols is only here to wrap up the /protocols stuff. We of course should have the servlets in server/protocols. The responsibilities of such server/protocols are for me to identify commands and encode

Re: My thoughts on JMAP implementation

2015-12-13 Thread Matthieu Baechler
Hi Benoit, Thank you for the review, I'll split my answer into several mails to avoid mixin subjects. -- Matthieu Baechler On 13/12/2015 12:43, Tellier Benoit wrote: I really think JMAP is a nice protocol to use to implement a web mail as it allows user to speak directly to the e-mail

james-server-util* location (was : Re: My thoughts on JMAP implementation)

2015-12-13 Thread Matthieu Baechler
On 13/12/2015 12:43, Tellier Benoit wrote: [...] - james-server-util is amaizing, as james-server-util-java8 . I like the idea of using these tools broadly. But maybe these projects should be located in backends-common. rather than in server/container ? I find it makes more sens...