[jira] [Commented] (JAMES-3760) MailRepositoryContract is not cleaning the created Mails

2022-05-10 Thread Jean Helou (Jira)


[ 
https://issues.apache.org/jira/browse/JAMES-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534300#comment-17534300
 ] 

Jean Helou commented on JAMES-3760:
---

Wouldn't that make it tricky to distinguish between "expected" warnings that 
stem from the testing code itself from warnings introduced by new production 
code ?

> MailRepositoryContract is not cleaning the created Mails
> 
>
> Key: JAMES-3760
> URL: https://issues.apache.org/jira/browse/JAMES-3760
> Project: James Server
>  Issue Type: Bug
>  Components: tests
>Affects Versions: master
>Reporter: Matthieu Baechler
>Priority: Minor
>
> Once https://issues.apache.org/jira/browse/JAMES-3759 is fixed, a lot of 
> leaks are detected when running 
> {code:java}
> MailRepositoryContract{code}
> The root cause is 
> {noformat}
> createMail{noformat}
> generates MailImpl instances which need to be disposed



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org



[jira] [Commented] (JAMES-3760) MailRepositoryContract is not cleaning the created Mails

2022-05-05 Thread Benoit Tellier (Jira)


[ 
https://issues.apache.org/jira/browse/JAMES-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17532106#comment-17532106
 ] 

Benoit Tellier commented on JAMES-3760:
---

I wonder if we could not decide to not activate leak detection in tests and 
keep this in strategic places, eg integration tests.

A good lifecycle management in tests might be achievable if we reduce the scope.

> MailRepositoryContract is not cleaning the created Mails
> 
>
> Key: JAMES-3760
> URL: https://issues.apache.org/jira/browse/JAMES-3760
> Project: James Server
>  Issue Type: Bug
>  Components: tests
>Affects Versions: master
>Reporter: Matthieu Baechler
>Priority: Minor
>
> Once https://issues.apache.org/jira/browse/JAMES-3759 is fixed, a lot of 
> leaks are detected when running 
> {code:java}
> MailRepositoryContract{code}
> The root cause is 
> {noformat}
> createMail{noformat}
> generates MailImpl instances which need to be disposed



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org



[jira] [Commented] (JAMES-3760) MailRepositoryContract is not cleaning the created Mails

2022-05-05 Thread Benoit Tellier (Jira)


[ 
https://issues.apache.org/jira/browse/JAMES-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17532104#comment-17532104
 ] 

Benoit Tellier commented on JAMES-3760:
---

Similar issues happens for mailqueue contracts. Many more places in tests ight 
be concerned.

Also in memory data strucutres (memory mail queue, memory mail repository would 
be considered as a leak)

> MailRepositoryContract is not cleaning the created Mails
> 
>
> Key: JAMES-3760
> URL: https://issues.apache.org/jira/browse/JAMES-3760
> Project: James Server
>  Issue Type: Bug
>  Components: tests
>Affects Versions: master
>Reporter: Matthieu Baechler
>Priority: Minor
>
> Once https://issues.apache.org/jira/browse/JAMES-3759 is fixed, a lot of 
> leaks are detected when running 
> {code:java}
> MailRepositoryContract{code}
> The root cause is 
> {noformat}
> createMail{noformat}
> generates MailImpl instances which need to be disposed



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org