[jira] Commented: (JAMES-465) Check for valid sender domain in mail from
[ http://issues.apache.org/jira/browse/JAMES-465?page=comments#action_12375505 ] Norman Maurer commented on JAMES-465: - Forget to post the RFC-Part: The lookup first attempts to locate an MX record associated with the name. If a CNAME record is found instead, the resulting name is processed as if it were the initial name. If no MX records are found, but an A RR is found, the A RR is treated as if it was associated with an implicit MX RR, with a preference of 0, pointing to that host. its in RFC: http://www.ietf.org/rfc/rfc2821.txt 5. Address Resolution and Mail Handling > Check for valid sender domain in mail from > -- > > Key: JAMES-465 > URL: http://issues.apache.org/jira/browse/JAMES-465 > Project: James > Type: New Feature > Reporter: Norman Maurer > Assignee: Stefano Bagnara > Fix For: 2.3.0a2 > Attachments: MailCmdHandler-Resolv-Fixed.patch, > MailCmdHandler-Resolv-V2.patch, MailCmdHandler-Resolv.patch, > MailCmdHandler-ignoreRelay.patch, MailFrom-rfc-fix-all.patch, > SMTPServerTest-Resolv.patch, SMTPServerTest-ignore-relayClient.patch, > SMTPTestConfiguration-Resolv.patch, > SMTPTestConfiguration-ignore-relayClient.patch, > james-config.xml-Resolv.patch, james-config.xml-ignoreRelay.patch > > I wrote a patch to support checking for resolvable domain in sender before > accept "mail from:" -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (JAMES-465) Check for valid sender domain in mail from
[ http://issues.apache.org/jira/browse/JAMES-465?page=comments#action_12374090 ] Norman Maurer commented on JAMES-465: - Sounds good for me.. > Check for valid sender domain in mail from > -- > > Key: JAMES-465 > URL: http://issues.apache.org/jira/browse/JAMES-465 > Project: James > Type: New Feature > Reporter: Norman Maurer > Assignee: Stefano Bagnara > Fix For: 2.3.0a2 > Attachments: MailCmdHandler-Resolv-Fixed.patch, > MailCmdHandler-Resolv-V2.patch, MailCmdHandler-Resolv.patch, > MailCmdHandler-ignoreRelay.patch, SMTPServerTest-Resolv.patch, > SMTPServerTest-ignore-relayClient.patch, SMTPTestConfiguration-Resolv.patch, > SMTPTestConfiguration-ignore-relayClient.patch, > james-config.xml-Resolv.patch, james-config.xml-ignoreRelay.patch > > I wrote a patch to support checking for resolvable domain in sender before > accept "mail from:" -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [jira] Commented: (JAMES-465) Check for valid sender domain in mail from
The last patch i submit to jira about this feature add the comment to the config.xml to tell this. bye Am Dienstag, den 11.04.2006, 19:16 +0200 schrieb Stefano Bagnara: > Norman Maurer wrote: > > What i have forget is .. your wrote: > > > > Not all resolvable/valid domains also have valid mx records configured. > > > > A valid domain which is included in sender must have a valid MX.. > > Otherwise it would be impossible to send an email back. So i think the > > MX is the only we should check. > > Sure, that's right. I wanted to point out that we should document that > the check is about MX presence and not "generic validity". > > And yes, the mx check seems to me more correct and the only we should > check (if the check is enabled). > > Stefano > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > !EXCUBATOR:1,443be4da37021537427187! signature.asc Description: Dies ist ein digital signierter Nachrichtenteil
Re: [jira] Commented: (JAMES-465) Check for valid sender domain in mail from
Norman Maurer wrote: What i have forget is .. your wrote: Not all resolvable/valid domains also have valid mx records configured. A valid domain which is included in sender must have a valid MX.. Otherwise it would be impossible to send an email back. So i think the MX is the only we should check. Sure, that's right. I wanted to point out that we should document that the check is about MX presence and not "generic validity". And yes, the mx check seems to me more correct and the only we should check (if the check is enabled). Stefano - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [jira] Commented: (JAMES-465) Check for valid sender domain in mail from
What i have forget is .. your wrote: Not all resolvable/valid domains also have valid mx records configured. A valid domain which is included in sender must have a valid MX.. Otherwise it would be impossible to send an email back. So i think the MX is the only we should check. bye Am Dienstag, den 11.04.2006, 10:56 +0100 schrieb Stefano Bagnara (JIRA): > [ > http://issues.apache.org/jira/browse/JAMES-465?page=comments#action_12373992 > ] > > Stefano Bagnara commented on JAMES-465: > --- > > We should document explicitly that the check done is: valid MX record for the > domain and not simply resolvable domain name. > Not all resolvable/valid domains also have valid mx records configured. > They are 2 different checks. > > > Check for valid sender domain in mail from > > -- > > > > Key: JAMES-465 > > URL: http://issues.apache.org/jira/browse/JAMES-465 > > Project: James > > Type: New Feature > > > Reporter: Norman Maurer > > Assignee: Stefano Bagnara > > Attachments: MailCmdHandler-Resolv-Fixed.patch, > > MailCmdHandler-Resolv-V2.patch, MailCmdHandler-Resolv.patch, > > SMTPServerTest-Resolv.patch, SMTPTestConfiguration-Resolv.patch, > > james-config.xml-Resolv.patch > > > > I wrote a patch to support checking for resolvable domain in sender before > > accept "mail from:" > signature.asc Description: Dies ist ein digital signierter Nachrichtenteil
[jira] Commented: (JAMES-465) Check for valid sender domain in mail from
[ http://issues.apache.org/jira/browse/JAMES-465?page=comments#action_12373996 ] Norman Maurer commented on JAMES-465: - Plz have a look at the patches i post.. I think that whould make more sense,, The same should be made to EHLO/HELO check. Now the junit tests need to get updated.. > Check for valid sender domain in mail from > -- > > Key: JAMES-465 > URL: http://issues.apache.org/jira/browse/JAMES-465 > Project: James > Type: New Feature > Reporter: Norman Maurer > Assignee: Stefano Bagnara > Attachments: MailCmdHandler-Resolv-Fixed.patch, > MailCmdHandler-Resolv-V2.patch, MailCmdHandler-Resolv.patch, > MailCmdHandler-ignoreRelay.patch, SMTPServerTest-Resolv.patch, > SMTPTestConfiguration-Resolv.patch, james-config.xml-Resolv.patch, > james-config.xml-ignoreRelay.patch > > I wrote a patch to support checking for resolvable domain in sender before > accept "mail from:" -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (JAMES-465) Check for valid sender domain in mail from
[ http://issues.apache.org/jira/browse/JAMES-465?page=comments#action_12373993 ] Norman Maurer commented on JAMES-465: - true! let me post a new patch for this.. i will post it in about 30 Minutes. We only should check MX . A record is not necassary for this. > Check for valid sender domain in mail from > -- > > Key: JAMES-465 > URL: http://issues.apache.org/jira/browse/JAMES-465 > Project: James > Type: New Feature > Reporter: Norman Maurer > Assignee: Stefano Bagnara > Attachments: MailCmdHandler-Resolv-Fixed.patch, > MailCmdHandler-Resolv-V2.patch, MailCmdHandler-Resolv.patch, > SMTPServerTest-Resolv.patch, SMTPTestConfiguration-Resolv.patch, > james-config.xml-Resolv.patch > > I wrote a patch to support checking for resolvable domain in sender before > accept "mail from:" -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (JAMES-465) Check for valid sender domain in mail from
[ http://issues.apache.org/jira/browse/JAMES-465?page=comments#action_12373992 ] Stefano Bagnara commented on JAMES-465: --- We should document explicitly that the check done is: valid MX record for the domain and not simply resolvable domain name. Not all resolvable/valid domains also have valid mx records configured. They are 2 different checks. > Check for valid sender domain in mail from > -- > > Key: JAMES-465 > URL: http://issues.apache.org/jira/browse/JAMES-465 > Project: James > Type: New Feature > Reporter: Norman Maurer > Assignee: Stefano Bagnara > Attachments: MailCmdHandler-Resolv-Fixed.patch, > MailCmdHandler-Resolv-V2.patch, MailCmdHandler-Resolv.patch, > SMTPServerTest-Resolv.patch, SMTPTestConfiguration-Resolv.patch, > james-config.xml-Resolv.patch > > I wrote a patch to support checking for resolvable domain in sender before > accept "mail from:" -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (JAMES-465) Check for valid sender domain in mail from
[ http://issues.apache.org/jira/browse/JAMES-465?page=comments#action_12373991 ] Stefano Bagnara commented on JAMES-465: --- I changed the MailCmdHandler to lookup for a DNSServer service removing the dependencies from Xbill. In the SMTPServerTest I created a mock DNSServer that only provide results when the host is "james.apache.org". Please review/check my patch. About your last comment, IMHO, 1 is included in 2. The default configuration is to relay mail from localhost. > Check for valid sender domain in mail from > -- > > Key: JAMES-465 > URL: http://issues.apache.org/jira/browse/JAMES-465 > Project: James > Type: New Feature > Reporter: Norman Maurer > Assignee: Stefano Bagnara > Attachments: MailCmdHandler-Resolv-Fixed.patch, > MailCmdHandler-Resolv-V2.patch, MailCmdHandler-Resolv.patch, > SMTPServerTest-Resolv.patch, SMTPTestConfiguration-Resolv.patch, > james-config.xml-Resolv.patch > > I wrote a patch to support checking for resolvable domain in sender before > accept "mail from:" -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (JAMES-465) Check for valid sender domain in mail from
[ http://issues.apache.org/jira/browse/JAMES-465?page=comments#action_12373987 ] Norman Maurer commented on JAMES-465: - Some improvments should be made (im on the way to finish them): 1. mail from domain should not be checked if the connection was made from localhost 2. Configuration value to ignore clients that are allowed to relay. > Check for valid sender domain in mail from > -- > > Key: JAMES-465 > URL: http://issues.apache.org/jira/browse/JAMES-465 > Project: James > Type: New Feature > Reporter: Norman Maurer > Assignee: Stefano Bagnara > Attachments: MailCmdHandler-Resolv-Fixed.patch, > MailCmdHandler-Resolv-V2.patch, MailCmdHandler-Resolv.patch, > SMTPServerTest-Resolv.patch, SMTPTestConfiguration-Resolv.patch, > james-config.xml-Resolv.patch > > I wrote a patch to support checking for resolvable domain in sender before > accept "mail from:" -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Question on : [jira] Commented: (JAMES-465) Check for valid sender domain in mail from
I don't understand your question. The check test if the domainpart of
the emailaddress as a valid mx record. Maybe you just get confused by
the senderAddress.getHost(); ?
if senderAddress = [EMAIL PROTECTED] then senderAddress.getHost() =
byteaction.de .. Maybe the getHost is a bit confusing it would be better
undetstable if it would be called getDomain or something like that..
So this patch did what you want or im wrong ?
bye
Am Montag, den 10.04.2006, 10:53 -0500 schrieb Boomgaart, Paul:
> Norman,
>
> I'm very excited by this feature and any other feature that allow for
> delivery failure of spam notification during the SMTP handshake.
>
> Given this implementation:
> if (checkValidSenderDomain == true) {
> +
> +// Maybe we should build a static method in
> org.apache.james.dnsserver.DNSServer ?
> +Record[] records;
> +
> +try {
> +records = new Lookup(senderAddress.getHost(),
> Type.MX).run();
> +getLogger().info("rec: "+ records);
> +if (records == null) {
> +badSenderDomain = true;
> +}
> +} catch (TextParseException e) {
> +// no validdomain
> +badSenderDomain = true;
> +}
> +
> +// try to resolv the provided domain in the
> senderaddress. If it can not resolved do not accept it.
> +if (badSenderDomain) {
> +responseString = "501
> "+DSNStatus.getStatus(DSNStatus.PERMANENT,DSNStatus.ADDRESS_SYNTAX_SENDE
> R)+ " sender " + senderAddress + " contains no valid domain";
> +session.writeResponse(responseString);
> +getLogger().info(responseString);
> +}
> +}
>
> Question:
> Would it be possible to have the resulting records matched against the
> mail sender's reported address?
>
> Here is the use case I was thinking off:
> Is someone is using an open relay to spam my server, and that open relay
> is using one of the bigger ISP (Like Roadrunner etc), then the DNS
> lookup will work, because they will get an address like:
> user.24.63.45.10.rr.com.
>
> Now if the sender's email was fabricated
> ([EMAIL PROTECTED]) pleasebymoreuselessstuff.com would
> not match user.24.63.45.10.rr.com, and we could refuse the SMTP
> transaction.
>
> Paul
>
>
>
> -----Original Message-
> From: Norman Maurer (JIRA) [mailto:[EMAIL PROTECTED]
> Sent: Sunday, April 09, 2006 12:20 PM
> To: [email protected]
> Subject: [jira] Commented: (JAMES-465) Check for valid sender domain in
> mail from
>
> [
> http://issues.apache.org/jira/browse/JAMES-465?page=comments#action_1237
> 3784 ]
>
> Norman Maurer commented on JAMES-465:
> -
>
> Maybe you want to mark it as resolved. cause you commited it ..
>
> > Check for valid sender domain in mail from
> > --
> >
> > Key: JAMES-465
> > URL: http://issues.apache.org/jira/browse/JAMES-465
> > Project: James
> > Type: New Feature
>
> > Reporter: Norman Maurer
> > Assignee: Stefano Bagnara
> > Attachments: MailCmdHandler-Resolv-Fixed.patch,
> MailCmdHandler-Resolv-V2.patch, MailCmdHandler-Resolv.patch,
> SMTPServerTest-Resolv.patch, SMTPTestConfiguration-Resolv.patch,
> james-config.xml-Resolv.patch
> >
> > I wrote a patch to support checking for resolvable domain in sender
> before accept "mail from:"
>
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
[jira] Commented: (JAMES-465) Check for valid sender domain in mail from
[ http://issues.apache.org/jira/browse/JAMES-465?page=comments#action_12373784 ] Norman Maurer commented on JAMES-465: - Maybe you want to mark it as resolved. cause you commited it .. > Check for valid sender domain in mail from > -- > > Key: JAMES-465 > URL: http://issues.apache.org/jira/browse/JAMES-465 > Project: James > Type: New Feature > Reporter: Norman Maurer > Assignee: Stefano Bagnara > Attachments: MailCmdHandler-Resolv-Fixed.patch, > MailCmdHandler-Resolv-V2.patch, MailCmdHandler-Resolv.patch, > SMTPServerTest-Resolv.patch, SMTPTestConfiguration-Resolv.patch, > james-config.xml-Resolv.patch > > I wrote a patch to support checking for resolvable domain in sender before > accept "mail from:" -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [jira] Commented: (JAMES-465) Check for valid sender domain in mail from
Norman Maurer wrote: Can you give me a tip howto access the getMailServer method for a Handler in the SMTPandler chain ? Probably it's not supported right now. We should change the SMTPHandlerChain that already support configurable handlers, to also support Serviceable handlers. We should add the serviceable interface to the SMTPHandlerChain, and call the service of the handlerChain in the SMTPServer.service() method. Then in the service() method of the SMTPHandlerChain we can cycle over the handler and call ContainerUtil.service(handler,serviceManager) for each one. Then in the handler you implement the serviceable interface and use the ServiceManager.lookup(MailServer.ROLE) method to get the mailserver. Stefano - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [jira] Commented: (JAMES-465) Check for valid sender domain in mail from
Can you give me a tip howto access the getMailServer method for a Handler in the SMTPandler chain ? bye Ps: Thx for the tip. Am Samstag, den 01.04.2006, 18:55 +0100 schrieb Stefano Bagnara (JIRA): > [ > http://issues.apache.org/jira/browse/JAMES-465?page=comments#action_12372792 > ] > > Stefano Bagnara commented on JAMES-465: > --- > > Maybe you want to look at the SenderInFakeDomain.java matcher, that already > does a similar job. > > > Check for valid sender domain in mail from > > -- > > > > Key: JAMES-465 > > URL: http://issues.apache.org/jira/browse/JAMES-465 > > Project: James > > Type: New Feature > > Reporter: Norman Maurer > > Assignee: Stefano Bagnara > > Attachments: MailCmdHandler-Resolv-V2.patch, MailCmdHandler-Resolv.patch, > > SMTPServerTest-Resolv.patch, SMTPTestConfiguration-Resolv.patch, > > james-config.xml-Resolv.patch > > > > I wrote a patch to support checking for resolvable domain in sender before > > accept "mail from:" > signature.asc Description: Dies ist ein digital signierter Nachrichtenteil
[jira] Commented: (JAMES-465) Check for valid sender domain in mail from
[ http://issues.apache.org/jira/browse/JAMES-465?page=comments#action_12372792 ] Stefano Bagnara commented on JAMES-465: --- Maybe you want to look at the SenderInFakeDomain.java matcher, that already does a similar job. > Check for valid sender domain in mail from > -- > > Key: JAMES-465 > URL: http://issues.apache.org/jira/browse/JAMES-465 > Project: James > Type: New Feature > Reporter: Norman Maurer > Assignee: Stefano Bagnara > Attachments: MailCmdHandler-Resolv-V2.patch, MailCmdHandler-Resolv.patch, > SMTPServerTest-Resolv.patch, SMTPTestConfiguration-Resolv.patch, > james-config.xml-Resolv.patch > > I wrote a patch to support checking for resolvable domain in sender before > accept "mail from:" -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (JAMES-465) Check for valid sender domain in mail from
[ http://issues.apache.org/jira/browse/JAMES-465?page=comments#action_12372785 ] Norman Maurer commented on JAMES-465: - After reread docs for mfdnschecks i notice that i checked the wrong dns entry. I checked for A records but it should check for MX records. I will fix it and add a new patch for the MailCmdHandler. All other patches should not be affected. > Check for valid sender domain in mail from > -- > > Key: JAMES-465 > URL: http://issues.apache.org/jira/browse/JAMES-465 > Project: James > Type: New Feature > Reporter: Norman Maurer > Attachments: MailCmdHandler-Resolv-V2.patch, MailCmdHandler-Resolv.patch, > SMTPServerTest-Resolv.patch, SMTPTestConfiguration-Resolv.patch, > james-config.xml-Resolv.patch > > I wrote a patch to support checking for resolvable domain in sender before > accept "mail from:" -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (JAMES-465) Check for valid sender domain in mail from
[ http://issues.apache.org/jira/browse/JAMES-465?page=comments#action_12372732 ] Norman Maurer commented on JAMES-465: - Feature complete > Check for valid sender domain in mail from > -- > > Key: JAMES-465 > URL: http://issues.apache.org/jira/browse/JAMES-465 > Project: James > Type: New Feature > Reporter: Norman Maurer > Attachments: MailCmdHandler-Resolv.patch, SMTPServerTest-Resolv.patch, > SMTPTestConfiguration-Resolv.patch, james-config.xml-Resolv.patch > > I wrote a patch to support checking for resolvable domain in sender before > accept "mail from:" -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
