Changeset: 6da3527317ff
Author:kevinw
Date: 2010-12-17 12:14 +
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/6da3527317ff
7003487: clhsdbproc stacktrace fails on x64
Reviewed-by: phh
! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java
On 12/17/2010 12:31 PM, Keith McGuigan wrote:
On Dec 17, 2010, at 1:43 PM, Daniel D. Daugherty wrote:
src/share/back/eventFilter.c
Don't really need the 'else' on line 292.
Yes, unless we don't bother to check the return value of GetVersion().
I dont expect that will ever fail, but you ne
On Dec 17, 2010, at 1:43 PM, Daniel D. Daugherty wrote:
- don't forget to update the copyright years in the various files
- block comment style is different than existing code. Should be:
/*
* ...
*/
Fixed and fixed.
src/share/back/debugInit.c
Yes, keep the JVM/TI version 0.x compatib
On 12/17/2010 11:35 AM, Keith McGuigan wrote:
On Dec 16, 2010, at 7:18 PM, Mandy Chung wrote:
It's more of the maintainence cost and readability
(supporting the latest version vs all existing versions 1.1 and up)
that I'd like to give my feedback so that you (new owner) can m
On 12/15/2010 9:37 PM, Keith McGuigan wrote:
Ok, here's a new webrev:
http://cr.openjdk.java.net/~kamg/6436034/webrev.01/
I added a regression test and modified the code in debugInit.cpp to
explicitly allow running with JVMTI 1.1 if that's what the JVM
supports. The regression test is setup
On Dec 16, 2010, at 7:18 PM, Mandy Chung wrote:
It's more of the maintainence cost and readability (supporting the
latest version vs all existing versions 1.1 and up) that I'd like to
give my feedback so that you (new owner) can make the right
judgement call :)
I don't claim to own any
