Re: Pls (re)review 6173675/7003271: per-thread memory allocation measurement

2011-01-09 Thread Paul Hohensee
I'll file a CR. Thanks for your review! Pul On 1/10/11 2:01 AM, David Holmes wrote: Paul Hohensee said the following on 01/10/11 16:42: My bad on the 7003271 webrev. It's already pushed. The only one to review is 6173675. I replaced initialLongArray with java.util.Arrays.fill. I took the

Re: Pls (re)review 6173675/7003271: per-thread memory allocation measurement

2011-01-09 Thread David Holmes
Paul Hohensee said the following on 01/10/11 16:42: My bad on the 7003271 webrev. It's already pushed. The only one to review is 6173675. I replaced initialLongArray with java.util.Arrays.fill. I took the code for ThreadCpuTimeArray.java from test/java/lang/management/ ThreadCpuTime.java. Th

Re: Pls (re)review 6173675/7003271: per-thread memory allocation measurement

2011-01-09 Thread Paul Hohensee
My bad on the 7003271 webrev. It's already pushed. The only one to review is 6173675. I replaced initialLongArray with java.util.Arrays.fill. I took the code for ThreadCpuTimeArray.java from test/java/lang/management/ ThreadCpuTime.java. The check for DELTA was in that code, so I kept it. S

Re: Pls (re)review 6173675/7003271: per-thread memory allocation measurement

2011-01-09 Thread David Holmes
Hi Paul, Partial re-review :) Paul Hohensee said the following on 01/10/11 11:10: Thanks to all who reviewed the previous webrev. Revised versions are here http://cr.openjdk.java.net/~phh/6173675/webrev.02/ In ThreadImpl.java you could replace: long[] times = initialLongArray(length, -

Pls (re)review 6173675/7003271: per-thread memory allocation measurement

2011-01-09 Thread Paul Hohensee
Thanks to all who reviewed the previous webrev. Revised versions are here http://cr.openjdk.java.net/~phh/6173675/webrev.02/ http://cr.openjdk.java.net/~phh/7003271/webrev.02/ The interesting changes are in the library side for 6173675. In particular, I've added 3 unit tests. Thanks for any r

hg: jdk7/hotspot-rt/hotspot: 7010665: Misplaced membar in C1 implementation of Unsafe.get/putXXX

2011-01-09 Thread david . holmes
Changeset: df307487d610 Author:dholmes Date: 2011-01-09 17:16 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/df307487d610 7010665: Misplaced membar in C1 implementation of Unsafe.get/putXXX Summary: Modify membars to match regular volatile variable handling Review