hg: jdk7/hotspot-rt/jdk: 90 new changesets

2011-03-17 Thread john . coomes
Changeset: 864b669d54d8 Author:lana Date: 2011-02-21 19:43 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/864b669d54d8 Merge - make/sun/jkernel/FILES_c_windows.gmk - make/sun/jkernel/FILES_java.gmk - make/sun/jkernel/Makefile - src/share/classes/java/io/TempFileHelpe

hg: jdk7/hotspot-rt/jaxws: 3 new changesets

2011-03-17 Thread john . coomes
Changeset: ba12732b1453 Author:ohair Date: 2011-03-10 13:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxws/rev/ba12732b1453 7025412: make381 issues with quotes in jdk/make/docs/Makefile and other places Reviewed-by: mchung ! make/Makefile Changeset: 545de8303fec Autho

hg: jdk7/hotspot-rt/corba: Added tag jdk7-b134 for changeset 918003855fa0

2011-03-17 Thread john . coomes
Changeset: e0b72ae5dc5e Author:schien Date: 2011-03-17 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/e0b72ae5dc5e Added tag jdk7-b134 for changeset 918003855fa0 ! .hgtags

hg: jdk7/hotspot-rt/jaxp: 7 new changesets

2011-03-17 Thread john . coomes
Changeset: 877fd25c5a2f Author:ohair Date: 2011-03-02 12:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxp/rev/877fd25c5a2f 7023289: jaxp 1.4.5 development jdk7 2nd integration Reviewed-by: joehw, mchung, alanb ! jaxp.properties Changeset: b693ccf23fb7 Author:lana

hg: jdk7/tl/jdk: 7022382: convert pack200 library code to use try-with-resources

2011-03-17 Thread stuart . marks
Changeset: 192bbf6cd5de Author:smarks Date: 2011-03-17 18:50 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/192bbf6cd5de 7022382: convert pack200 library code to use try-with-resources Reviewed-by: ksrini ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! sr

Re: code review for attach on demand (AOD) fix for Windows (7028668)

2011-03-17 Thread Daniel D. Daugherty
Thanks Kelly for being patient about sprintf()! And thanks for the quick review! (forgot to say that earlier) Dan On 3/17/2011 6:38 PM, Kelly O'Hair wrote: On Mar 17, 2011, at 1:34 PM, Daniel D. Daugherty wrote: On 3/17/2011 2:29 PM, Kelly O'Hair wrote: Dan, It l

Re: code review for attach on demand (AOD) fix for Windows (7028668)

2011-03-17 Thread Kelly O'Hair
On Mar 17, 2011, at 1:34 PM, Daniel D. Daugherty wrote: > On 3/17/2011 2:29 PM, Kelly O'Hair wrote: >> >> Dan, >> >> It looks ok, but you are using sprintf, and it really should be snprintf. >> On Windows you may need to: >>#define snprintf_snprintf >> > > Yup. I know we have to

hg: jdk7/tl/jdk: 5045147: Prevent insertion of null Key into empty TreeMap (and null element into TreeSet) when no Comparator is used. Prevent insertion of key of incorrect type into empty TreeMap and

2011-03-17 Thread mike . duigou
Changeset: bf37edb38fbb Author:mduigou Date: 2011-03-17 14:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bf37edb38fbb 5045147: Prevent insertion of null Key into empty TreeMap (and null element into TreeSet) when no Comparator is used. Prevent insertion of key of incorre

Re: code review for attach on demand (AOD) fix for Windows (7028668)

2011-03-17 Thread Kelly O'Hair
Dan, It looks ok, but you are using sprintf, and it really should be snprintf. On Windows you may need to: #define snprintf_snprintf --- We (myself included) all need to start being more careful about use of strcpy, strcat, sprintf, etc. The static analysis tools are all starting to j

hg: jdk7/tl/jdk: 2 new changesets

2011-03-17 Thread mike . duigou
Changeset: a8569f14121d Author:mduigou Date: 2011-03-17 13:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a8569f14121d 7028133: Specify serialVersionUID for RegularEnumSet and JumboEnumSet Reviewed-by: alanb, mduigou Contributed-by: Neil Richards ! src/share/classes/java

code review for attach on demand (AOD) fix for Windows (7028668)

2011-03-17 Thread Daniel D. Daugherty
Greetings, I have minor fixes to the Attach On Demand (AOD) Windows specific code that I'd like to get into T&L snapshot for OpenJDK7-B136 (next week): http://cr.openjdk.java.net/~dcubed/7028668-webrev/0/ I'm adding more info to the default detail message for an OpenProcess() failure. I'm al

hg: jdk7/tl/jdk: 6796662: (fmt spec) Formatter spec on BigDecimal output should not reference Float a

2011-03-17 Thread xueming . shen
Changeset: 3eb51bf7e859 Author:sherman Date: 2011-03-17 11:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3eb51bf7e859 6796662: (fmt spec) Formatter spec on BigDecimal output should not reference Float a Summary: updated the spec doc Reviewed-by: alanb ! src/share/classe

hg: jdk7/tl/jdk: 7028422: regression: SKID miss-matching

2011-03-17 Thread xuelei . fan
Changeset: 320bdab4cb2a Author:xuelei Date: 2011-03-17 08:55 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/320bdab4cb2a 7028422: regression: SKID miss-matching Summary: Do not override the previous setting for initial selection. Reviewed-by: mullan ! src/share/classes/sun/

hg: jdk7/tl/jdk: 7026898: DriverManager to now use CopyOnWriteArrayList

2011-03-17 Thread lance . andersen
Changeset: df9991dc1f0d Author:lancea Date: 2011-03-17 11:37 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/df9991dc1f0d 7026898: DriverManager to now use CopyOnWriteArrayList Reviewed-by: alanb, briangoetz ! src/share/classes/java/sql/DriverManager.java

hg: jdk7/hotspot-rt/hotspot: 3 new changesets

2011-03-17 Thread vladimir . danushevsky
Changeset: b9684d5ccb52 Author:vladidan Date: 2011-03-10 14:56 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/b9684d5ccb52 7011490: Wrong computation results in Test6880034 Summary: incorrect handling of c2i deoptimization on little endian architectures Reviewed-b