Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-02 Thread David Holmes
On 3/11/2011 6:14 AM, Daniel D. Daugherty wrote: On 11/2/11 1:29 PM, Kelly O'Hair wrote: This change is both a build change and a serviceability change, but I would argue that it is more of a build change since the functionality of the jvmti demos shouldn't have changed with this. Although I am

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-02 Thread Daniel D. Daugherty
On 11/2/11 1:30 PM, Keith McGuigan wrote: Didn't Dan Dougherty review this too? Is he a "reviewer" for this project? If it helps you can put me down as a reviewer (kamg). I reviewed an earlier version of the changes. And I just reviewed the latest version also so I can also be listed as a r

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-02 Thread Daniel D. Daugherty
On 11/2/11 1:29 PM, Kelly O'Hair wrote: This change is both a build change and a serviceability change, but I would argue that it is more of a build change since the functionality of the jvmti demos shouldn't have changed with this. Although I am listed as a member of the serviceability "group

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-02 Thread Keith McGuigan
Didn't Dan Dougherty review this too? Is he a "reviewer" for this project? If it helps you can put me down as a reviewer (kamg). On Nov 2, 2011, at 2:54 PM, Neil Richards wrote: On Wed, 2011-11-02 at 14:07 -0400, Zhengyu Gu wrote: Hi Neil, My understanding is that you need to have at le

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-02 Thread Kelly O'Hair
This change is both a build change and a serviceability change, but I would argue that it is more of a build change since the functionality of the jvmti demos shouldn't have changed with this. Although I am listed as a member of the serviceability "group", I'm not exactly sure who leads that gr

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-02 Thread Neil Richards
On Wed, 2011-11-02 at 14:07 -0400, Zhengyu Gu wrote: > Hi Neil, > > My understanding is that you need to have at least two reviewers who > have 'reviewer' privilege, (and I don't have 'reviewer' privilege). > I had a quick leaf through the OpenJDK Bylaws. It looks like the number of necessary

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-02 Thread Zhengyu Gu
Hi Neil, My understanding is that you need to have at least two reviewers who have 'reviewer' privilege, (and I don't have 'reviewer' privilege). Yes, I am tied up, if you can handle the push, that will be great. What java bug id you need? can you use CR 6988099? BTW, here is the link to al

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-02 Thread Neil Richards
On Thu, 2011-10-20 at 09:21 -0700, Kelly O'Hair wrote: > Looks good. > > > -kto > Hi Zhengyu, Given Kelly's blessing, are you now happy to push this change to jdk8? (If you're otherwise tied up, I can drive the mechanics of the push if you provide me with a suitable java bug id to use.) Regar