Re: Code Review Request: 7117570: Warnings in sun.mangement.* and its subpackages

2012-01-10 Thread Mandy Chung
On 1/10/2012 4:35 PM, Kurchi Hazra wrote: Updated webrev with all the above changes incorporated: http://cr.openjdk.java.net/~khazra/7117570/webrev.04/ GarbageCollectorImpl.java L76: nit - needs a space between "for" and "(" SnmpNamedListTableCache.java L215: I assume the unchecked supp

hg: jdk8/tl/jdk: 7128931: Bad HTML escaping in java.lang.Throwable javadoc

2012-01-10 Thread joe . darcy
Changeset: 62dbcbe4c446 Author:darcy Date: 2012-01-10 17:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/62dbcbe4c446 7128931: Bad HTML escaping in java.lang.Throwable javadoc Reviewed-by: mduigou ! src/share/classes/java/lang/Throwable.java

Re: Code Review Request: 7117570: Warnings in sun.mangement.* and its subpackages

2012-01-10 Thread Kurchi Hazra
On 1/10/2012 4:58 PM, Stuart Marks wrote: On 1/10/12 4:35 PM, Kurchi Hazra wrote: Updated webrev with all the above changes incorporated: http://cr.openjdk.java.net/~khazra/7117570/webrev.04/ SnmpNamedListTableCache.java L216,221,225: should it be List rather than List? Will that help get ri

hg: jdk8/tl/jdk: 7112008: Javadoc for j.l.Object.finalize() vs JLS 12.6 Finalization of Class Instances

2012-01-10 Thread joe . darcy
Changeset: 49e64a8fc18f Author:darcy Date: 2012-01-10 17:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/49e64a8fc18f 7112008: Javadoc for j.l.Object.finalize() vs JLS 12.6 Finalization of Class Instances Reviewed-by: mduigou ! src/share/classes/java/lang/Object.java

Re: Code Review Request: 7117570: Warnings in sun.mangement.* and its subpackages

2012-01-10 Thread Stuart Marks
On 1/10/12 4:35 PM, Kurchi Hazra wrote: Updated webrev with all the above changes incorporated: http://cr.openjdk.java.net/~khazra/7117570/webrev.04/ SnmpNamedListTableCache.java L216,221,225: should it be List rather than List? Will that help get rid of the unchecked suppressed warning? - It

Re: Code Review Request: 7117570: Warnings in sun.mangement.* and its subpackages

2012-01-10 Thread Kurchi Hazra
Hi Mandy, Agent.java L221: it should keep passing "x" as the argument to the UnsupportedOperationException constructor (rather than x.getCause()). I actually misread this line in your previous webrev.00 that I missed that "x" is already passed as the argument. GarbageCollectorImpl.

hg: hsx/hotspot-rt/hotspot: 40 new changesets

2012-01-10 Thread keith . mcguigan
Changeset: 3b2b58fb1425 Author:tonyp Date: 2011-12-20 12:59 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3b2b58fb1425 7123165: G1: output during parallel verification can get messed up Summary: Serialize the worker threads that are generating output during paral

hg: jdk8/tl/jdk: 7128584: Typo in sun.misc.VM's private directMemory field comment

2012-01-10 Thread chris . hegarty
Changeset: bba276a6aa0d Author:chegar Date: 2012-01-10 12:48 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bba276a6aa0d 7128584: Typo in sun.misc.VM's private directMemory field comment Reviewed-by: forax, chegar Contributed-by: Krystal Mok ! src/share/classes/sun/misc/VM.

hg: jdk8/tl/jdk: 7123415: Some cases of network interface indexes being read incorrectly

2012-01-10 Thread chris . hegarty
Changeset: d72de8b3fe36 Author:chegar Date: 2012-01-10 10:57 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d72de8b3fe36 7123415: Some cases of network interface indexes being read incorrectly Reviewed-by: chegar Contributed-by: brandon.passan...@oracle.com ! src/solaris/nat