Re: Code Review Request: 7117570: Warnings in sun.mangement.* and its subpackages

2012-01-13 Thread David Holmes
On 13/01/2012 9:26 PM, Dmitry Samersoff wrote: IMHO, exception code 263 } catch (FileNotFoundException e) { 264 error(CONFIG_FILE_OPEN_FAILED, e.getMessage()); 265 } catch (IOException e) { 266 error(CONFIG_FILE_OPEN_FAILED, e.getMessage()); should look

Re: Code Review Request: 7117570: Warnings in sun.mangement.* and its subpackages

2012-01-13 Thread Dmitry Samersoff
David, On 2012-01-13 16:00, David Holmes wrote: Totally disagree - that's not the way to write the exception code. If you have different actions then you use different catch clauses not instanceof: catch (FileNotFoundException fnfe) { error(CONFIG_FILE_NOT_FOUND, fname); }

hg: jdk8/tl/jdk: 7129029: (fs) Unix file system provider should be buildable on platforms that don't support O_NOFOLLOW

2012-01-13 Thread alan . bateman
Changeset: 7e593aa6ad41 Author:littlee Date: 2012-01-13 13:20 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7e593aa6ad41 7129029: (fs) Unix file system provider should be buildable on platforms that don't support O_NOFOLLOW Reviewed-by: alanb !

Re: Code Review Request: 7117570: Warnings in sun.mangement.* and its subpackages

2012-01-13 Thread Mandy Chung
On 1/13/2012 3:26 AM, Dmitry Samersoff wrote: Why is it not relevant any more? Hmm this code is a bit confusing. The sun.management.snmp.AdaptorBootstrap class exists but the snmp runtime classes may not since they are in the closed source. The CNFE is from other snmp class but not