Thank you Dan and Karen!
/R
12 apr 2012 kl. 21.48 skrev "Daniel D. Daugherty" >:
Based on some off-thread discussions, the TRACE_START() call does not
have to happen before the VMInit event is posted so I'm happy with
the code change.
Dan
On 4/12/12 9:21 AM, Daniel D. Daugherty wrote:
I th
Changeset: 100b6c2f75ba
Author:rupashka
Date: 2012-03-22 17:10 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/100b6c2f75ba
6888634: test/closed/javax/swing/Popup/TaskbarPositionTest.java fails
Reviewed-by: alexp
! src/share/classes/javax/swing/JPopupMenu.java
Changes
Changeset: a34aee728ac0
Author:ohair
Date: 2012-04-10 08:14 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/a34aee728ac0
7074397: Build infrastructure changes (makefile re-write)
Summary: New makefiles transition, old and new living side by side for now.
Reviewed-by:
Changeset: fd7f45dd5fca
Author:ohair
Date: 2012-04-10 08:13 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/fd7f45dd5fca
7074397: Build infrastructure changes (makefile re-write)
Summary: New makefiles transition, old and new living side by side for now.
Reviewed-by: o
Changeset: a1b6b8f33d86
Author:ohair
Date: 2012-04-10 08:14 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/a1b6b8f33d86
7074397: Build infrastructure changes (makefile re-write)
Summary: New makefiles transition, old and new living side by side for now.
Reviewed-by:
Changeset: fa0fed83e335
Author:dcubed
Date: 2012-03-23 09:17 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/fa0fed83e335
7136506: FDS: rework jdk repo Full Debug Symbols support
Summary: JPRT needs to use the '-y' option with zip on non-Windows control
builds in order to
Changeset: 70d82f2a6c11
Author:dcubed
Date: 2012-04-12 16:23 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70d82f2a6c11
7160895: tools/launcher/VersionCheck.java attempts to launch .debuginfo
Summary: Do not install .debuginfo files in bin dir.
Reviewed-by: ksrini, sspitsyn
Thanks Serguei!
Dan
On 4/12/12 4:02 PM, serguei.spit...@oracle.com wrote:
Looks good.
Thanks,
Serguei
On 4/12/12 2:03 PM, Daniel D. Daugherty wrote:
The wonderful T&L nightly testing caught an error in my changes
that were reviewed on this thread. On Linux and Solaris, I installed
the .debu
Looks good.
Thanks,
Serguei
On 4/12/12 2:03 PM, Daniel D. Daugherty wrote:
The wonderful T&L nightly testing caught an error in my changes
that were reviewed on this thread. On Linux and Solaris, I installed
the .debuginfo files for programs in $JAVA_HOME/bin. I made a
mistake in the way I inte
Changeset: e65a1756d825
Author:sherman
Date: 2012-04-12 15:01 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e65a1756d825
7067045: replaceAll("\u20ac", "$"); causses
java.lang.StringIndexOutOfBoundsExceptio
Summary: Updated to throw IAE instead.
Reviewed-by: lancea
! src/sh
Thanks Kumar!
Dan
On 4/12/12 3:42 PM, Kumar Srinivasan wrote:
On 4/12/2012 2:03 PM, Daniel D. Daugherty wrote:
The wonderful T&L nightly testing caught an error in my changes
The change looks good to me.
Thanks
Kumar
that were reviewed on this thread. On Linux and Solaris, I installed
t
On 4/12/2012 2:03 PM, Daniel D. Daugherty wrote:
The wonderful T&L nightly testing caught an error in my changes
The change looks good to me.
Thanks
Kumar
that were reviewed on this thread. On Linux and Solaris, I installed
the .debuginfo files for programs in $JAVA_HOME/bin. I made a
mista
The wonderful T&L nightly testing caught an error in my changes
that were reviewed on this thread. On Linux and Solaris, I installed
the .debuginfo files for programs in $JAVA_HOME/bin. I made a
mistake in the way I interpreted what I was seeing in the Windows
code and in $JAVA_HOME/jre/bin. Long
Based on some off-thread discussions, the TRACE_START() call does not
have to happen before the VMInit event is posted so I'm happy with
the code change.
Dan
On 4/12/12 9:21 AM, Daniel D. Daugherty wrote:
I think we may have two problems here.
1) The TRACE_START() call has widened the window b
Summary - code change looks good.
thanks,
Karen
On Apr 12, 2012, at 10:03 AM, Karen Kinnear wrote:
> Dmitry,
>
> I hear your point, there is a comment in the VM Initialization Event that "In
> the case of VM start-up
> failure, this event will not be sent".
>
> That said, the goal of the VM i
Changeset: 587243bf0862
Author:sherman
Date: 2012-04-12 10:55 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/587243bf0862
7152690: Initialization error with charset SJIS_0213 when security manager is
enabled
Summary: To use doPrivileged block to wrap the data reading code
Re
Changeset: 642c6d4aaaed
Author:sherman
Date: 2012-04-12 10:43 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/642c6d4aaaed
7156873: (zipfs) FileSystems.newFileSystem(uri, env) fails for uri with escaped
octets
Summary: To use URI.getRawSchemeSpecificPart() to get the scheme p
Scott, Steffan
(I am he one who put in the original lines of: return -1.0; // not available
being replaced by this patch)
I was reluctant to implement these functions because the linux code was quite
involved and it appeared to me that there might be some additional semantics to
what was imple
Regarding Apple, Roger Hoover would be a good person to look at this, as he's
spent more time in the Darwin levels of the VM. I think he's still partially
attached to the OpenJDK work.
-- Scott
On Apr 10, 2012, at 8:58 AM, Daniel D. Daugherty wrote:
> Staffan,
>
> I reviewed it and I think i
On Apr 12, 2012, at 7:44 AM, Daniel D. Daugherty wrote:
>>
>> Why do we need to change compiler flags besides symbol generation ?
>>
>> e.g. for gcc -O3 -g3 is perfectly valid combination.
>
> You'd have to dig into the history of why a FASTDEBUG flavor build
> chose the options that it did. A
I think we may have two problems here.
1) The TRACE_START() call has widened the window between
the phase change and the VMInit event posting. Was
there a good reason for calling TRACE_START() from
that location? In other words, did it have to happen
before VMInit was posted for some
Dan,
OK. Sorry for disturbing you.
-Dmitry
On 2012-04-12 18:44, Daniel D. Daugherty wrote:
On 4/12/12 8:39 AM, Dmitry Samersoff wrote:
Dan,
We link two semantically different options together and it make me
uncomfortable with this fix.
This JDK fix has the exact same semantics as the HotSp
On 4/12/12 8:39 AM, Dmitry Samersoff wrote:
Dan,
We link two semantically different options together and it make me
uncomfortable with this fix.
This JDK fix has the exact same semantics as the HotSpot
changes that I did for FDS. As I keep saying over and over
and over, a Full Debug Symbols b
Karen,
Thank you for detailed explanation. I agree with you.
Thumbs up.
-Dmitry
On 2012-04-12 18:03, Karen Kinnear wrote:
Dmitry,
I hear your point, there is a comment in the VM Initialization Event that "In
the case of VM start-up
failure, this event will not be sent".
That said, the goa
Dan,
We link two semantically different options together and it make me
uncomfortable with this fix.
Why do we need to change compiler flags besides symbol generation ?
e.g. for gcc -O3 -g3 is perfectly valid combination.
-Dmitry
On 2012-04-12 17:50, Daniel D. Daugherty wrote:
On 4/11/12
I want to take a closer look at the failing test...
Be back soon...
Dan
On 4/12/12 8:03 AM, Karen Kinnear wrote:
Dmitry,
I hear your point, there is a comment in the VM Initialization Event that "In
the case of VM start-up
failure, this event will not be sent".
That said, the goal of the V
Dmitry,
I hear your point, there is a comment in the VM Initialization Event that "In
the case of VM start-up
failure, this event will not be sent".
That said, the goal of the VM initialization event is to inform the agent that
it is free
to call any JNI or JMVTI function. Many agents want to b
On 4/11/12 7:24 PM, Mikael Vidstedt wrote:
On 2012-04-10 14:53, Daniel D. Daugherty wrote:
On 4/10/12 3:47 PM, Dmitry Samersoff wrote:
1.
239 # If Full Debug Symbols is enabled, then we want the same debug
and
240 # optimization flags as used by FASTDEBUG. We also want all the
241 # deb
Rickard,
As far as I understand the code, after your changes we will
post JVMTI event
JvmtiExport::post_vm_initialized();
ever if later JVM aborts on some error.
I'm not sure it's a good idea because in couple of other
places we abort VM without sending the event, so
behavior of agent become
Looks good!
Thanks for fixing!
/Markus
> -Original Message-
> From: Rickard Bäckman
> Sent: den 12 april 2012 14:13
> To: serviceability-dev@openjdk.java.net
> Subject: RFR: 7160924: jvmti: GetPhase returns incorrect phase before
> VMInit event is issued
>
> Hi,
>
> can I get review fo
Hi,
can I get review for this small change? The issue is that if we are
running tracing startup code inbetween setting the phase to
JVMTI_PHASE_LIVE and posting the VMInit event.
Webrev:
http://cr.openjdk.java.net/~rbackman/7160924/webrev/
CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_
Changeset: c98a013ec628
Author:youdwei
Date: 2012-04-12 15:04 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c98a013ec628
6610897: New constructor in sun.tools.java.ClassPath builds a path using
File.separator instead of File.pathSeparator
Reviewed-by: alanb
! src/share/cla
32 matches
Mail list logo
