hg: jdk8/tl/jdk: 7173044: MemoryMonitor hangs if getMax method in MemoryUsage object returns -1

2012-06-04 Thread littlee
Changeset: 4573662cb28c Author:zhouyx Date: 2012-06-05 10:16 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4573662cb28c 7173044: MemoryMonitor hangs if getMax method in MemoryUsage object returns -1 Reviewed-by: dholmes, sspitsyn ! src/share/demo/management/MemoryMonitor/Me

Re: Fwd: Request for review: 7173044: Memory monitor demo hangs if MemoryUsage obj returns -1 in getMax

2012-06-04 Thread Sean Chou
Thanks ! On Tue, Jun 5, 2012 at 1:45 AM, serguei.spit...@oracle.com < serguei.spit...@oracle.com> wrote: > The fix looks good. > > Thanks, > Serguei > > > On 6/3/12 11:20 PM, David Holmes wrote: > > On 4/06/2012 4:20 PM, Sean Chou wrote: > > Thanks David. Do I need one more reviewer to suppo

Re: RFR (S): 7165257: Adding JFR test targets

2012-06-04 Thread Kelly O'Hair
You can add me as the reviewer. But I think you need to send an email out to core-libs-...@openjdk.java.net warning them that you have added the jfr tests to testset=core. So that if they run into jfr failures, they know who to contact. -kto On Jun 4, 2012, at 6:03 AM, Staffan Larsen wrote: >

Re: Fwd: Request for review: 7173044: Memory monitor demo hangs if MemoryUsage obj returns -1 in getMax

2012-06-04 Thread serguei.spit...@oracle.com
The fix looks good. Thanks, Serguei On 6/3/12 11:20 PM, David Holmes wrote: On 4/06/2012 4:20 PM, Sean Chou wrote: Thanks David. Do I need one more reviewer to support as it is a modification to demo ? I honestly don't know. It's a demo in serviceability area, so probably someone from servi

hg: hsx/hotspot-rt/hotspot: 7166498: JVM crash in ClassVerifier

2012-06-04 Thread keith . mcguigan
Changeset: e17b61ba7bb3 Author:kamg Date: 2012-06-04 10:22 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e17b61ba7bb3 7166498: JVM crash in ClassVerifier Summary: Fixed raw pointer being used after potential safepoint/GC Reviewed-by: acorn, fparain, dholmes ! src

Re: RFR (S): 7165257: Adding JFR test targets

2012-06-04 Thread Staffan Larsen
Can someone please review this change? Thanks, /Staffan On 25 maj 2012, at 15:41, Staffan Larsen wrote: > Please review the following change to makefiles to add a target for the JFR > tests. > > Webrev: http://cr.openjdk.java.net/~sla/7165257/webrev.01/ > > Thanks, > /Staffan

hg: jdk8/tl/jdk: 7173036: test/com/sun/jdi/ConnectedVMs.java does not run as expected

2012-06-04 Thread weijun . wang
Changeset: a5bb0343f135 Author:weijun Date: 2012-06-04 18:06 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a5bb0343f135 7173036: test/com/sun/jdi/ConnectedVMs.java does not run as expected Reviewed-by: alanb ! test/com/sun/jdi/ConnectedVMs.java

Re: Code review request: 7173036: test/com/sun/jdi/ConnectedVMs.java does not run as expected

2012-06-04 Thread Alan Bateman
On 31/05/2012 05:35, Weijun Wang wrote: Hi All I was working on something else and noticed a jtreg problem, that it does not handle parenthesis and whitespaces like a normal shell does. A little grep shows this test might not work as expected. Here is the webrev: http://cr.openjdk.java.ne

hg: jdk8/tl/jdk: 7166055: Javadoc for WeakHashMap contains misleading advice

2012-06-04 Thread littlee
Changeset: 237e27c7ddc3 Author:littlee Date: 2012-06-04 16:30 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/237e27c7ddc3 7166055: Javadoc for WeakHashMap contains misleading advice Reviewed-by: dholmes, mduigou ! src/share/classes/java/util/WeakHashMap.java