hg: hsx/hotspot-rt/hotspot: 7191124: Optimized build is broken due to inconsistent use of DEBUG_ONLY and NOT_PRODUCT macros in NMT

2012-08-14 Thread zhengyu . gu
Changeset: e5bf1c79ed5b Author:zgu Date: 2012-08-14 13:56 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e5bf1c79ed5b 7191124: Optimized build is broken due to inconsistent use of DEBUG_ONLY and NOT_PRODUCT macros in NMT Summary: Updated all related variables and

Re: JEP 158: Unified JVM logging

2012-08-14 Thread Yasumasa Suenaga
Hi, Other softwares (e.g. syslog, apache) are implemented log rotation support. When these software receives SIGHUP, they close current log and reopen it. I think that JVM should be supported same level of log management at least. Current implementation, JVM open logs at start, and never close i

JEP 158: Unified JVM logging

2012-08-14 Thread Dmitry Samersoff
Kirk, > However I do have very serious concerns about this JEP in that it > doesn't fix the problems that exist in current logging frameworks, > it only mimics them. > http://openjdk.java.net/jeps/158 Any comments is much appreciated. Personally, I think that log rotation is out of scope and re

Re: 7090324: gclog rotation via external tool

2012-08-14 Thread Kirk Pepperdine
Hi Yasumasa, I'm not sure that log file rotation is a part of this JEP. However I do have very serious concerns about this JEP in that it doesn't fix the problems that exist in current logging frameworks, it only mimics them. Regards, Kirk On 2012-08-14, at 11:20 AM, Yasumasa Suenaga wrote:

Re: 7090324: gclog rotation via external tool

2012-08-14 Thread Yasumasa Suenaga
Hi Staffan, May I ask you 2 questions about this JEP? 1. One of goals of this JEP is defined as following: "File rotation of log files by size (similar to what is available for GC logs today)" My patch realizes log rotation by external trigger. 7090324 is included in this JEP?

Re: 7090324: gclog rotation via external tool

2012-08-14 Thread Staffan Larsen
Hi Yasumasa, This work should be done in the context of the Unified Logging JEP [1]. Unfortunately, that work has not yet started due to resource constraints. Comments on the proposal are welcome. [1] http://openjdk.java.net/jeps/158 /Staffan On 31 jul 2012, at 12:45, Yasumasa Suenaga wrote