On 22/08/2012 9:52 PM, Alan Bateman wrote:
On 22/08/2012 02:26, David Holmes wrote:
I was going to make a similar request. Some context for the problem
and solution makes reviewing a lot easier.
In this case as I understand it between checking the fd for the door
call and making the door call,
Serguei,
Thank you for making changes.
Looks good for me!
-Dmitry
On 2012-08-22 22:34, serguei.spit...@oracle.com wrote:
> Dmitry,
>
> Thank you for the review!
>
> Please, find new webrev version here:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/7191786-JVMTI-LVTT.1/
>
> I also chan
Dmitry,
Thank you for the review!
Please, find new webrev version here:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/7191786-JVMTI-LVTT.1/
I also changed the line:
196 if (elem[idx].signature_cp_index > 0) {
to this:
196 if (elem[idx].signature_cp_index != 0) {
Both are correct as the
Thanks for fixing my comments and providing good reasons for your design. I'm
ok with these changes now.
What the future of SA is remains to be seen, but it's not going to be replaced
very soon.
Thanks,
/Staffan
On 22 aug 2012, at 18:13, BILL PITTORE wrote:
> Updated the webrev at http://cr
Updated the webrev at
http://cr.openjdk.java.net/~bpittore/7154641/webrev.01/
On 8/22/2012 4:20 AM, Staffan Larsen wrote:
I like the idea of using reflection. How much work would it be to make the
change for the existing platforms as well? I don't really like that there are
two different code
On 22/08/2012 02:26, David Holmes wrote:
I was going to make a similar request. Some context for the problem
and solution makes reviewing a lot easier.
In this case as I understand it between checking the fd for the door
call and making the door call, someone can call detach, and so we get
Changeset: be82ef218872
Author:sla
Date: 2012-08-22 10:01 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/be82ef218872
7192916: Hotspot development launcher should use DYLD_LIBRARY_PATH on OS X
Reviewed-by: dholmes, dsamersoff, nloodin
! src/os/posix/launcher/launc
I like the idea of using reflection. How much work would it be to make the
change for the existing platforms as well? I don't really like that there are
two different code paths. Also, you only made the change for Linux.
Some other comments:
LinuxCDebugger.java - This change would return null o
David,
> In this case as I understand it between checking the fd for the door
> call and making the door call, someone can call detach, and so we get
> EBADF. The detach is synchronized on this, so the fix moves the
> enqueue inside the sync block so that it has to complete before
> anyone can cal
