Changeset: 7d42f3b08300
Author:dcubed
Date: 2012-12-19 10:35 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7d42f3b08300
8005044: remove crufty '_g' support from HS runtime code
Summary: Phase 2 is removing '_g' support from the Runtime code.
Reviewed-by: dcubed, c
Real sense of deja-vu here. Didn't we go through this same thing with
the HPI socket routines?
Depending on the OS (and version?) we should be using socklen_t not int
and not uint32_t.
David
On 20/12/2012 2:35 AM, Chris Hegarty wrote:
John,
I grabbed your patch, and with it I now see diffe
Changeset: 1f9c19741285
Author:darcy
Date: 2012-12-19 11:53 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f9c19741285
8005097: Tie isSynthetic javadoc to the JLS
Reviewed-by: mduigou
! src/share/classes/java/lang/Class.java
! src/share/classes/java/lang/reflect/Constructor
Resending...adding back the other aliases...
Bug filed:
JDK-8005262possible gamma launcher issues
https://jbs.oracle.com/bugs/browse/JDK-8005262
Dan
On 12/19/12 11:18 AM, Coleen Phillimore wrote:
On 12/19/2012 12:39 PM, harold seigel wrote:
>> I say file the bug merely to document the i
Closing the loop on this question that I asked earlier:
Just curious, when gamma was renamed to hotspot on Windows, that
change wasn't made on Linux on Solaris. Any particular reason?
On Solaris there is a "hotspot" shell script and a "gamma" binary.
I suspect the same it true for Linux (and
On 19 dec 2012, at 16:22, Daniel D. Daugherty
wrote:
> On 12/19/12 1:27 AM, Staffan Larsen wrote:
>> On 18 dec 2012, at 22:11, Daniel D. Daugherty
>> wrote:
>>
>>> Just for the record: I have reviewed all of Ron's changes
>>> and I approve them.
>>>
>>> One thing I noticed of interest to la
Harold
I would say first off this is not a bug that has manifested itself yet.
So it is low priority.
That being said this exposure is not introduced or made more risky by my
changes.
This is the only issue that we have against this code review and it does not
belong to the changes bein
Changeset: f72c9c5aeaef
Author:jfranck
Date: 2012-12-16 11:09 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f72c9c5aeaef
8005098: Provide isSynthesized() information on Attribute.Compound
Reviewed-by: jjg
! make/build.properties
! src/share/classes/com/sun/tools/javac
John,
I grabbed your patch, and with it I now see different warnings.
../../../../src/share/transport/socket/socketTransport.c: In function
'socketTransport_startListening':
../../../../src/share/transport/socket/socketTransport.c:310:40:
warning: pointer targets in passing argument 3 of 'dbgs
Sounds like time to file a separate bug to track that issue down (particularly
the bsd issue)
and move on with this one.
Thank you so much Dan for the history and details,
Karen
On Dec 19, 2012, at 11:30 AM, Daniel D. Daugherty wrote:
> Adding the other aliases back in...
>
> Harold,
>
> This
Adding the other aliases back in...
Harold,
This question:
> Another nit: Is it worth checking that all of
> "/hotspot/libjvm.so"could get copied to buf? (i.e.: that
> buflen-len > strlen("/hotspot/libjvm.so")
is straight forward and the short answer is: yes, that
code makes assumptions that
John - this is the debugger socket transport so cc'ing the
serviceability-dev list as that is where this code is maintained.
On 19/12/2012 15:36, John Zavgren wrote:
Greetings:
Please consider the following change to the two files:
src/share/transport/socket/sysSocket.h
src/solaris/transport/
On 12/19/12 1:27 AM, Staffan Larsen wrote:
On 18 dec 2012, at 22:11, Daniel D. Daugherty
wrote:
Just for the record: I have reviewed all of Ron's changes
and I approve them.
One thing I noticed of interest to launcher folks that
is not due to any changes that Ron made:
src/os/windows/vm/os_
Harold,
Did you have any more points or counter points to make on the use of snprintf
and strncpy ?
Ron
From: Ron Durbin
Sent: Tuesday, December 18, 2012 4:50 PM
To: Daniel Daugherty; hotspot-runtime-...@openjdk.java.net; build-dev;
serviceability-dev@openjdk.java.net
Subject: RE: Co
Hi Everybody,
Please review JEP changes.
http://cr.openjdk.java.net/~dsamersoff/8002048.JDP/jeps/webrev.01/
-Dmitry
On 2012-11-08 01:02, mark.reinh...@oracle.com wrote:
> Posted: http://openjdk.java.net/jeps/168
>
> - Mark
>
--
Dmitry Samersoff
Oracle Java development team, Saint Petersbu
Changeset: 67b01d295cd2
Author:jjg
Date: 2012-12-19 11:29 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/67b01d295cd2
8004833: Integrate doclint support into javac
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/javac/main/Main.java
! src/share/classes/com/s
The fix is OK for me.
Shanliang
Jaroslav Bachorik wrote:
On 12/18/2012 08:21 PM, shanliang wrote:
It is good to call
gotIOException((IOException)e);
but no need to call in next
restart((IOException)e);
the method "gotIOException" should call "restart" if necessary,
otherwise "resta
Changeset: c79b26b8efe0
Author:sjiang
Date: 2012-12-19 11:06 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c79b26b8efe0
7158614: JMXStartStopTest.sh failing intermittently
Summary: fixed 3 problems here: 1) checked the lock file too eary 2) never got
the process id of a jav
On 12/18/2012 08:21 PM, shanliang wrote:
> It is good to call
>gotIOException((IOException)e);
>
> but no need to call in next
>restart((IOException)e);
>
> the method "gotIOException" should call "restart" if necessary,
> otherwise "restart" may be called 2 times and generated 2 times
>
On 18 dec 2012, at 22:11, Daniel D. Daugherty
wrote:
> Just for the record: I have reviewed all of Ron's changes
> and I approve them.
>
> One thing I noticed of interest to launcher folks that
> is not due to any changes that Ron made:
>
> src/os/windows/vm/os_windows.cpp:
>
> 1718 // Find
20 matches
Mail list logo
