Re: RFR JDK-8005120

2012-12-26 Thread Chris Hegarty
Looks much better, The definition of dbgsysFinishConnect has changed, the second param is now an int, so the windows version of this method should be updated to reflect this. Similarly, the other method definitions that take a socklen_t, dbgsysRecv and dbgsysSend, should reflect the change.

Re: jmx-dev JDK-7120365 DiffHBTest.java fails due to ConcurrentModificationException

2012-12-26 Thread Alan Bateman
On 26/12/2012 15:07, shanliang wrote: Yes should use a cop[y, it is a mistake to use a unmodifiable view. Here is the new webrev: http://cr.openjdk.java.net/~sjiang/JDK-7120365/webrev.02/ I have added a new test to reproduce the bug in an almost sure way. Thanks, Shanliang Thanks for the u

Re: RFR JDK-8005120

2012-12-26 Thread John Zavgren
Greetings: I modified the windows code so that it uses socklen_t to specify the lengths of data structures, parameter lengths, etc. instead of ints (which can be negative.) http://cr.openjdk.java.net/~mullan/webrevs/jzavgren/8005120/webrev.02/ Thanks! John Zavgren On 12/20/2012 05:47 PM, Joh

hg: jdk8/tl/jdk: 2 new changesets

2012-12-26 Thread sean . mullan
Changeset: 4d28776d7007 Author:mullan Date: 2012-12-26 10:07 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4d28776d7007 8005117: Eliminate dependency from ConfigSpiFile to com.sun.security.auth.login.ConfigFile Reviewed-by: alanb, mchung, weijun ! src/share/classes/com/sun

Re: jmx-dev JDK-7120365 DiffHBTest.java fails due to ConcurrentModificationException

2012-12-26 Thread shanliang
Yes should use a cop[y, it is a mistake to use a unmodifiable view. Here is the new webrev: http://cr.openjdk.java.net/~sjiang/JDK-7120365/webrev.02/ I have added a new test to reproduce the bug in an almost sure way. Thanks, Shanliang Alan Bateman wrote: On 24/12/2012 14:08, shanliang wr