Re: Request for review (XS): JDK-8006641: JDK-8003985 broke InstanceKlass.getFieldOffset() in SA

2013-01-21 Thread Krystal Mo
Hi Aleksey, Thanks for the info. Sorry about the fuss, but apparently that fix hasn't landed in hotspot-comp yet. I should have checked other repos first, though. JDK-8006403 should have been linked to JDK-8003985 as "related to" on JBS, that way I would have noticed the fix was in already. I'

hg: hsx/hotspot-rt/hotspot: 63 new changesets

2013-01-21 Thread karen . kinnear
Changeset: e51c9860cf66 Author:jmasa Date: 2012-12-03 15:09 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e51c9860cf66 8005082: NPG: Add specialized Metachunk sizes for reflection and anonymous classloaders Reviewed-by: johnc, coleenp ! src/share/vm/classfile/cl

Re: Request for review (XS): 8006563: Remove unused ProfileVM_lock

2013-01-21 Thread David Holmes
On 22/01/2013 12:09 AM, Rickard Bäckman wrote: Yes, that code has changed. Checked in to hs24. Okay but this is a review for hs25 ;-) So I assume that change will be there "real soon now". :) David /R 21 jan 2013 kl. 02:59 skrev David Holmes: On 18/01/2013 11:45 PM, Rickard Bäckman wrot

hg: jdk8/tl/langtools: 4 new changesets

2013-01-21 Thread maurizio . cimadamore
Changeset: 7873d37f5b37 Author:mcimadamore Date: 2013-01-21 20:13 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7873d37f5b37 8005244: Implement overload resolution as per latest spec EDR Summary: Add support for stuck expressions and provisional applicability Reviewed-

hg: jdk8/tl/jdk: 18 new changesets

2013-01-21 Thread lana . steuck
Changeset: 965e89e2abd3 Author:katleman Date: 2013-01-16 12:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/965e89e2abd3 Added tag jdk8-b73 for changeset 733885f57e14 ! .hgtags Changeset: e91caf05f441 Author:erikj Date: 2012-12-27 20:18 +0100 URL: http://hg

hg: jdk8/tl/jaxp: 6 new changesets

2013-01-21 Thread lana . steuck
Changeset: cf0917c0d771 Author:katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/cf0917c0d771 Added tag jdk8-b73 for changeset 84946404d1e1 ! .hgtags Changeset: 278a2f60c55b Author:erikj Date: 2013-01-04 11:31 +0100 URL: http://h

hg: jdk8/tl/jaxws: 5 new changesets

2013-01-21 Thread lana . steuck
Changeset: 68f508979ffe Author:katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/68f508979ffe Added tag jdk8-b73 for changeset c606f644a5d9 ! .hgtags Changeset: 51f3117e2b75 Author:erikj Date: 2013-01-04 11:31 +0100 URL: http://

hg: jdk8/tl/corba: Added tag jdk8-b73 for changeset 191afde59e7b

2013-01-21 Thread lana . steuck
Changeset: 2132845cf5f7 Author:katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/2132845cf5f7 Added tag jdk8-b73 for changeset 191afde59e7b ! .hgtags

hg: jdk8/tl: 28 new changesets

2013-01-21 Thread lana . steuck
Changeset: 4090847a5444 Author:katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4090847a5444 Added tag jdk8-b73 for changeset 93b9664f97ee ! .hgtags Changeset: 77f062a41850 Author:erikj Date: 2012-12-27 20:15 +0100 URL: http://hg.ope

hg: jdk8/tl/hotspot: 2 new changesets

2013-01-21 Thread lana . steuck
Changeset: 41ccb2e737fb Author:katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/41ccb2e737fb Added tag jdk8-b73 for changeset 11619f33cd68 ! .hgtags Changeset: 1a3e54283c54 Author:katleman Date: 2013-01-16 20:53 -0800 URL: ht

hg: jdk8/tl/langtools: 3 new changesets

2013-01-21 Thread lana . steuck
Changeset: 56c97aff46bb Author:katleman Date: 2013-01-16 12:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/56c97aff46bb Added tag jdk8-b73 for changeset 8d0baee36c71 ! .hgtags Changeset: b450959b42ff Author:lana Date: 2013-01-20 23:39 -0800 URL: http

hg: jdk8/tl/jdk: 8006642: Fix javadoc warnings due to Integer.MAX_VALUE

2013-01-21 Thread lance . andersen
Changeset: de30e46250c5 Author:lancea Date: 2013-01-21 14:08 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de30e46250c5 8006642: Fix javadoc warnings due to Integer.MAX_VALUE Reviewed-by: alanb ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/

Re: Request for review (XS): JDK-8006641: JDK-8003985 broke InstanceKlass.getFieldOffset() in SA

2013-01-21 Thread Aleksey Shipilev
Hi Krystal, On 01/21/2013 10:43 PM, Krystal Mo wrote: > Could someone review this small patch, please? > JDK-8006641: JDK-8003985 broke InstanceKlass.getFieldOffset() in SA This is the duplicate for https://jbs.oracle.com/bugs/browse/JDK-8006403 ...which was already fixed: http://hg.openjdk.

Request for review (XS): JDK-8006641: JDK-8003985 broke InstanceKlass.getFieldOffset() in SA

2013-01-21 Thread Krystal Mo
Hi all, Could someone review this small patch, please? JDK-8006641: JDK-8003985 broke InstanceKlass.getFieldOffset() in SA Webrev: http://cr.openjdk.java.net/~kmo/8006641/webrev.00/ Bug: https://jbs.oracle.com/bugs/browse/JDK-8006641 (public bug will be available soon at: http://bugs.sun.com/b

Re: 8006565: java.lang.instrument specification should make it clear that -javaagent is optional

2013-01-21 Thread Mandy Chung
On 1/21/2013 5:21 AM, Alan Bateman wrote: The optionally of JVM TI is clear in its specification, the status of java.lang.management, You meant java.lang.instrument (as in the subject). or more specifically the -javaagent option is less clear. The change proposed here is to make it very cle

hg: jdk8/tl/langtools: 8006263: Supplementary test cases needed for doclint

2013-01-21 Thread jonathan . gibbons
Changeset: 4a3cfc970c6f Author:jjg Date: 2013-01-21 10:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4a3cfc970c6f 8006263: Supplementary test cases needed for doclint Reviewed-by: mcimadamore Contributed-by: peter.jen...@oracle.com ! src/share/classes/com/sun/tools

Re: 8006565: java.lang.instrument specification should make it clear that -javaagent is optional

2013-01-21 Thread Daniel D. Daugherty
Thumbs up! Dan On 1/21/13 6:21 AM, Alan Bateman wrote: The optionally of JVM TI is clear in its specification, the status of java.lang.management, or more specifically the -javaagent option is less clear. The change proposed here is to make it very clear that -javaagent is not required to

Re: Request for review (XS): 8006563: Remove unused ProfileVM_lock

2013-01-21 Thread Rickard Bäckman
Yes, that code has changed. Checked in to hs24. /R 21 jan 2013 kl. 02:59 skrev David Holmes : > On 18/01/2013 11:45 PM, Rickard Bäckman wrote: >> Aleksey, >> >> thanks for your review! >> >> a) It was before on of my own changes used in os_solaris.cpp (I think, for >> synchronization support

hg: jdk8/tl/jdk: 8005311: Add Scalable Updatable Variables, DoubleAccumulator, DoubleAdder, LongAccumulator, LongAdder

2013-01-21 Thread chris . hegarty
Changeset: f21a3c273fb2 Author:dl Date: 2013-01-21 13:50 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f21a3c273fb2 8005311: Add Scalable Updatable Variables, DoubleAccumulator, DoubleAdder, LongAccumulator, LongAdder Reviewed-by: chegar, darcy, goetz ! make/java/java/FILE

Re: 8006565: java.lang.instrument specification should make it clear that -javaagent is optional

2013-01-21 Thread Staffan Larsen
Looks good. /Staffan On 21 jan 2013, at 14:21, Alan Bateman wrote: > > The optionally of JVM TI is clear in its specification, the status of > java.lang.management, or more specifically the -javaagent option is less > clear. The change proposed here is to make it very clear that -javaagent i

8006565: java.lang.instrument specification should make it clear that -javaagent is optional

2013-01-21 Thread Alan Bateman
The optionally of JVM TI is clear in its specification, the status of java.lang.management, or more specifically the -javaagent option is less clear. The change proposed here is to make it very clear that -javaagent is not required to be supported. The motive is small environments where it sh

hg: hsx/hotspot-rt/hotspot: 8006431: os::Bsd::initialize_system_info() sets _physical_memory too large

2013-01-21 Thread bengt . rutisson
Changeset: c07c102cbad7 Author:brutisso Date: 2013-01-21 09:00 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c07c102cbad7 8006431: os::Bsd::initialize_system_info() sets _physical_memory too large Summary: Use HW_MEMSIZE instead of HW_USERMEM to get a 64 bit value

Re: Errors when use "universe" command in CLHSDB

2013-01-21 Thread Staffan Larsen
On 21 jan 2013, at 08:30, David Holmes wrote: > On 21/01/2013 5:11 PM, Staffan Larsen wrote: >> A webrev is here: http://cr.openjdk.java.net/~sla/8005278/webrev.00/ > > Thanks. > > So based on the error message the actual fix here seems to be in > > src/share/vm/gc_implementation/concurrentMa