http://cr.openjdk.java.net/~stefank/8006506/webrev.03/
1) Reverted the ProblemList change, since the fix has already propagaged
to jdk8/tl
2) Renamed do_redefine - doRedefine
3) Updated the .sh file with the bug number of the original CR instead
of the test CR.
thanks,
StefanK
On
Thanks David!
/Staffan
On 1 feb 2013, at 06:05, David Holmes david.hol...@oracle.com wrote:
Hi Staffan,
First, please refrain from doing code cleanup (long line reformatting)
alongside a fairly significant change - it makes the true changes harder to
spot. Thanks.
Based on our
Ship it.
Thanks,
Serguei
On 1/31/13 11:50 PM, Stefan Karlsson wrote:
On 2013-02-01 00:15, Coleen Phillimore wrote:
Stefan,
I just read through this test and it looks like a good test to me
(but I'm not an expert and it took a while to figure out how it
worked). I had two questions.
On 2013-02-01 09:50, serguei.spit...@oracle.com wrote:
Ship it.
Thanks!
StefanK
Thanks,
Serguei
On 1/31/13 11:50 PM, Stefan Karlsson wrote:
On 2013-02-01 00:15, Coleen Phillimore wrote:
Stefan,
I just read through this test and it looks like a good test to me
(but I'm not an expert
On 2013-02-01 10:22, serguei.spit...@oracle.com wrote:
Nice test!
It looks good.
Thanks for reviewing!
As the original bug and the test are non-trivial, it'd make sense to
add a comment to
the class RedefineMethodInBacktraceApp and explain a little bit what
the test is doing,
and what
Thanks for the review, David.
/R
On Feb 1, 2013, at 7:59 AM, David Holmes wrote:
On 1/02/2013 4:54 PM, Rickard Bäckman wrote:
That was the idea.
However, can I have Ok for checking this into hs24 while waiting?
Sorry - ignore the hs25 comment - been looking at too many JDK review
On 2/1/13 1:57 AM, Stefan Karlsson wrote:
On 2013-02-01 10:22, serguei.spit...@oracle.com wrote:
Nice test!
It looks good.
Thanks for reviewing!
As the original bug and the test are non-trivial, it'd make sense to
add a comment to
the class RedefineMethodInBacktraceApp and explain a little
On 2013-02-01 12:11, serguei.spit...@oracle.com wrote:
On 2/1/13 1:57 AM, Stefan Karlsson wrote:
On 2013-02-01 10:22, serguei.spit...@oracle.com wrote:
Nice test!
It looks good.
Thanks for reviewing!
As the original bug and the test are non-trivial, it'd make sense to
add a comment to
the
On 2013-02-01 12:17, Stefan Karlsson wrote:
On 2013-02-01 12:11, serguei.spit...@oracle.com wrote:
On 2/1/13 1:57 AM, Stefan Karlsson wrote:
On 2013-02-01 10:22, serguei.spit...@oracle.com wrote:
Nice test!
It looks good.
Thanks for reviewing!
As the original bug and the test are
Hi Stefan,
This part of the test:
86 private static void doClassUnloading() {
87 // This will clean out old, unused redefined methods.
88 System.gc();
89 }
seems to make assumptions about System.gc() and class unloading. Are we
relying on knowledge of hotspot
On 2013-02-01 12:48, David Holmes wrote:
Hi Stefan,
This part of the test:
86 private static void doClassUnloading() {
87 // This will clean out old, unused redefined methods.
88 System.gc();
89 }
seems to make assumptions about System.gc() and class unloading.
On 01/02/2013 12:12, Yekaterina Kantserova wrote:
Hi everyone,
Here comes a http://cr.openjdk.java.net/~ykantser/8007142/webrev.01/
with following fixes compared to .00:
* new line is added at the end of the StreamPumper.java
* code is changed to {@code in the StreamPumper.java
*
On 02/01/2013 01:32 PM, Alan Bateman wrote:
On 01/02/2013 12:12, Yekaterina Kantserova wrote:
Hi everyone,
Here comes a http://cr.openjdk.java.net/~ykantser/8007142/webrev.01/
with following fixes compared to .00:
* new line is added at the end of the StreamPumper.java
* code is changed to
On 01/02/2013 13:32, Yekaterina Kantserova wrote:
I've done some testing before I've changed JDKToolFinder. Bellow are 2
cases:
1) *compile.jdk != test.jdk*
./build/linux-amd64/j2sdk-image/bin/java -jar jtreg.jar -compilejdk
/localhome/java/jdk1.7.0_09 test.java
On 02/01/2013 03:20 PM, Alan Bateman wrote:
On 01/02/2013 13:32, Yekaterina Kantserova wrote:
I've done some testing before I've changed JDKToolFinder. Bellow are
2 cases:
1) *compile.jdk != test.jdk*
./build/linux-amd64/j2sdk-image/bin/java -jar jtreg.jar -compilejdk
On 01/02/2013 15:06, Yekaterina Kantserova wrote:
Thanks for explanation! But I'm still confused.
In my use case I need to test /_the tool_/ I'll find with
JDKToolFinder. It will work if just -jdk will be specified. But if
-compilejdk happens to be specified the results of my tests will be
Changeset: 8590c20af3ce
Author:jjg
Date: 2013-02-01 08:33 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8590c20af3ce
8007306: DPrinter: improve display of impl-class, internal tag/kind, and
external tag/kind
Reviewed-by: mcimadamore
!
Changeset: 6df931ce1a81
Author:jjg
Date: 2013-02-01 08:36 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6df931ce1a81
8007305: DPrinter: provide better usage message
Reviewed-by: mcimadamore
! test/tools/javac/lib/DPrinter.java
Staffan,
This looks good. One question is why not set it to _thread_id? is it
because it is 64bit int and on other platforms 32 bits?
os_bsd.cpp:
858 #ifdef __APPLE__
859 osthread-set_thread_id(::mach_thread_self());
860 osthread-set_unique_thread_id(locate_unique_thread_id());
Changeset: 9be6cde7919d
Author:ctornqvi
Date: 2013-01-25 10:14 +0100
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9be6cde7919d
8006413: Add utility classes for writing better multiprocess tests in jtreg
Summary: Add a few utility classes to test/testlibrary to support
Greetings,
I have a fix for the following JVM/TI bug:
7182152 Instrumentation hot swap test incorrect monitor count
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7182152
https://jbs.oracle.com/bugs/browse/JDK-7182152
The fix for the bug in the product code is one line:
Changeset: 0b1c88705568
Author:jjg
Date: 2013-02-01 12:01 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0b1c88705568
8007344: javac may not make tree end positions and/or doc comments available to
processors and listeners
Reviewed-by: darcy
!
Changeset: 55cca2f38ee6
Author:darcy
Date: 2013-02-01 13:01 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/55cca2f38ee6
8001614: Include annotation type to documented supported-ness
Reviewed-by: alanb, jjg, tbell
! make/Makefile-classic
! make/build.properties
+
Changeset: 5e47ee4d7196
Author:alanb
Date: 2013-02-01 21:01 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e47ee4d7196
5035569: Formatter should document that %a conversion unsupported for
BigDecimal args
Reviewed-by: darcy
Contributed-by: brian.burkhal...@oracle.com
!
Changeset: 2132845cf5f7
Author:katleman
Date: 2013-01-16 11:59 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/2132845cf5f7
Added tag jdk8-b73 for changeset 191afde59e7b
! .hgtags
Changeset: d4e68ce17795
Author:katleman
Date: 2013-01-24 16:48 -0800
URL:
Changeset: c37401e77c80
Author:mchung
Date: 2012-12-28 22:20 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/c37401e77c80
8003562: Provide a CLI tool to analyze class dependencies
Reviewed-by: jjg, alanb, ulfzibis, erikj
! common/bin/compare_exceptions.sh.incl
Changeset:
Changeset: cf0917c0d771
Author:katleman
Date: 2013-01-16 11:59 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/cf0917c0d771
Added tag jdk8-b73 for changeset 84946404d1e1
! .hgtags
Changeset: 278a2f60c55b
Author:erikj
Date: 2013-01-04 11:31 +0100
URL:
Changeset: 68f508979ffe
Author:katleman
Date: 2013-01-16 11:59 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/68f508979ffe
Added tag jdk8-b73 for changeset c606f644a5d9
! .hgtags
Changeset: 51f3117e2b75
Author:erikj
Date: 2013-01-04 11:31 +0100
URL:
Changeset: baf7fac3167e
Author:hseigel
Date: 2013-02-01 14:14 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/baf7fac3167e
8006298: Specifying malformed JFR options (-XX:+FlightRecorderOptions) outputs
non-sensical error
Summary: Change error messages for
There are two new tests that will be pushed to the JDK repos using
a different bug ID (not yet filed):
New bug is now filed:
8007420 add test for 6805864 to com/sun/jdi, add test for 7182152
to java/lang/instrument
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007420
And here is the webrev for the new tests (relative to JDK8-TL):
http://cr.openjdk.java.net/~dcubed/8007420-webrev/0-jdk8-tl/
As always, comments and suggestions are welcome.
Dan
On 2/1/13 4:39 PM, Daniel D. Daugherty wrote:
There are two new tests that will be pushed to the JDK repos using
Changeset: cba578db5f39
Author:darcy
Date: 2013-02-01 19:30 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cba578db5f39
6964528: Double.toHexString(double d) String manipulation with + in an append
of StringBuilder
Reviewed-by: shade
!
Changeset: 9bf5f643d1cf
Author:sspitsyn
Date: 2013-01-31 20:07 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9bf5f643d1cf
8006542: JSR 292: the VM_RedefineClasses::append_entry() must support
invokedynamic entry kinds
Summary: Need a support for invokedynamic
33 matches
Mail list logo
