hg: hsx/hotspot-rt/hotspot: 3 new changesets

2013-02-08 Thread zhengyu . gu
Changeset: 41d73c9b30a8 Author:zgu Date: 2013-02-08 16:31 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/41d73c9b30a8 8006691: Remove jvm_version_info.is_kernel_jvm field Summary: Removed is_kernel_jvm from jvm_version_info as Kernel VM has been deprecated Reviewe

Re: RFR: JDK-8007804: Need to be able to access Performance counter by name from JVM

2013-02-08 Thread David Holmes
On 9/02/2013 2:40 AM, Nils Loodin wrote: Please review the following very small and insignificant change: Basically, I need to access a performance-counter by name from within the JVM. The method name by_name seems a little odd to me. find_by_name would seem more consistent (particularly if yo

hg: jdk8/tl/langtools: 8007610: javadoc doclint does not work with -private

2013-02-08 Thread jonathan . gibbons
Changeset: 60caf53b98e2 Author:jjg Date: 2013-02-08 17:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/60caf53b98e2 8007610: javadoc doclint does not work with -private Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! test/com/sun/javadoc/T6

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-02-08 Thread zhengyu . gu
Changeset: 8bf62bd86a4e Author:zgu Date: 2013-02-08 14:49 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8bf62bd86a4e 8007791: More Restricted hs_err file permission Summary: Enforce more restricted hs_file permission Reviewed-by: acorn, dcubed, dsamersoff ! src/s

hg: jdk8/tl/jdk: 8005623: Retrofit FunctionalInterface annotations to core platform interfaces

2013-02-08 Thread joe . darcy
Changeset: 522fb3867a3a Author:darcy Date: 2013-02-08 16:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/522fb3867a3a 8005623: Retrofit FunctionalInterface annotations to core platform interfaces Reviewed-by: mduigou, chegar, alanb ! src/share/classes/java/io/Closeable.jav

hg: hsx/hotspot-rt/hotspot: 31 new changesets

2013-02-08 Thread daniel . daugherty
Changeset: 3c327c2b6782 Author:jmasa Date: 2013-01-03 15:03 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3c327c2b6782 8004895: NPG: JMapPermCore test failure caused by warnings about missing field Reviewed-by: johnc ! src/share/vm/gc_implementation/concurrentMa

Re: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows

2013-02-08 Thread Stuart Marks
On 2/8/13 8:37 AM, Chris Hegarty wrote: Jon Gibbons suggested invoking the compiler API directly from java instead of writing a shell script. Doing this seems fairly simple, and I think it would be advantageous to keep things entirely in Java. I may attempt to rewrite the defaultSVID test using t

hg: jdk8/tl/jdk: 8007038: ArrayIndexOutOfBoundsException on calling localizedDateTime().print() with JapaneseChrono

2013-02-08 Thread naoto . sato
Changeset: 79d7595abe95 Author:naoto Date: 2013-02-08 09:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79d7595abe95 8007038: ArrayIndexOutOfBoundsException on calling localizedDateTime().print() with JapaneseChrono Reviewed-by: okutsu ! src/share/classes/sun/util/locale

RFR: JDK-8007804: Need to be able to access Performance counter by name from JVM

2013-02-08 Thread Nils Loodin
Please review the following very small and insignificant change: Basically, I need to access a performance-counter by name from within the JVM. http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007804 http://cr.openjdk.java.net/~nloodin/8007804/webrev.00/ Regards, Nils Loodin

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-02-08 Thread staffan . larsen
Changeset: 758935f7c23f Author:sla Date: 2013-02-08 12:48 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/758935f7c23f 8006423: SA: NullPointerException in sun.jvm.hotspot.debugger.bsd.BsdThread.getContext(BsdThread.java:67) Summary: Do not rely on mach thread port

Re: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows

2013-02-08 Thread Chris Hegarty
Jon Gibbons suggested invoking the compiler API directly from java instead of writing a shell script. Doing this seems fairly simple, and I think it would be advantageous to keep things entirely in Java. I may attempt to rewrite the defaultSVID test using the compiler API. Here's a test that d

Re: RFR (S): 8004172: Update jstat counter names to reflect metaspace changes

2013-02-08 Thread Mandy Chung
On 2/8/2013 12:08 AM, Erik Helin wrote: New webrev located at: http://cr.openjdk.java.net/~ehelin/8004172/jdk/webrev.05/ Thumbs up. Mandy

hg: hsx/hotspot-rt/hotspot: 8007434: Write tests for 8006298

2013-02-08 Thread christian . tornqvist
Changeset: 3a88007634b0 Author:ctornqvi Date: 2013-02-08 10:42 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3a88007634b0 8007434: Write tests for 8006298 Summary: Four tests written for 8006298 Reviewed-by: mgerdin, coleenp + test/runtime/CommandLine/BooleanFlag

Re: RFR(XXS): 8007085: EnableTracing prints garbage for Compilation: [Java Method

2013-02-08 Thread Staffan Larsen
Looks good! /Staffan On 8 feb 2013, at 13:39, Markus Grönlund wrote: > Greetings, > > Kindly asking for reviews and a putback sponsorship for the following change: > > Bugid: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007085 > Webrev: http://cr.openjdk.java.net/~mgronlun/8007085/we

RFR(XXS): 8007085: EnableTracing prints garbage for Compilation: [Java Method

2013-02-08 Thread Markus Grönlund
Greetings,   Kindly asking for reviews and a putback sponsorship for the following change:   Bugid: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007085 Webrev: http://cr.openjdk.java.net/~mgronlun/8007085/webrev01/   Thank you Markus

Re: RFR: 8006423 SA: NullPointerException in sun.jvm.hotspot.debugger.bsd.BsdThread.getContext(BsdThread.java:67)

2013-02-08 Thread Rickard Bäckman
Staffan, the change looks good to me! Thanks for fixing this problem. /R On Jan 17, 2013, at 8:48 PM, Staffan Larsen wrote: > This is a request for review of a fix for SA on OS X. > > webrev: http://cr.openjdk.java.net/~sla/8006423/webrev.00/ > bug: http://bugs.sun.com/bugdatabase/view_bug.do?

hg: jdk8/tl/langtools: 7167125: Two variables after the same operation in a inner class return different results

2013-02-08 Thread vicente . romero
Changeset: 017e8bdd440f Author:vromero Date: 2013-02-08 09:21 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/017e8bdd440f 7167125: Two variables after the same operation in a inner class return different results Reviewed-by: jjg, mcimadamore ! src/share/classes/com/su

hg: jdk8/tl/langtools: 8005931: javac doesn't set ACC_STRICT for classes with package access

2013-02-08 Thread vicente . romero
Changeset: b1deb90d2e37 Author:vromero Date: 2013-02-08 09:15 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b1deb90d2e37 8005931: javac doesn't set ACC_STRICT for classes with package access Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/parser/Javac

Re: RFR (S): 8004172: Update jstat counter names to reflect metaspace changes

2013-02-08 Thread Erik Helin
On 02/07/2013 07:49 PM, Mandy Chung wrote: On 2/7/2013 4:36 AM, Erik Helin wrote: Hi Mandy, thanks for the review! See comments inline. On 02/05/2013 09:14 PM, Mandy Chung wrote: Looks good. Minor nits: gcCapacityOutput1.awk - should the last column in L7 be removed? I don't think so,