Re: hs25 review request: 8007037 JSR 292: the VM_RedefineClasses::append_entry() should do cross-checks with indy operands

2013-04-02 Thread serguei.spit...@oracle.com
Hi Coleen, Again, thank you a lot for reviewing this code! This is a good catch too, thank you for pointing to it. BTW, I was thinking that this probably must be explicitly deallocated but at some point lost my focus. :) Thanks! Serguei On 4/2/13 3:45 PM, Coleen Phillimore wrote: Hi Serguei

hg: jdk8/tl/jdk: 8004979: java.lang.reflect.Modifier.toString should include "default"

2013-04-02 Thread joe . darcy
Changeset: b4f68aca1000 Author:darcy Date: 2013-04-02 16:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b4f68aca1000 8004979: java.lang.reflect.Modifier.toString should include "default" Reviewed-by: mduigou ! src/share/classes/java/lang/reflect/Constructor.java ! src/sha

Re: hs25 review request: 8007037 JSR 292: the VM_RedefineClasses::append_entry() should do cross-checks with indy operands

2013-04-02 Thread Coleen Phillimore
Hi Serguei, This looks good from how much I understand of these two things. There is one problem that I found though. In ConstantPool::extend_operands() and shrink_operands() when you allocate a new Array* and assign it to the from_cp, you have to explicitly deallocate the operands that were

hg: jdk8/tl: 8011342: hgforest.sh : 'python --version' not supported on older python

2013-04-02 Thread mike . duigou
Changeset: 7320922b694e Author:mduigou Date: 2013-04-02 14:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/7320922b694e 8011342: hgforest.sh : 'python --version' not supported on older python Reviewed-by: wetmore ! common/bin/hgforest.sh

Re: hs25 review request: 8008511 JSR 292: MemberName vmtarget refs to methods must be updated at class redefinition

2013-04-02 Thread serguei.spit...@oracle.com
On 4/2/13 2:09 PM, Coleen Phillimore wrote: On 04/02/2013 01:02 PM, serguei.spit...@oracle.com wrote: On 4/1/13 3:51 PM, Coleen Phillimore wrote: On 04/01/2013 06:02 PM, serguei.spit...@oracle.com wrote: On 4/1/13 1:09 PM, Coleen Phillimore wrote: Hi Serguei, Sorry for the delay in review

Re: hs25 review request: 8008511 JSR 292: MemberName vmtarget refs to methods must be updated at class redefinition

2013-04-02 Thread Coleen Phillimore
On 04/02/2013 01:02 PM, serguei.spit...@oracle.com wrote: On 4/1/13 3:51 PM, Coleen Phillimore wrote: On 04/01/2013 06:02 PM, serguei.spit...@oracle.com wrote: On 4/1/13 1:09 PM, Coleen Phillimore wrote: Hi Serguei, Sorry for the delay in reviewing this. In instanceKlass.cpp line 2730, ca

hg: jdk8/tl/jaxws: 4 new changesets

2013-04-02 Thread lana . steuck
Changeset: a1dcc0d83da1 Author:katleman Date: 2013-03-21 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/a1dcc0d83da1 Added tag jdk8-b82 for changeset d8d8032d02d7 ! .hgtags Changeset: 54c29eb352e7 Author:katleman Date: 2013-03-28 10:54 -0700 URL: http

hg: jdk8/tl/jdk: 18 new changesets

2013-04-02 Thread lana . steuck
Changeset: 624bcb480006 Author:omajid Date: 2013-03-18 10:46 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/624bcb480006 8010030: Allow configure to detect if EC implementation is present Reviewed-by: andrew, dholmes ! makefiles/CompileNativeLibraries.gmk Changeset: cdcd451

hg: jdk8/tl/hotspot: 53 new changesets

2013-04-02 Thread lana . steuck
Changeset: 4f7380dca47e Author:katleman Date: 2013-03-21 10:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4f7380dca47e Added tag jdk8-b82 for changeset 3db4ab0e12f4 ! .hgtags Changeset: 7ae04e71af90 Author:amurillo Date: 2013-03-15 11:44 -0700 URL: ht

hg: jdk8/tl/langtools: 5 new changesets

2013-04-02 Thread lana . steuck
Changeset: 22ba3f92d4ae Author:katleman Date: 2013-03-21 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/22ba3f92d4ae Added tag jdk8-b82 for changeset 825da6847791 ! .hgtags Changeset: 35cef52b0023 Author:katleman Date: 2013-03-28 10:55 -0700 URL:

hg: jdk8/tl/corba: 4 new changesets

2013-04-02 Thread lana . steuck
Changeset: a45bb25a67c7 Author:katleman Date: 2013-03-21 10:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a45bb25a67c7 Added tag jdk8-b82 for changeset 48e1bc77004d ! .hgtags Changeset: 14f1babaf548 Author:katleman Date: 2013-03-28 10:53 -0700 URL: http

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-04-02 Thread zhengyu . gu
Changeset: 8c03fc47511d Author:iklam Date: 2013-04-01 14:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8c03fc47511d 8011048: Possible reading from unmapped memory in UTF8::as_quoted_ascii() Summary: Pass utf_length parameter to UTF8::as_quoted_ascii() Reviewed-

hg: jdk8/tl/jdk: 8007379: Base64.getMimeDecoder().decode() throws IAE for a non-base64 character after padding; ...

2013-04-02 Thread xueming . shen
Changeset: e6c3b8e74e50 Author:sherman Date: 2013-04-02 10:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6c3b8e74e50 8007379: Base64.getMimeDecoder().decode() throws IAE for a non-base64 character after padding 8008925: Base64.getMimeDecoder().decode() does not ignore p

Re: hs25 review request: 8008511 JSR 292: MemberName vmtarget refs to methods must be updated at class redefinition

2013-04-02 Thread serguei.spit...@oracle.com
On 4/1/13 3:51 PM, Coleen Phillimore wrote: On 04/01/2013 06:02 PM, serguei.spit...@oracle.com wrote: On 4/1/13 1:09 PM, Coleen Phillimore wrote: Hi Serguei, Sorry for the delay in reviewing this. In instanceKlass.cpp line 2730, can you make that mtClass since it's part of class metadata?

hg: hsx/hotspot-rt/hotspot: 8009763: Add WB test for String.intern()

2013-04-02 Thread mikael . gerdin
Changeset: ede380e13960 Author:mgerdin Date: 2013-04-02 11:28 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ede380e13960 8009763: Add WB test for String.intern() Summary: Add convenience method in StringTable, add WhiteBox method and simple sanity test Reviewed-b

hg: jdk8/tl/nashorn: 2 new changesets

2013-04-02 Thread sundararajan . athijegannathan
Changeset: 3e4369fb810b Author:hannesw Date: 2013-04-02 13:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3e4369fb810b 8011219: Regression with recent PropertyMap history changes Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/runtime/PropertyMap.java Chan

Re: RFR(XXS): 8007150 Event based tracing is missing truncated field in stack trace content type

2013-04-02 Thread Stefan Karlsson
Looks good. StefanK On 03/25/2013 09:13 PM, Erik Gahlin wrote: Hi, Could you please review this small change to the metadata for StackTrace content type, used by the event tracing framework. A boolean flag has been added so it's possible to see if a stack trace has been truncated (not all f

Re: RFR(XXS): 8008391: Incorrect metadata for event based tracing

2013-04-02 Thread Stefan Karlsson
Seems reasonable. StefanK On 03/25/2013 10:17 PM, Erik Gahlin wrote: Hi, Could you please review these small metadata changes for the event tracing framework: - Promotion Failed -> objectCount has the datatype BYTES64, which implies that it is a size. It is not, and the type should be an

hg: hsx/hotspot-rt/hotspot: 8002118: WindbgDebuggerLocal should not try to load 64-bit debug libraries for 32-bit JVM

2013-04-02 Thread staffan . larsen
Changeset: e458120c6e1a Author:sla Date: 2013-03-28 15:39 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e458120c6e1a 8002118: WindbgDebuggerLocal should not try to load 64-bit debug libraries for 32-bit JVM Reviewed-by: sspitsyn, zgu Contributed-by: peter.all...@

hg: jdk8/tl/jdk: 8009558: linked_md.c::dll_build_name can get stuck in an infinite loop

2013-04-02 Thread staffan . larsen
Changeset: f1b89d4cce82 Author:sla Date: 2013-04-02 10:32 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f1b89d4cce82 8009558: linked_md.c::dll_build_name can get stuck in an infinite loop Reviewed-by: alanb, sspitsyn ! src/share/back/export/sys.h ! src/share/back/transport.