Re: RFR(XXS): 8016735: Remove superfluous EnableInvokeDynamic warning from UnlockDiagnosticVMOptions check

+1 David On 17/06/2013 8:10 PM, Staffan Larsen wrote: Looks good. Thanks, /Staffan On 17 jun 2013, at 11:55, Markus Grönlund mailto:markus.gronl...@oracle.com>> wrote: Greetings, Kindly asking from reviews for this very simple change to remove a stale warning about EnableInvokeDynamic. Bugi

hg: jdk8/tl/jdk: 8015402: Lambda metafactory should not attempt to determine bridge methods

Changeset: 989049977d04 Author:rfield Date: 2013-06-17 20:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/989049977d04 8015402: Lambda metafactory should not attempt to determine bridge methods Summary: paired with 8013789: Compiler should emit bridges in interfaces Reviewe

hg: jdk8/tl/langtools: 8013789: Compiler should emit bridges in interfaces

Changeset: 455be95bd1b5 Author:rfield Date: 2013-06-17 20:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/455be95bd1b5 8013789: Compiler should emit bridges in interfaces Summary: paired with 8015402: Lambda metafactory should not attempt to determine bridge methods

hg: jdk8/tl/jdk: 8014620: Signature.getAlgorithm return null in special case

Changeset: 116050227ee9 Author:youdwei Date: 2013-06-17 17:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/116050227ee9 8014620: Signature.getAlgorithm return null in special case Reviewed-by: wetmore ! src/share/classes/java/security/Signature.java + test/java/security/Si

hg: jdk8/tl/jdk: 7177472: JSR292: MethodType interning penalizes scalability

Changeset: 2b63fda275a3 Author:twisti Date: 2013-06-17 16:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2b63fda275a3 7177472: JSR292: MethodType interning penalizes scalability Reviewed-by: twisti Contributed-by: Aleksey Shipilev ! src/share/classes/java/lang/invoke/Met

Re: Review Request (S) 6493116: JVMTI Doc: GetOwnedMonitorStackDepthInfo has a typo in monitor_info_ptr parameter description

Looks good. Thanks Yumin On 6/14/2013 11:27 AM, serguei.spit...@oracle.com wrote: On 6/13/13 12:44 PM, serguei.spit...@oracle.com wrote: Please, review a 1-line JVMTI doc fix for: bug: http://bugs.sun.com/view_bug.do?bug_id=6493116 jbs: https://jbs.oracle.com/bugs/browse/JDK-6493116 Ope

hg: jdk8/tl/langtools: 8016779: Fix doclint warnings in javax.lang.model

Changeset: b7a10bc02e7a Author:darcy Date: 2013-06-17 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b7a10bc02e7a 8016779: Fix doclint warnings in javax.lang.model Reviewed-by: jjg ! src/share/classes/javax/lang/model/util/ElementScanner6.java ! src/share/classes

Re: Code Review Request: 8016576: Overrides warnings in jdi and jconsole

On 06/17/2013 08:08 PM, Kurchi Hazra wrote: - Maybe a webrev helps: http://cr.openjdk.java.net/~khazra/8016576/webrev.01/ Looks fine, but trivially remove the unnecessary null check in equals before pushing. If 'o instanceof XObject',

hg: hsx/hotspot-rt/hotspot: 8016304: ThreadMXBean.getDeadlockedThreads reports bogus deadlocks on JDK 8

Changeset: ef748153ee8f Author:sla Date: 2013-06-17 18:35 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ef748153ee8f 8016304: ThreadMXBean.getDeadlockedThreads reports bogus deadlocks on JDK 8 Reviewed-by: dcubed, mgronlun ! src/share/vm/services/threadService.cp

hg: jdk8/tl/jaxp: 8016133: Regression: diff. behavior with user-defined SAXParser

Changeset: 09d55894844d Author:joehw Date: 2013-06-17 12:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/09d55894844d 8016133: Regression: diff. behavior with user-defined SAXParser Reviewed-by: chegar, dfuchs ! src/org/xml/sax/helpers/XMLReaderFactory.java

Re: Code Review Request: 8016576: Overrides warnings in jdi and jconsole

On 17/06/2013 19:19, Kurchi Hazra wrote: - Maybe a webrev helps: http://cr.openjdk.java.net/~khazra/8016576/webrev.01/ I agree with Chris's comment that the null check is not required. Otherwise looks fine to me. -Alan

Re: Code Review Request: 8016576: Overrides warnings in jdi and jconsole

- Maybe a webrev helps: http://cr.openjdk.java.net/~khazra/8016576/webrev.01/ Looks fine, but trivially remove the unnecessary null check in equals before pushing. If 'o instanceof XObject', then it cannot be null. Similar for SDE.equ

Re: Code Review Request: 8016576: Overrides warnings in jdi and jconsole

On 06/17/2013 07:19 PM, Kurchi Hazra wrote: Thank you for attacking the hashCode/equals warnings, they've been screaming to get fixed for a long time. It's hard to judge SDE.hashCode but it looks like the straum and line table index values are used twice (by way of computing the line number).

Re: Code Review Request: 8016576: Overrides warnings in jdi and jconsole

Thank you for attacking the hashCode/equals warnings, they've been screaming to get fixed for a long time. It's hard to judge SDE.hashCode but it looks like the straum and line table index values are used twice (by way of computing the line number). I agree with the multiplication to spread

Re: Code Review Request: 8016576: Overrides warnings in jdi and jconsole

On 6/15/2013 12:25 AM, Alan Bateman wrote: On 14/06/2013 22:58, Kurchi Hazra wrote: Apologies, corrected the subject line here. On 6/14/2013 2:51 PM, Kurchi Hazra wrote: Hi, Please review this patch to implement hashCode() in two classes in the serviceability area to eliminate the overrid

hg: jdk8/tl: 8016572: Pass CONCURRENCY=$(JOBS) to test/Makefile

Changeset: f8770fe60d53 Author:mduigou Date: 2013-06-17 09:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/f8770fe60d53 8016572: Pass CONCURRENCY=$(JOBS) to test/Makefile Reviewed-by: alanb, erikj ! common/makefiles/Main.gmk

Re: RFR: 8016304: ThreadMXBean.getDeadlockedThreads reports bogus deadlocks on JDK 8

Thanks Dan. I'll add the comment before pushing. /Staffan On 17 jun 2013, at 17:49, Daniel D. Daugherty wrote: > > webrev: http://cr.openjdk.java.net/~sla/8016304/webrev.00/ > > Thumbs up. > > src/share/vm/services/threadService.cpp >Can you add the following comment: > >// The sett

RE: RFR: 8016304: ThreadMXBean.getDeadlockedThreads reports bogus deadlocks on JDK 8

Looks good. /Markus -Original Message- From: Staffan Larsen Sent: den 17 juni 2013 17:23 To: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net Subject: RFR: 8016304: ThreadMXBean.getDeadlockedThreads reports bogus deadlocks on

Re: RFR: 8016304: ThreadMXBean.getDeadlockedThreads reports bogus deadlocks on JDK 8

> webrev: http://cr.openjdk.java.net/~sla/8016304/webrev.00/ Thumbs up. src/share/vm/services/threadService.cpp Can you add the following comment: // The setting of the current_pending_monitor field is speculative // and racy so we need to check to see if the object is actually owne

RFR: 8016304: ThreadMXBean.getDeadlockedThreads reports bogus deadlocks on JDK 8

Please review this fix. There is a long description in the bug report of the problem and the solution which I will not copy here. I have made the reproducer from the bug into a test which is also included. webrev: http://cr.openjdk.java.net/~sla/8016304/webrev.00/ bug: http://bugs.sun.com/bugdat

hg: jdk8/tl/jdk: 8016236: Class.getGenericInterfaces performance improvement

Changeset: b0cfde1e70e9 Author:shade Date: 2013-06-17 16:28 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b0cfde1e70e9 8016236: Class.getGenericInterfaces performance improvement Summary: cache more reflective data and lookup results. Reviewed-by: alanb, plevart, psandoz, dl

hg: jdk8/tl/jdk: 8016747: Replace deprecated PlatformLogger isLoggable(int) with isLoggable(Level)

Changeset: adf70cb48ce0 Author:chegar Date: 2013-06-17 14:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/adf70cb48ce0 8016747: Replace deprecated PlatformLogger isLoggable(int) with isLoggable(Level) Reviewed-by: darcy ! src/macosx/classes/sun/lwawt/LWComponentPeer.java

Re: Codereview for JDK-8016221: A unit test should not use a fixed port to run a jmx connector (JDCMD MBean Tests)

Hi Shanliang, the change looks fine. The only small thing I have is whether it is good to wrap cc.close(); cs.stop(); in try/catch and swallow the exception. Wouldn't it be better to let the test fail if something goes wrong with closing JMXConnector and JXMConnectorServer? -JB- On 06/12/2013 0

Re: RFR(XXS): 8016735: Remove superfluous EnableInvokeDynamic warning from UnlockDiagnosticVMOptions check

Looks good. Thanks, /Staffan On 17 jun 2013, at 11:55, Markus Grönlund wrote: > Greetings, > > Kindly asking from reviews for this very simple change to remove a stale > warning about EnableInvokeDynamic. > > Bugid: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016735 > > Webrev: h

RFR(XXS): 8016735: Remove superfluous EnableInvokeDynamic warning from UnlockDiagnosticVMOptions check

Greetings,   Kindly asking from reviews for this very simple change to remove a stale warning about EnableInvokeDynamic.   Bugid: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016735   Webrev: http://cr.openjdk.java.net/~mgronlun/8016735/webrev01/   Thanks Markus  

Re: Code Review Request: 7169142: CookieHandler does not work with localhost

Looks good. /Staffan On 14 jun 2013, at 23:51, Kurchi Hazra wrote: > > > Hi, > > Please review this patch to implement hashCode() in two classes in the > serviceability area to eliminate the overrides warning. > > Bug: http://bugs.sun.com/view_bug.do?bug_id=8016576 > Webrev: http://cr.open

Re: RFR JDK-8016592: Clean-up Javac Overrides Warnings In javax/management/NotificationBroadcasterSupport.java

Hi Dan, 1. To be on the safe side I'd suggest to use: return Objects.hashCode(listener); rather than plain return listener.hashCode(). (I see that removeNotificationListener(...) does not check for null). 2. I wouldn't have changed WildcardListenerInfo.equals(); If you insist in changing i

Re: RFR JDK-8016592: Clean-up Javac Overrides Warnings In javax/management/NotificationBroadcasterSupport.java

305 return listener.hashCode(); Could get a NullPointerException because the listener could be null, the method removeNotificationListener does not refuse a null listener. I think this must be a new bug, the method removeNotificationListener should throw an exception in case of a n

hg: jdk8/tl/jdk: 36 new changesets

Changeset: 583e6dec1ed7 Author:erikj Date: 2013-05-29 14:01 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/583e6dec1ed7 8013489: New build system does not run codesign on SA-related launchers on OS X Reviewed-by: sla, tbell ! makefiles/CompileLaunchers.gmk Changeset: d8c97d