Looks good.
/Staffan
On 6 aug 2013, at 21:47, Erik Gahlin erik.gah...@oracle.com wrote:
Without this change a 'gmake clean' in the jdk/make/sun/jconsole directory
does not properly clean up the build results.
Bug:
http://monaco.us.oracle.com/detail.jsf?cr=6721425
Webrev:
Looks good.
/Staffan
On 6 aug 2013, at 20:53, Erik Gahlin erik.gah...@oracle.com wrote:
Please review this change.
ThreadMXBean#setThreadCpuTimeEnabled(true) assumes read-write access to the
underlying JVM, but if read-access is only available plug-in will fail and
throw an exception.
Updated webrev with == replaced with !=
Erik
Erik Gahlin skrev 2013-07-30 22:04:
Nice catch, thanks Shanliang.
Erik
Shanliang skrev 2013-07-30 09:14:
Hi Erik,
src/share/classes/sun/tools/jconsole/VMPanel.java
156 if (insets == null) {
157 insets = (Insets)
and the webrev ;)
http://cr.openjdk.java.net/~egahlin/6800801_2
Erik
Erik Gahlin skrev 2013-08-12 13:25:
Updated webrev with == replaced with !=
Erik
Erik Gahlin skrev 2013-07-30 22:04:
Nice catch, thanks Shanliang.
Erik
Shanliang skrev 2013-07-30 09:14:
Hi Erik,
Hello!
This patch addresses several Nashorn compatibility issues with in sa.js and is
a merge of my patch [0] and Kris' (kmo) [1] which were developed separately.
The merged change is identical to [1] with except for line 785 where I've added
a conversion to JavaScript String to ensure the
On 30/07/2013 13:47, Erik Gahlin wrote:
Thanks Jaroslav, will fix.
If a reviewer could also have a look, it would be great.
Thanks
Erik
The change looks okay to me too.
-Alan.
On 29/07/2013 23:07, Jaroslav Bachorik wrote:
The change looks good.
I can be the sponsor.
-JB-
This one looks good to me too.
-Alan.
On 12/08/2013 12:27, Erik Gahlin wrote:
and the webrev ;)
http://cr.openjdk.java.net/~egahlin/6800801_2
Erik
Updated webrev looks fine to me.
-Alan.
On 29/07/2013 21:13, Erik Gahlin wrote:
Please review a small change.
Description:
Strings should be changed to navigating tabular data structure or
tabular data navigation
Solution:
Inserted Data into the titles Composite Navigation and Tabular
Navigation.
Bug:
On 06/08/2013 19:53, Erik Gahlin wrote:
Please review this change.
ThreadMXBean#setThreadCpuTimeEnabled(true) assumes read-write access
to the underlying JVM, but if read-access is only available plug-in
will fail and throw an exception.
http://monaco.us.oracle.com/detail.jsf?cr=6696975
On 06/08/2013 20:47, Erik Gahlin wrote:
Without this change a 'gmake clean' in the jdk/make/sun/jconsole
directory does not properly clean up the build results.
Bug:
http://monaco.us.oracle.com/detail.jsf?cr=6721425
Webrev:
http://cr.openjdk.java.net/~egahlin/6721425/
Thanks
Erik
The change
On 29/07/2013 21:25, Erik Gahlin wrote:
Please review a small change.
Description:
If several threads are selected in the Threads list in the Threads
tab, some thread info is still shown in the thread info panel.
Solution:
Only allow one thread to be selected at a time, so thread info
On 29/07/2013 21:16, Erik Gahlin wrote:
Please review a small change.
Description:
Memory graph in Memory tab is not redrawn until the next redraw interval.
Bug:
http://monaco.us.oracle.com/detail.jsf?cr=6417702
Webrev:
http://cr.openjdk.java.net/~egahlin/6417702/
Looks fine to me too.
Changeset: ffacf3e7a130
Author:mullan
Date: 2013-08-12 09:03 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ffacf3e7a130
8016848: javax_security/auth/login tests fail in compact 1 and 2 profiles
Summary: Change the default value of the login.configuration.provider
security
Sorry forgot to include svc.
Yumin
On 8/11/2013 4:36 PM, Yumin Qi wrote:
Hi, all
I would like to have your review for
http://cr.openjdk.java.net/~minqi/8020962/webrev0/
http://cr.openjdk.java.net/%7Eminqi/8020962/webrev0/
Description: When JVM crashed, we also want to check the
Changeset: 14ea21d58f83
Author:jlaskey
Date: 2013-08-08 11:20 -0300
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/14ea21d58f83
Merge
- src/jdk/internal/dynalink/support/Backport.java
Changeset: 47e2b609fe31
Author:sundar
Date: 2013-08-09 20:48 +0530
URL:
Looks good
-Sundar
On Monday 12 August 2013 06:21 PM, Peter Allwin wrote:
Hello!
This patch addresses several Nashorn compatibility issues with in
sa.js and is a merge of my patch [0] and Kris' (kmo) [1] which were
developed separately.
The merged change is identical to [1] with except
Hi Peter,
Looks good to me. Thank you!
I'd like to mention again that the getHandle - getAddress change has been
purposed by Yunda, which I mentioned in [1], too.
Best regards,
Kris (kmo)
On Monday, August 12, 2013, A. Sundararajan wrote:
Looks good
-Sundar
On Monday 12 August 2013 06:21
Changeset: f7f271bd74a2
Author:mcimadamore
Date: 2013-08-12 17:25 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f7f271bd74a2
6537020: JCK tests: a compile-time error should be given in case of ambiguously
imported fields (types, methods)
Summary: Hiding check does
Changeset: 70c8f4a4b8d6
Author:vromero
Date: 2013-08-12 17:40 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70c8f4a4b8d6
8015780: java/lang/reflect/Method/GenericStringTest.java failing
Reviewed-by: darcy, jfranck
! test/ProblemList.txt
!
This one looks good to me.
Shanliang
Erik Gahlin wrote:
and the webrev ;)
http://cr.openjdk.java.net/~egahlin/6800801_2
Erik
Erik Gahlin skrev 2013-08-12 13:25:
Updated webrev with == replaced with !=
Erik
Erik Gahlin skrev 2013-07-30 22:04:
Nice catch, thanks Shanliang.
Erik
On 08/12/2013 10:00 AM, Yumin Qi wrote:
- What if it the SA also crashes, will it launch a third VM then a
fourth etc?
Definitely don't want to see this happened in a chain. The solution
may use a property such as
sun.jvm.hotspot.DumpLoadedClasses.dumpingInProcess=true to pass into
SA
Ioi,
Thanks for the reminding, it is possible. I will use env instead.
Yumin
On 8/12/2013 11:00 AM, Ioi Lam wrote:
On 08/12/2013 10:00 AM, Yumin Qi wrote:
- What if it the SA also crashes, will it launch a third VM then a
fourth etc?
Definitely don't want to see this happened in a
Should L358, 359, 388 need to be guarded to validate the result value?
Mandy
On 7/29/2013 1:02 PM, Erik Grahlin wrote:
Please review a small change:
Description:
Switch to the Threads tab and try shrinking the window. When the window
width becomes smaller than some particular size, an
Changeset: 7758bcf0ab6b
Author:henryjen
Date: 2013-08-12 12:11 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7758bcf0ab6b
8022749: Convert junit tests to testng in test/java/lang/invoke
Reviewed-by: mduigou, alanb
Contributed-by: Mani Sarkar sadhak...@gmail.com
!
Changeset: cc64a05836a7
Author:lancea
Date: 2013-08-12 16:09 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc64a05836a7
8022753: SQLXML javadoc example typo
Reviewed-by: alanb, mchung
! src/share/classes/java/sql/SQLXML.java
On 8/6/13 3:33 PM, Coleen Phillimore wrote:
Summary: ActiveMethodOopsCache was used to keep track of old versions
of some methods that are cached in Universe but is buggy with permgen
removal and not needed anymore
There was a crash in this function that I couldn't reproduce. It was
likely
Thanks Dan for reviewing this version of this change also. See inline
comments.
On 08/12/2013 05:14 PM, Daniel D. Daugherty wrote:
On 8/6/13 3:33 PM, Coleen Phillimore wrote:
Summary: ActiveMethodOopsCache was used to keep track of old versions
of some methods that are cached in Universe
Yumin,
I don't think this change should be added to the JVM for the following
reasons.
1. Error handling should only contain safe actions. We have concerns
that the SA is not that stable and would prevent getting a real core
file in many error situations. You couldn't have tested all
This fix will be delicate and may have regressions if the exact code shape (of
the PopFrame-ed invokestatic call) changes.
Note that member_name_arg_or_null assumes that the value in Local#0 is a DMH;
there will be asserts thrown if this fails. It also assumes that the member
name held by the
I agree with Coleen, this change should not be added to the JVM.
Though I'd like to have the tool to create this archive from a core/mdmp. If
this is not already present in any of the j*-tools we might want to look into
adding it, please work with the serviceability team to determine where
On 8/6/2013 10:59 AM, Erik Gahlin wrote:
Please review this change.
An exception from JConsole plug-in should not affect other tabs.
http://monaco.us.oracle.com/detail.jsf?cr=6696970
Added a plug-in proxy that handles RE. If debug mode is enabled
exceptions are written to System.err. Tested
32 matches
Mail list logo
