Re: Request for review:8023477: Invalid CP index when reading ConstantPool

Looks good. Thanks, /Staffan On 23 aug 2013, at 23:49, Jiangli Zhou jiangli.z...@oracle.com wrote: Hi, Please review the fix for 8023477: http://cr.openjdk.java.net/~jiangli/8023477/webrev.00/ Both tests reported by the bug failed due to the same problem. They both are passing now.

Re: Codereview requested: 6566891 RMIConnector: map value referencing map key in WeakHashMap prevents map entry to be removed

Hi, Still need OK from a reviewer. Thanks Erik, Jaroslav and Daniel for the code review. Thanks, Shanliang Daniel Fuchs wrote: On 8/21/13 10:27 AM, shanliang wrote: Jaroslav Bachorik wrote: On 08/21/2013 12:00 AM, Daniel Fuchs wrote: On 8/20/13 11:12 PM, shanliang wrote: Thanks Daniel

hg: jdk8/tl/jdk: 8023139: java/nio/file/WatchService/SensitivityModifier.java failing intermittently (win8)

Changeset: 0ee3b995d63b Author:alanb Date: 2013-08-26 10:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0ee3b995d63b 8023139: java/nio/file/WatchService/SensitivityModifier.java failing intermittently (win8) Reviewed-by: alanb Contributed-by: yiming.w...@oracle.com !

Re: AsyncGetCallTrace java profiling

Hi, I was able to reproduce the bug running java 8 (build b103, and so hotspot build 25.0-b45). So I would like to update the bug report to java 8. I don't have access to it though. Should I post a new one? On Tue, Aug 13, 2013 at 2:13 PM, Alexandre De Champeaux a...@quartetfs.comwrote: Ok

hg: jdk8/tl/jdk: 7129312: BufferedInputStream calculates negative array size with large streams and mark

Changeset: 67a1a031876a Author:igerasim Date: 2013-08-25 23:20 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/67a1a031876a 7129312: BufferedInputStream calculates negative array size with large streams and mark Reviewed-by: alanb !

Re: RFR(S): JDK-6622468 : TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure

Staffan, javaoptions will only be passed to the java invocation of the VM under test. vmptions will be passed to all VM invocations including javac from the compile-jdk. If your test-jdk and compile-jdk are the same then you will have trouble telling them apart :) That aside I would have

Re: RFR(S): JDK-6622468 : TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure

On 26 aug 2013, at 13:03, David Holmes david.hol...@oracle.com wrote: Staffan, javaoptions will only be passed to the java invocation of the VM under test. vmptions will be passed to all VM invocations including javac from the compile-jdk. Thanks, that was what I thought. So if my VM

Re: AsyncGetCallTrace java profiling

I think this is your bug report: http://bugs.sun.com/view_bug.do?bug_id=8022893 I have updated Affected Versions to include 8 as well. The change will take a day or so to propagate. /Staffan On 26 aug 2013, at 12:08, Alexandre De Champeaux a...@quartetfs.com wrote: Hi, I was able to

hg: jdk8/tl/jdk: 8022343: j.l.Class.getAnnotatedSuperclass() doesn't return null in some cases

Changeset: 6917c114b197 Author:jfranck Date: 2013-08-26 13:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6917c114b197 8022343: j.l.Class.getAnnotatedSuperclass() doesn't return null in some cases Reviewed-by: darcy, vromero, psandoz !

Re: RFR(S): JDK-6622468 : TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure

On 26/08/2013 9:27 PM, Staffan Larsen wrote: On 26 aug 2013, at 13:03, David Holmes david.hol...@oracle.com wrote: Staffan, javaoptions will only be passed to the java invocation of the VM under test. vmptions will be passed to all VM invocations including javac from the compile-jdk.

Re: RFR(S): JDK-6622468 : TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure

On 26 aug 2013, at 14:08, David Holmes david.hol...@oracle.com wrote: On 26/08/2013 9:27 PM, Staffan Larsen wrote: On 26 aug 2013, at 13:03, David Holmes david.hol...@oracle.com wrote: Staffan, javaoptions will only be passed to the java invocation of the VM under test. vmptions

Re: RFR(S): JDK-6622468 : TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure

On 8/26/13 5:27 AM, Staffan Larsen wrote: On 26 aug 2013, at 13:03, David Holmes david.hol...@oracle.com wrote: If your test-jdk and compile-jdk are the same then you will have trouble telling them apart :) That aside I would have thought it quite reasonable for the debugger and debuggee

hg: hsx/hotspot-rt/hotspot: 8022683: JNI GetStringUTFChars should return NULL on allocation failure not abort the VM

Changeset: faf2631b9334 Author:dsimms Date: 2013-08-26 09:33 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/faf2631b9334 8022683: JNI GetStringUTFChars should return NULL on allocation failure not abort the VM Summary: Return NULL on OOM from GetStringChars,

Re: RFR(S): JDK-6622468 : TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure

So if we really want to be able to use different options for the debugger and the debuggee, then a solution would be a separate property that contains the options to send to the debuggee (as proposed in the original bug report). Something like: jtreg

hg: jdk8/tl/jdk: 8023234: StampedLock serializes readers on writer unlock

Changeset: 8a36fc7f494c Author:shade Date: 2013-08-26 17:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a36fc7f494c 8023234: StampedLock serializes readers on writer unlock Summary: Sync-up the fix from jsr166 CVS, signal more readers on writer unlock Reviewed-by:

hg: jdk8/tl/jdk: 8011944: Sort fails with ArrayIndexOutOfBoundsException

Changeset: 07585a2483fa Author:rriggs Date: 2013-08-26 11:46 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/07585a2483fa 8011944: Sort fails with ArrayIndexOutOfBoundsException Summary: Increase the size of pending stack and add test cases Reviewed-by: alanb !

Re: Request for review:8023477: Invalid CP index when reading ConstantPool

Thanks, Staffan! Jiangli On 08/26/2013 01:13 AM, Staffan Larsen wrote: Looks good. Thanks, /Staffan On 23 aug 2013, at 23:49, Jiangli Zhou jiangli.z...@oracle.com wrote: Hi, Please review the fix for 8023477: http://cr.openjdk.java.net/~jiangli/8023477/webrev.00/ Both tests reported

Re: RFR: 7164841: Improvements to the GC log file rotation

Bengt, Thanks for your comments. Yes, as you said, the purpose of rotating logs is primarily targeted for saving disk space. This bug is supplying customers another option to prevent the previous gc logs from removed by restart app without making copy. Now with this pid and time stamp

Re: AsyncGetCallTrace java profiling

Alexandre, Thank you for the information and details. I've added your it to the JBS version of 8022893. Thanks, Serguei On 8/26/13 4:30 AM, Staffan Larsen wrote: I think this is your bug report: http://bugs.sun.com/view_bug.do?bug_id=8022893 I have updated Affected Versions to include 8 as

hg: jdk8/tl/jdk: 8016018: Typo in AbstractStringBuilder#indexOf and #lastIndexOf descriptions

Changeset: 92a66af7f834 Author:igerasim Date: 2013-08-26 18:26 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92a66af7f834 8016018: Typo in AbstractStringBuilder#indexOf and #lastIndexOf descriptions Reviewed-by: alanb, chegar !

Re: jstack can't attach to JVM (OS X)

Great! Thanks for the explanation. Just curious, why does running jstack at least once before the code reaches that method call prevent the problem from happening at all? Martin On Mon, Aug 26, 2013 at 5:31 AM, Staffan Larsen staffan.lar...@oracle.comwrote: Here is what's happening: - The

hg: jdk8/tl: 8023491: Remove target names from test/Makefile and defer to sub-repo makefiles.

Changeset: f643fee2b40f Author:mduigou Date: 2013-08-26 10:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/f643fee2b40f 8023491: Remove target names from test/Makefile and defer to sub-repo makefiles. Reviewed-by: erikj ! common/makefiles/Main.gmk ! test/Makefile

hg: jdk8/tl/langtools: 8023701: Fix badly named test

Changeset: 60f156c653d3 Author:jjg Date: 2013-08-26 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/60f156c653d3 8023701: Fix badly named test Reviewed-by: bpatel - test/com/sun/javadoc/testNavagation/TestNavagation.java -

hg: jdk8/tl/jdk: 8020292: j.u.SplittableRandom

Changeset: 5ce9025c9e1a Author:psandoz Date: 2013-08-26 22:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ce9025c9e1a 8020292: j.u.SplittableRandom Reviewed-by: mduigou Contributed-by: Guy Steele guy.ste...@oracle.com, Doug Lea d...@cs.oswego.edu, Brian Goetz

hg: jdk8/tl/jdk: 8023681: Fix raw type warning caused by Sink

Changeset: 35c1609d9488 Author:henryjen Date: 2013-08-09 09:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/35c1609d9488 8023681: Fix raw type warning caused by Sink Reviewed-by: mduigou, briangoetz ! src/share/classes/java/util/stream/Collectors.java !

Re: AsyncGetCallTrace java profiling

On 8/26/13 10:12 AM, serguei.spit...@oracle.com wrote: Alexandre, Thank you for the information and details. I've added your it to the JBS version of 8022893. The details from this link and the link itself were already in that bug report 8022893:

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: 4c84d351cca9 Author:stefank Date: 2013-08-16 13:22 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4c84d351cca9 8007074: SIGSEGV at ParMarkBitMap::verify_clear() Summary: Replace the broken large pages implementation on Linux. New flag:

hg: jdk8/tl/langtools: 8023768: Use the unannotatedType in cyclicity checks.

Changeset: 7bf6313e1ced Author:jjg Date: 2013-08-26 15:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7bf6313e1ced 8023768: Use the unannotatedType in cyclicity checks. Reviewed-by: jjg Contributed-by: wdi...@gmail.com !

Re: AsyncGetCallTrace java profiling

On 8/26/13 10:12 AM, serguei.spit...@oracle.com wrote: Alexandre, Thank you for the information and details. I've added your it to the JBS version of 8022893. The details from this link and the link itself were already in that bug report 8022893:

Re: jstack can't attach to JVM (OS X)

On 26/08/2013 10:31 PM, Staffan Larsen wrote: Here is what's happening: - The VM sets the signal mask for all threads (except the internal VMThread) to mask out SIGQUIT using pthread_sigmask(). So the process will still respond to SIGQUIT, but only one thread. - The verifier code calls setjmp()

hg: jdk8/tl/jaxws: 3 new changesets

Changeset: 42211ab0ab1c Author:cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/42211ab0ab1c Added tag jdk8-b103 for changeset 6cdc6ed98780 ! .hgtags Changeset: 88390df7ed2c Author:cl Date: 2013-08-22 09:10 -0700 URL:

hg: jdk8/tl/jaxp: 4 new changesets

Changeset: a22fe9bd01e6 Author:cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a22fe9bd01e6 Added tag jdk8-b103 for changeset b1ceab582fc6 ! .hgtags Changeset: af28b93bfb6f Author:cl Date: 2013-08-22 09:10 -0700 URL:

hg: jdk8/tl/nashorn: 5 new changesets

Changeset: afc100513451 Author:cl Date: 2013-08-15 09:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/afc100513451 Added tag jdk8-b103 for changeset 414203de4374 ! .hgtags Changeset: 74244f43c577 Author:cl Date: 2013-08-22 09:10 -0700 URL:

hg: jdk8/tl/corba: 2 new changesets

Changeset: d411c60a8c2f Author:cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d411c60a8c2f Added tag jdk8-b103 for changeset 49c4a777fdfd ! .hgtags Changeset: 4e38de7c767e Author:cl Date: 2013-08-22 09:09 -0700 URL:

hg: jdk8/tl/langtools: 6 new changesets

Changeset: dd4a00c220c6 Author:cl Date: 2013-08-15 09:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dd4a00c220c6 Added tag jdk8-b103 for changeset 76cfe7c61f25 ! .hgtags Changeset: f2ee3a4e7927 Author:cl Date: 2013-08-22 09:10 -0700 URL:

hg: jdk8/tl: 9 new changesets

Changeset: ceefd94ef326 Author:cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ceefd94ef326 Added tag jdk8-b103 for changeset b7e64be81c8a ! .hgtags Changeset: 4fb877dfe5c4 Author:erikj Date: 2013-08-15 17:14 +0200 URL:

hg: jdk8/tl/hotspot: 32 new changesets

Changeset: 0bbd1c775bef Author:cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0bbd1c775bef Added tag jdk8-b103 for changeset 6f9be7f87b96 ! .hgtags Changeset: 39127bb12d32 Author:amurillo Date: 2013-08-09 01:39 -0700 URL:

hg: jdk8/tl/jdk: 23 new changesets

Changeset: f1d8d15bfcb5 Author:cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f1d8d15bfcb5 Added tag jdk8-b103 for changeset e0f6039c0290 ! .hgtags Changeset: c982f579b67e Author:cl Date: 2013-08-22 09:10 -0700 URL: