Seems good to go to me.
David
On 5/09/2013 10:52 PM, Jaroslav Bachorik wrote:
On 09/04/2013 10:33 AM, Jaroslav Bachorik wrote:
On 09/04/2013 10:29 AM, David Holmes wrote:
On 4/09/2013 4:56 PM, Jaroslav Bachorik wrote:
On 09/04/2013 04:24 AM, Mandy Chung wrote:
Hi Jaroslav,
Like Daniel and
Changeset: e32a8a29643a
Author:bpatel
Date: 2013-09-05 16:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e32a8a29643a
8023608: method grouping tabs folding issue
Reviewed-by: jjg
!
src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css
!
Changeset: 9cc74675a854
Author:rfield
Date: 2013-09-05 14:58 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9cc74675a854
8024283: 10 nashorn tests fail with similar stack trace InternalError with
cause being NoClassDefFoundError
Summary: Fix pre-existing 292 bug tickled by c
On 9/3/13 11:56 PM, Jaroslav Bachorik wrote:
Ok, let's go back to the basics :)
The reason for the test to fail intermittently are stale reads from the
"waiting" variable. In order to minimize the changes it seems sufficient
to make the "waiting" variable volatile to prevent the stale reads. Th
Changeset: f35e1255024b
Author:cl
Date: 2013-09-05 02:46 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/f35e1255024b
Added tag jdk8-b106 for changeset bf70cbd2c836
! .hgtags
Changeset: e3c9328f7563
Author:cl
Date: 2013-09-05 02:45 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/e3c9328f7563
Added tag jdk8-b106 for changeset 6908370afe83
! .hgtags
Changeset: 4c711ef41bfa
Author:naoto
Date: 2013-09-05 10:14 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4c711ef41bfa
8023943: Method description fix for String.toLower/UpperCase() methods
Reviewed-by: okutsu
! src/share/classes/java/lang/String.java
Changeset: 21198f51bc7e
Author:erikj
Date: 2013-08-29 15:47 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/21198f51bc7e
8003162: build-infra: Improve suggestions for missing packages on linux
Reviewed-by: tbell, omajid
! common/autoconf/generated-configure.sh
! common/aut
Changeset: d6a32e3831aa
Author:cl
Date: 2013-09-05 02:45 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/d6a32e3831aa
Added tag jdk8-b106 for changeset d3be8e3b429d
! .hgtags
Changeset: aafc0f332658
Author:cl
Date: 2013-09-05 02:46 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/aafc0f332658
Added tag jdk8-b106 for changeset c817276bd870
! .hgtags
Changeset: 3f274927ec18
Author:cl
Date: 2013-09-05 02:46 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/3f274927ec18
Added tag jdk8-b106 for changeset fcd768844b99
! .hgtags
Changeset: 23fc34133152
Author:cl
Date: 2013-09-05 02:45 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/23fc34133152
Added tag jdk8-b106 for changeset 2e3a056c84a7
! .hgtags
Coleen,
This is great finding, and also a nice catch by Dan.
Waiting for a new webrev from you.
Thanks,
Serguei
On 9/5/13 9:35 AM, Coleen Phillimore wrote:
Dan,
Thank you for looking at this so quickly. You are right, we are not
only getting public methods, whose number cannot change right
On 9/5/13 10:35 AM, Coleen Phillimore wrote:
Dan,
Thank you for looking at this so quickly.
No problem. What motivated this was I just finished analyzing that
SIGSEGV crash in my AdHoc test run that I thought might be this bug.
I felt like I had enough context...
You are right, we are not on
Dan,
Thank you for looking at this so quickly. You are right, we are not
only getting public methods, whose number cannot change right now with
redefine classes.
I have to rework this change.
Thanks,
Coleen
On 9/5/2013 12:23 PM, Daniel D. Daugherty wrote:
On 9/5/13 9:33 AM, Coleen Phillimo
On 9/5/13 9:33 AM, Coleen Phillimore wrote:
Summary: Need to refetch the methods array from InstanceKlass after
safepoint.
open webrev at http://cr.openjdk.java.net/~coleenp/8022887/
The "frames" links are broken in this webrev. I had to
write down the changed line numbers for jvm.cpp and the
Summary: Need to refetch the methods array from InstanceKlass after
safepoint.
open webrev at http://cr.openjdk.java.net/~coleenp/8022887/
bug link at http://bugs.sun.com/view_bug.do?bug_id=8022887
Tested with the test cases in the bug, and with internal SQE tests
(nsk.quick.testlist).
thank
Yeah, I agree that it is hard to know where to log these failures to, although
I don't like them being swallowed. We should have a standardized way of logging
all JVM failures, warnings, etc. (JEP 158 anyone?)
Anyway, that's unrelated to your patch, which looks good to me.
/Staffan
On 5 sep
Hi Staffan --
Yes, I made some attempts but didn't reproduce it, though anything that
allocates can presumably cause an exception if the timing and memory
usage is right (or wrong).
On the clearing of exceptions... All about not crashing the Service
Thread I suppose, but it may not have be
I agree that your change looks good, but there are a couple of things that bug
me.
Why did createGcInfo() fail? Hard to tell if you can't repro the failure,
though.
The code below will make sure we swallow any exceptions that occurred without
reporting them. This isn't good practice. I would l
Hi,
If I have my CHECK and THREAD thinking straight, I have a small review
request in gcNotifier, to avoid a crash that came up in testing recently.
The report is a hotspot crash in a test, where there's an exception
pending when calling java_lang_String::create_from_str, which allocates.
W
On 9/5/13 2:52 PM, Jaroslav Bachorik wrote:
On 09/04/2013 10:33 AM, Jaroslav Bachorik wrote:
On 09/04/2013 10:29 AM, David Holmes wrote:
On 4/09/2013 4:56 PM, Jaroslav Bachorik wrote:
On 09/04/2013 04:24 AM, Mandy Chung wrote:
Hi Jaroslav,
Like Daniel and David said, CyclicBarrier and other
On 09/04/2013 10:33 AM, Jaroslav Bachorik wrote:
> On 09/04/2013 10:29 AM, David Holmes wrote:
>> On 4/09/2013 4:56 PM, Jaroslav Bachorik wrote:
>>> On 09/04/2013 04:24 AM, Mandy Chung wrote:
Hi Jaroslav,
Like Daniel and David said, CyclicBarrier and other j.u.concurrent
utility
Changeset: 9522b5e836d3
Author:jbachorik
Date: 2013-09-05 14:34 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9522b5e836d3
8004179: Few of test/java/lang/management/ThreadMXBean/* tests don't clean up
the created threads
Summary: Just run those tests in "othervm" mode.
Revi
Changeset: af1b08ff48ae
Author:jbachorik
Date: 2013-09-05 13:04 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af1b08ff48ae
8023464: test/closed/sun/tracing/ProviderProxyTest.java failing
Summary: Don't rely on assertions when an Exception suits better
Reviewed-by: alanb, dfu
Changeset: a76c663a9cac
Author:jfranck
Date: 2013-09-05 11:27 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a76c663a9cac
8023974: Drop 'implements Completer' and 'implements SourceCompleter' from
ClassReader resp. JavaCompiler.
Reviewed-by: jjg, jfranck
Contributed-by
I have added 2 tasts to make sure that call
OpenMBean*InfoSupport.equals/hashCode do not throw NPE
The unit tests and JCK tests are passed.
Webrev: http://cr.openjdk.java.net/~sjiang/JDK-8023529/00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8023529
Thanks,
Shanliang
On 2013-09-05 02:30, Christian Thalinger wrote:
>
> On Sep 4, 2013, at 1:35 PM, Dmitry Samersoff
> wrote:
>
>> Please, review the changes.
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8015848/webrev.01/
>
> With this change you can dump the boot class path classes again?
>
Yes. Also I man
28 matches
Mail list logo
