hg: jdk8/tl/jdk: 8023954: MBean*Info.equals: throw NPE

2013-09-17 Thread shanliang . jiang
Changeset: 8708569b5524 Author:sjiang Date: 2013-09-18 08:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8708569b5524 8023954: MBean*Info.equals: throw NPE Reviewed-by: dfuchs, dholmes ! src/share/classes/javax/management/MBeanAttributeInfo.java ! src/share/classes/javax/

hg: jdk8/tl/langtools: 8024538: -Xdoclint + -Xprefer:source + incremental compilation == FAIL

2013-09-17 Thread jonathan . gibbons
Changeset: fdfbc5f0c4ed Author:jjg Date: 2013-09-17 14:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fdfbc5f0c4ed 8024538: -Xdoclint + -Xprefer:source + incremental compilation == FAIL Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/DocLint.java ! src/

Re: RFR: 7196151: ParserTest SEGv on solaris

2013-09-17 Thread Dmitry Samersoff
Peter, Looks good for me. But I would prefer to have brackets around c != NULL -Dmitry On 2013-09-17 19:44, Peter Allwin wrote: > Hello! > > Please review this small fix for an issue where jio_snprintf may be > called with a null argument causing SEGV on Solaris. This can occur if > to_string

ATT! Re: RR(S): JDK-7133122 SA throws sun.jvm.hotspot.debugger.UnmappedAddressException when it should not

2013-09-17 Thread Dmitry Samersoff
Need a second reviewer! On 2013-09-15 16:59, Dmitry Samersoff wrote: > Hi Everybody, > > http://cr.openjdk.java.net/~dsamersoff/JDK-7133122/webrev.01/ > > Please review the small fix. This patch was contributed by Yasumasa Suenaga. > > -Dmitry > -- Dmitry Samersoff Oracle Java development t

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-09-17 Thread christian . tornqvist
Changeset: 88d6b9a1c27c Author:mseledtsov Date: 2013-09-17 20:09 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/88d6b9a1c27c 8016029: test runtime/6878713/Test6878713.sh failed Summary: Rewrote test in Java; updated the test condition to reflect latest changes in

Re: RFR: 7196151: ParserTest SEGv on solaris

2013-09-17 Thread Staffan Larsen
Looks good! /Staffan On 17 sep 2013, at 17:44, Peter Allwin wrote: > Hello! > > Please review this small fix for an issue where jio_snprintf may be called > with a null argument causing SEGV on Solaris. This can occur if to_string is > called on a GenDCmdArgument with no default value. > >

Re: RFR: 7196151: ParserTest SEGv on solaris

2013-09-17 Thread Coleen Phillimore
This test also exposed an unhandled oop in the JVM, I thought the fix for this bug would include this fix also (but the webrev is gone). Never mind, it can also be fixed with 7195622. This fix looks good. Coleen On 09/17/2013 11:44 AM, Peter Allwin wrote: Hello! Please review this small

RFR: 7196151: ParserTest SEGv on solaris

2013-09-17 Thread Peter Allwin
Hello! Please review this small fix for an issue where jio_snprintf may be called with a null argument causing SEGV on Solaris. This can occur if to_string is called on a GenDCmdArgument with no default value. cr: http://cr.openjdk.java.net/~allwin/7196151/webrev.00/ bug: https://bugs.openjdk.j

RE: 7196151: ParserTest SEGv on solaris

2013-09-17 Thread Christian Tornqvist
Looks good! Thanks, Christian From: hotspot-runtime-dev-boun...@openjdk.java.net [mailto:hotspot-runtime-dev-boun...@openjdk.java.net] On Behalf Of Peter Allwin Sent: Tuesday, September 17, 2013 11:44 AM To: serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net Subject:

hg: jdk8/tl/jdk: 7097386: Correct error in Predicate javadoc example

2013-09-17 Thread lance . andersen
Changeset: 657482758408 Author:lancea Date: 2013-09-17 07:56 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/657482758408 7097386: Correct error in Predicate javadoc example Reviewed-by: alanb, shade ! src/share/classes/javax/sql/rowset/Predicate.java

Re: RFR: 8014659: NPG: performance counters for compressed klass space

2013-09-17 Thread Erik Helin
Hi Staffan, On 2013-09-12, Staffan Larsen wrote: > Looks good (I'll take your word that the nasty awk scripts are correct...). thanks for the review! On 2013-09-12, Staffan Larsen wrote: > I think you should have included serviceability-dev on this review request. Agree, I'm adding them as part

RE: RFR: 8012923: [parfait] File Descriptor Leak in jdk/src/windows/demo/jvmti/hprof/hprof_md.c

2013-09-17 Thread Markus Grönlund
Peter, Looks good (I'm not a Reviewer). Thanks for fixing this. Cheers Markus -Original Message- From: Peter Allwin Sent: den 16 september 2013 17:44 To: serviceability-dev@openjdk.java.net Subject: RFR: 8012923: [parfait] File Descriptor Leak in jdk/src/windows/demo/jvmti/hprof/hprof