On 23/09/2013 15:43, Staffan Larsen wrote:
This test uses byte code instrumentation and there were two errors in the test
which under some circumstances caused the VM to crash. I have updated the test
to run with -Xverify:all which would have caught the problems earlier. The
other changes add
This test uses byte code instrumentation and there were two errors in the test
which under some circumstances caused the VM to crash. I have updated the test
to run with -Xverify:all which would have caught the problems earlier. The
other changes add a missing ALOAD instruction and make sure tha
Changeset: 09301757bb32
Author:emc
Date: 2013-09-23 15:37 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/09301757bb32
6499673: Assertion check for TypeVariable.getUpperBound() fails.
Summary: Fix TypeVariable.getUpperBound to return results as specified
Reviewed-by: jjg
Changeset: 084b21cd0228
Author:iklam
Date: 2013-09-23 08:56 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/084b21cd0228
8025088: Missing cases for JVM_CONSTANT_MethodHandleInError cause crash if
debugger steps into error-tagged method handle
Summary: Need to refet
Hi,
Please review this test fix, if the test continues failing, then we need
to investigate the Monitor implementation.
webrev: http://cr.openjdk.java.net/~sjiang/JDK-8025207/00/
bug: https://bugs.openjdk.java.net/browse/JDK-8025207
Thanks,
Shanliang
Staffan,
On 2013-09-23 21:32, Staffan Larsen wrote:
> Looks good! Thanks for doing this cleanup. I wish we could get rid of one the
> files.
I plan to merge these files and place it to agent/os/nix/ . This cleanup
is the first step.
-Dmitry
>
> Thanks,
> /Staffan
>
>
> On 23 sep 2013, at 08
On 23 sep 2013, at 10:35, Dmitry Samersoff wrote:
> Staffan,
>
> On 2013-09-23 21:32, Staffan Larsen wrote:
>> Looks good! Thanks for doing this cleanup. I wish we could get rid of one
>> the files.
>
> I plan to merge these files and place it to agent/os/nix/ . This cleanup
> is the first st
Looks good! Thanks for doing this cleanup. I wish we could get rid of one the
files.
Thanks,
/Staffan
On 23 sep 2013, at 08:50, Dmitry Samersoff wrote:
> Please, review a changes.
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8025250/webrev.01/
>
> Problem:
>
> agent/os/linux/ps_core.c an
Please, review a changes.
http://cr.openjdk.java.net/~dsamersoff/JDK-8025250/webrev.01/
Problem:
agent/os/linux/ps_core.c and agent/os/bsd/ps_core.c has lots of common
code but this code has different indentation, bracketing, comments etc.
Solution:
sync formatting between these two files to s
Changeset: 64e79d38bd07
Author:kizune
Date: 2013-09-23 18:29 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/64e79d38bd07
4881267: improve diagnostic for "instanceof T" for type parameter T
Reviewed-by: vromero, jjg
! src/share/classes/com/sun/tools/javac/comp/Attr.java
Erik,
Thanks for the review!
On 9/23/13 2:36 AM, Erik Joelsson wrote:
I have looked (primarily) at the jdk and root repo changes, which look
good to me.
Thanks.
You say that the changes in jdk are just to support importing .diz
files, but it looks like you are enabling FDS in the jdk buil
Changeset: 809a50f24d6f
Author:kizune
Date: 2013-09-23 17:27 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/809a50f24d6f
7154966: CRs found to be in Fixed state with no test and no noreg- keyword.
Reviewed-by: ksrini
+ test/tools/javac/T7090499.java
+ test/tools/javac/
Looks good. I wonder what might be happening to cause such slowdowns of
test machines from time to time though ...
-JB-
On 23.9.2013 13:53, shanliang wrote:
Hi,
The JMX server implementation has not been changed since long time,
the test failure must be a waiting time issue, let's have a lon
Hi,
The JMX server implementation has not been changed since long time, the
test failure must be a waiting time issue, let's have a long timeout, we
will need investigation on the server if the test continues failing.
webrev: http://cr.openjdk.java.net/~sjiang/8025204jdk/00/
bug: https://bugs
Changeset: 5f915a0c9615
Author:alundblad
Date: 2013-09-23 10:42 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5f915a0c9615
6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
Summary: Static factory method ListBuffer.lb removed. Replaced by constructor
cal
Changeset: 279f47b353f3
Author:sundar
Date: 2013-09-20 20:55 +0530
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/279f47b353f3
8025147: Trailing comma is not allowed in JSONArray and JSONObject
Reviewed-by: hannesw, jlaskey
! src/jdk/nashorn/internal/parser/JSONParser.java
! s
May I have a reviewer take a look at this, please?
-JB-
On 18.7.2013 14:11, Daniel Fuchs wrote:
Hi Jaroslav,
Looks good overall.
Small nit:
You should remove the comment lines 322-327
in ModelMBeanInfoSupport.java since your changes make it obsolete.
Also the copyright year in ImmutableData
Changeset: 1fe358ea75ff
Author:alundblad
Date: 2013-09-23 10:10 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1fe358ea75ff
8024988: javac, LVT test harness should generate tests .class files in the
scratch folder
Summary: Set the CLASS_OUTPUT location to the scratch d
I have looked (primarily) at the jdk and root repo changes, which look
good to me.
You say that the changes in jdk are just to support importing .diz
files, but it looks like you are enabling FDS in the jdk build too, or
am I missing something?
/Erik
On 2013-09-21 05:36, Daniel D. Daugherty
19 matches
Mail list logo
