Changeset: 1a71d800b032
Author:wetmore
Date: 2013-10-16 23:31 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/1a71d800b032
8026762: jdk8-tl builds windows builds failing in corba - javac: no source files
Reviewed-by: katleman, dholmes
! makefiles/BuildCorba.gmk
Changeset: 1899da5c71d3
Author:hannesw
Date: 2013-10-16 10:12 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1899da5c71d3
8026692: eval() throws NullPointerException with --compile-only
Reviewed-by: sundar, lagergren
!
Hi Shanliang,
Looks good!
-- daniel
On 10/16/13 3:58 PM, shanliang wrote:
Hi,
Please review the following fix, main issue here is that we should clone
an internal variable before returning.
webrev:
http://cr.openjdk.java.net/~sjiang/JDK-8026028/00/
bug
David,
OK. I'm guilty overcomplicating simple things. I step back and
followed Staffan advice to just use ROUNDUP macro directly.
Webrev changed in-place.
http://cr.openjdk.java.net/~dsamersoff/JDK-8025812/webrev.01/
-Dmitry
On 2013-10-17 06:46, David Holmes wrote:
Hi Dmitry,
In
716
Hi David,
On 17.10.2013 04:26, David Holmes wrote:
Hi Jaroslav,
Minor nit: os::elapsed_time should really be defined in terms of the
other functions ie:
return ((double) os::elapsed_counter()) / os::elapsed_frequency();
Ok. I've changed it. It better communicates the way the elapsedTime is
On Oct 16, 2013, at 3:58 PM, shanliang shanliang.ji...@oracle.com wrote:
Hi,
Please review the following fix, main issue here is that we should clone an
internal variable before returning.
webrev:
http://cr.openjdk.java.net/~sjiang/JDK-8026028/00/
bug
This version looks good. A minor nit is a missing space after the comma in
calls to ROUNDUP.
/Staffan
On 17 okt 2013, at 12:10, Dmitry Samersoff dmitry.samers...@oracle.com wrote:
David,
OK. I'm guilty overcomplicating simple things. I step back and
followed Staffan advice to just use
Staffan,
On 2013-10-17 14:46, Staffan Larsen wrote:
This version looks good. A minor nit is a missing space after the comma in
calls to ROUNDUP.
Thank you (nit fixed and webrev reloaded)
-Dmitry
/Staffan
On 17 okt 2013, at 12:10, Dmitry Samersoff dmitry.samers...@oracle.com
wrote:
Thanks - good to go!
On 17 okt 2013, at 12:54, Dmitry Samersoff dmitry.samers...@oracle.com wrote:
Staffan,
On 2013-10-17 14:46, Staffan Larsen wrote:
This version looks good. A minor nit is a missing space after the comma in
calls to ROUNDUP.
Thank you (nit fixed and webrev reloaded)
On 17/10/2013 8:10 PM, Jaroslav Bachorik wrote:
Hi David,
On 17.10.2013 04:26, David Holmes wrote:
Hi Jaroslav,
Minor nit: os::elapsed_time should really be defined in terms of the
other functions ie:
return ((double) os::elapsed_counter()) / os::elapsed_frequency();
Ok. I've changed it.
On 17/10/2013 9:01 PM, Staffan Larsen wrote:
Thanks - good to go!
+1
Thanks,
David
On 17 okt 2013, at 12:54, Dmitry Samersoff dmitry.samers...@oracle.com wrote:
Staffan,
On 2013-10-17 14:46, Staffan Larsen wrote:
This version looks good. A minor nit is a missing space after the comma in
On 17/10/2013 9:07 PM, David Holmes wrote:
On 17/10/2013 8:10 PM, Jaroslav Bachorik wrote:
Hi David,
On 17.10.2013 04:26, David Holmes wrote:
Hi Jaroslav,
Minor nit: os::elapsed_time should really be defined in terms of the
other functions ie:
return ((double) os::elapsed_counter()) /
Changeset: a48d3b981083
Author:mnunez
Date: 2013-10-17 13:27 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a48d3b981083
8015372: Update tests for Method Parameter Reflection API to check whether a
parameter is final
Reviewed-by: jjg, jfranck
!
On 17.10.2013 13:07, David Holmes wrote:
On 17/10/2013 8:10 PM, Jaroslav Bachorik wrote:
Hi David,
On 17.10.2013 04:26, David Holmes wrote:
Hi Jaroslav,
Minor nit: os::elapsed_time should really be defined in terms of the
other functions ie:
return ((double) os::elapsed_counter()) /
Changeset: 37e3dcb798c3
Author:weijun
Date: 2013-10-17 20:56 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/37e3dcb798c3
8026712: TEST_BUG: update sun/security/tools/keytool/autotest.sh with a new
location to find of libsoftokn3.so
Reviewed-by: vinnie
!
Hi Phil,
thanks a lot for the review. Please see my comments inline:
On Wed, Oct 16, 2013 at 12:48 AM, Phil Race philip.r...@oracle.com wrote:
Hello Volker,
I just remembered got back to these changes - my email inbox isn't a very
good reminder system.
I am OK with everything I see in the
Hi
I have added a new revision of my changes here:
http://cr.openjdk.java.net/~allwin/farvidss/8024423/webrev.02/
http://cr.openjdk.java.net/%7Eallwin/farvidss/8024423/webrev.02/
The idea is to use a lock called metaspace_lock available inside the
ClassLoaderData objects that the
Changeset: 0a6730b5e192
Author:drchase
Date: 2013-10-16 17:55 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a6730b5e192
8022718: Runtime accessibility checking: protected class, if extended, should
be accessible from another package
Summary: Modify accessibility check; it
Changeset: 36fe6a9bd43e
Author:rriggs
Date: 2013-10-17 10:37 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/36fe6a9bd43e
8026516: javadoc errors in java.time
Summary: Corrected links to TemporalQuery and TemporalField.resolve
Reviewed-by: mduigou, darcy, lancea
!
Changeset: 5d866df64ae3
Author:mullan
Date: 2013-10-17 10:18 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d866df64ae3
8026346: test/java/lang/SecurityManager/CheckPackageAccess.java failing
Reviewed-by: vinnie
! src/share/lib/security/java.security-macosx
!
Changeset: 1bee3014cf2a
Author:dsamersoff
Date: 2013-10-17 16:08 +0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1bee3014cf2a
8025812: tmtools/jmap/heap_config tests fail on Linux-ia32 because it Cant
attach to the core file
Summary: Coredump store memsz elf field
Changeset: 456a9b199208
Author:rriggs
Date: 2013-10-17 13:43 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/456a9b199208
8026183: minor documentation problems in java.lang.invoke
8015808: Typo in MethodHandle javadoc
Summary: Fix typos and javadoc markup and extraneous
Changeset: 0c3f951630fe
Author:joehw
Date: 2013-10-17 11:22 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/0c3f951630fe
8015243: SchemaFactory does not catch enum. value that is not in the value
space of the base type, anyURI
Reviewed-by: lancea
!
Changeset: bc04f561bb78
Author:joehw
Date: 2013-10-17 11:43 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc04f561bb78
8015243: SchemaFactory does not catch enum. value that is not in the value
space of the base type, anyURI
Reviewed-by: lancea
+
Changeset: fa38f8e0accd
Author:juh
Date: 2013-10-17 12:00 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fa38f8e0accd
8026233: test/sun/security/tools/keytool/StorePasswords.java needs to clean up
files
Reviewed-by: vinnie
!
Changeset: ffb471203842
Author:erikj
Date: 2013-10-17 16:11 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ffb471203842
8026792: HOTSPOT: licensee reports a JDK8 build failure after 8005849/8005008
fixes integrated.
Reviewed-by: dholmes, sla
!
Changeset: 64c0ac7cd936
Author:lancea
Date: 2013-10-17 15:14 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64c0ac7cd936
8026812: doclint clean up for java.sql and javax.sql
Reviewed-by: mduigou
! src/share/classes/java/sql/CallableStatement.java
!
- Original Message -
As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported,
I'd like to have another attempt at adding the annotation to a number of
JDK specific APIs that are long standing exported, documented and
supported APIs. Specifically, the following APIs:
Changeset: defadd528513
Author:mchung
Date: 2013-10-17 13:19 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/defadd528513
8015912: jdeps support to output in dot file format
8026255: Switch jdeps to follow traditional Java option style
Reviewed-by: alanb
!
Changeset: 3735d81552a7
Author:mchung
Date: 2013-10-17 13:22 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3735d81552a7
8015912: jdeps support to output in dot file format
8026255: Switch jdeps to follow traditional Java option style
Reviewed-by: alanb
!
Changeset: c1af85c48819
Author:mduigou
Date: 2013-10-17 12:43 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1af85c48819
8004138: ForkJoinTask leaks exceptions
Reviewed-by: chegar, mduigou, psandoz, martin
Contributed-by: Doug Lea d...@cs.oswego.edu
!
On 10/17/13 12:25 PM, Andrew wrote:
I just came across this trying to understand what the new annotation means.
Is the intention for these 'exported' APIs to be eventually replaced by proper
parts of the specification (i.e. java.* or javax.*). I'm not keen on the idea
of encouraging the use
Changeset: 9ec6626d43bb
Author:mduigou
Date: 2013-10-17 14:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/9ec6626d43bb
8026062: webrev.ksh: fix bug title web scraping, remove teamware, sac, open
bug, -l and wxfile support
Reviewed-by: weijun, dsamersoff, darcy, jrose, tbell
Hi Mikael and Coleen,
thanks for your reviews!
On 2013-10-16, Mikael Gerdin wrote:
jvmtiImpl.hpp:
Since clone() uses unhandled oops, and is only supposed to be used
by the VM operation, would it make sense to
assert(SafepointSynchronize::is_at_safepoint())?
196 GrowableElement *clone()
Changeset: e76bb2436b04
Author:bpb
Date: 2013-10-17 15:05 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e76bb2436b04
8026832: Clean up straggling doclint warnings in java.math
Summary: Fix empty paragraph tag warnings.
Reviewed-by: lancea
!
Changeset: 951c1f7fdb10
Author:joehw
Date: 2013-10-17 16:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/951c1f7fdb10
8016500: Unlocalized warnigs.
Reviewed-by: lancea
! src/com/sun/org/apache/xerces/internal/jaxp/DefaultValidationErrorHandler.java
!
Changeset: acae2e8a46df
Author:ihse
Date: 2013-10-10 14:58 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/acae2e8a46df
8001931: The new build system whitespace cleanup
Reviewed-by: tbell, simonis, erikj
! makefiles/BuildJaxp.gmk
! makefiles/Makefile
Changeset:
Changeset: 7dea0ce25bdc
Author:pbhat
Date: 2013-05-30 16:00 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/rev/7dea0ce25bdc
Merge
! common/autoconf/generated-configure.sh
Changeset: d081bdbf904d
Author:jqzuo
Date: 2013-06-10 16:15 -0400
URL:
Changeset: 66fc1a749867
Author:ihse
Date: 2013-10-10 14:58 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/66fc1a749867
8001931: The new build system whitespace cleanup
Reviewed-by: tbell, simonis, erikj
! makefiles/BuildCorba.gmk
! makefiles/Makefile
Changeset:
Changeset: 45399f3ef717
Author:ihse
Date: 2013-10-10 14:58 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/45399f3ef717
8001931: The new build system whitespace cleanup
Reviewed-by: tbell, simonis, erikj
! makefiles/BuildNashorn.gmk
! makefiles/Makefile
Changeset:
Changeset: 602fdd7bb765
Author:ihse
Date: 2013-10-10 14:58 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/602fdd7bb765
8001931: The new build system whitespace cleanup
Reviewed-by: tbell, simonis, erikj
! makefiles/BuildJaxws.gmk
! makefiles/Makefile
Changeset:
Changeset: 343aeb2033f0
Author:ihse
Date: 2013-10-10 14:58 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/343aeb2033f0
8001931: The new build system whitespace cleanup
Reviewed-by: tbell, simonis, erikj
! makefiles/BuildLangtools.gmk
! makefiles/Makefile
Changeset:
Changeset: 28191d3ff921
Author:erikj
Date: 2013-10-09 16:22 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28191d3ff921
8026144: Missing mkdir in Images.gmk
Reviewed-by: tbell
! makefiles/Images.gmk
Changeset: 86df2e879eca
Author:tbell
Date: 2013-10-09 18:50 -0700
Changeset: deec468baebd
Author:amurillo
Date: 2013-10-04 14:19 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/deec468baebd
8025859: new hotspot build - hs25-b54
Reviewed-by: jcoomes
! make/hotspot_version
Changeset: 5b3b75d9eb2f
Author:coleenp
Date: 2013-10-01
Changeset: c1616a944d1c
Author:weijun
Date: 2013-10-18 08:57 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1616a944d1c
7025699: Policy Tool is not accessible by keyboard
Reviewed-by: alexp, weijun
Contributed-by: Leif Samuelsson leif.samuels...@oracle.com
!
Changeset: 7af634b1fc5b
Author:darcy
Date: 2013-10-17 19:10 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7af634b1fc5b
8026838: Fix new doclint issues in javax.annotation.processing
Reviewed-by: jjg
! src/share/classes/javax/annotation/processing/Processor.java
Changeset: 042a473535aa
Author:mchung
Date: 2013-10-17 19:47 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/042a473535aa
8025799: Restore sun.reflect.Reflection.getCallerClass(int) until a replacement
API is provided
Reviewed-by: alanb, forax, dholmes, twisti
!
Changeset: 8a7b1b615100
Author:darcy
Date: 2013-10-17 22:22 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a7b1b615100
8026840: Fix new doclint issues in javax.naming
Reviewed-by: mchung
! src/share/classes/javax/naming/CompositeName.java
!
Hi Erik,
The fix looks good in general.
But one thing is confusing in the fix.
Why do you keep both _class_loader and _class_loader_handle in the
JvmtiBreakpoint class?
Also, you need to run the nsk.jdi.testlist and nsk.jdwp.testlist test
suites as well.
Thanks,
Serguei
On 10/17/13 2:28
I forgot to say thank you for taking care about this issue!
Thanks,
Serguei
On 10/17/13 10:49 PM, serguei.spit...@oracle.com wrote:
Hi Erik,
The fix looks good in general.
But one thing is confusing in the fix.
Why do you keep both _class_loader and _class_loader_handle in the
50 matches
Mail list logo
