Hi Fredrik,
After our email side-bar it seems to me that the bug here is in the
JDKToolLauncher constructor:
private JDKToolLauncher(String tool, boolean useCompilerJDK) {
if (useCompilerJDK) {
executable = JDKToolFinder.getJDKTool(tool);
} else {
On 21/10/2013 9:55 PM, Jaroslav Bachorik wrote:
Please, review this small patch for a test failing due to the updated
implementation in JDK6.
Issue: https://bugs.openjdk.java.net/browse/JDK-6309226
Webrev: http://cr.openjdk.java.net/~jbachorik/6309226/webrev.00/
The test fails due to the
Hi,
Could I please have a review of this fix.
Webrev:
http://cr.openjdk.java.net/~ykantser/8026962/webrev.00/
Bug:
https://bugs.openjdk.java.net/browse/JDK-8026962
Thanks,
Katja
Sorry, the wrong webrev link has slipped through.
Here is the right one:
http://cr.openjdk.java.net/~ykantser/809/webrev.01/
Thanks,
Katja
On 10/21/2013 05:23 PM, Yekaterina Kantserova wrote:
Hi,
I've done following changes after the reviews:
- added open copyrights
- documented all
Looks good!
Thanks,
/Staffan
On 22 okt 2013, at 10:18, Yekaterina Kantserova
yekaterina.kantser...@oracle.com wrote:
Hi,
Could I please have a review of this fix.
Webrev:
http://cr.openjdk.java.net/~ykantser/8026962/webrev.00/
Bug:
https://bugs.openjdk.java.net/browse/JDK-8026962
Changeset: 04ba97b7c2f9
Author:jfranck
Date: 2013-10-22 10:34 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04ba97b7c2f9
8009411: (reflect) Class.getMethods should not include static methods from
interfaces
Summary: Update getMethods() and getMethod() to filter out
Changeset: bb2fb6be8b2a
Author:ykantser
Date: 2013-10-22 10:57 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb2fb6be8b2a
8026962: Put java/lang/management/ClassLoadingMXBean/LoadCounts.java into
ProblemList.txt
Reviewed-by: sla, jbachorik
! test/ProblemList.txt
On 22.10.2013 09:58, David Holmes wrote:
On 21/10/2013 9:55 PM, Jaroslav Bachorik wrote:
Please, review this small patch for a test failing due to the updated
implementation in JDK6.
Issue: https://bugs.openjdk.java.net/browse/JDK-6309226
Webrev:
Changeset: 963c57175e40
Author:vromero
Date: 2013-10-22 13:54 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/963c57175e40
8025290: javac implicit versus explicit lambda compilation error
Reviewed-by: jjg, dlsmith
! src/share/classes/com/sun/tools/javac/comp/Attr.java
Changeset: 7cafbb397683
Author:chegar
Date: 2013-10-22 14:00 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7cafbb397683
8017779: java/net/Authenticator/B4769350.java fails
Reviewed-by: chegar
Contributed-by: Tristan Yan tristan@oracle.com, Kurchi Subhra Hazra
Changeset: 5f4aecd73caa
Author:mullan
Date: 2013-10-22 08:03 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5f4aecd73caa
8021191: Add isAuthorized check to limited doPrivileged methods
Reviewed-by: weijun, xuelei
! src/share/classes/java/security/AccessControlContext.java
!
Thanks for the reviews.
Mikael
On 2013-10-18 13:09, Peter Allwin wrote:
+1
Thanks,
/peter
On Oct 18, 2013, at 12:56 PM, Staffan Larsen staffan.lar...@oracle.com wrote:
Looks good!
Thanks,
/Staffan
On 16 okt 2013, at 14:04, Mikael Auno mikael.a...@oracle.com wrote:
This bug got a bit
Changeset: 54869853c06c
Author:alanb
Date: 2013-10-22 14:13 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/54869853c06c
7074436: (sc) SocketChannel can do short gathering writes when channel
configured blocking (win)
Reviewed-by: chegar
!
Please, review the following test fix:
Issue: https://bugs.openjdk.java.net/browse/JDK-8020467
Webrev: http://cr.openjdk.java.net/~jbachorik/8020467/webrev.01
The test tries to make sure that the pool usage threshold trigger and
the reported pool memory usage are not contradicting each other.
Changeset: d8d5b7919c57
Author:sundar
Date: 2013-10-22 14:27 +0530
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d8d5b7919c57
8027016: Array.prototype.indexOf should return -1 when array is of length zero
Reviewed-by: lagergren, attila
!
Frederik,
This code looks good and addresses my concerns. It's an improvement and
resolves this issue. I suggest that we should wait to see what
initiating loader means for anonymous classes since the jvm doesn't have
that information readily before tackling that. But ship this fix
On 10/17/13 4:02 PM, Fredrik Arvidsson wrote:
Hi
I have added a new revision of my changes here:
http://cr.openjdk.java.net/~allwin/farvidss/8024423/webrev.02/
http://cr.openjdk.java.net/%7Eallwin/farvidss/8024423/webrev.02/
I haven't looked at the patch i great detail, but I found this
Changeset: 6a1989dc302d
Author:igerasim
Date: 2013-10-15 18:41 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a1989dc302d
8023390: Test java/net/NetworkInterface/MemLeakTest.java failed with the latest
jdk8 build
Summary: Removing the test as it is unreliable and fails
Changeset: 72c0f289a8cb
Author:kizune
Date: 2013-10-22 22:18 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72c0f289a8cb
8026873: tools/launcher/VersionCheck.java fails in jprt because of jmc.ini
Reviewed-by: ksrini
! test/tools/launcher/VersionCheck.java
Changeset: 2be08cdd1ced
Author:bpb
Date: 2013-10-22 11:25 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2be08cdd1ced
7179567: JCK8 tests: api/java_net/URLClassLoader/index.html#Ctor3 failed with
NPE
6445180: URLClassLoader does not describe the behavior of several methods
Changeset: 9a32af82bd1e
Author:darcy
Date: 2013-10-22 12:04 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9a32af82bd1e
8027062: Fix lint and doclint issues in java.lang.{ClassLoader, ClassValue,
SecurityManager}
Reviewed-by: chegar, forax, alanb, mduigou
!
Changeset: c956a5d0618f
Author:juh
Date: 2013-10-22 11:57 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c956a5d0618f
8025287: NPE in
api/java_security/cert/PKIXRevocationChecker/GeneralTests_GeneralTests
Reviewed-by: mullan
!
Changeset: e2b814e68956
Author:rriggs
Date: 2013-10-22 15:03 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2b814e68956
8024686: Cleanup of java.time serialization source
Summary: optimize serialized form of OffsetTime, OffsetDateTime; correct order
of modifiers
On 10/21/13 7:46 AM, Jaroslav Bachorik wrote:
Please, review this simple test fix.
Issue: https://bugs.openjdk.java.net/browse/JDK-7112404
Webrev: http://cr.openjdk.java.net/~jbachorik/7112404/webrev.00
Looks okay to me.
Mandy
The tests assume the MemoryUsage#commited values to be
Hi Jaroslav,
On 10/22/13 6:47 AM, Jaroslav Bachorik wrote:
Please, review the following test fix:
Issue: https://bugs.openjdk.java.net/browse/JDK-8020467
Webrev: http://cr.openjdk.java.net/~jbachorik/8020467/webrev.01
Have you considered to force GC when getUsed() == 0 regardless of which
Changeset: e84413f066e0
Author:mfang
Date: 2013-10-22 14:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e84413f066e0
8026109: [ja] overtranslation of jarsigner in command line output
Reviewed-by: naoto
! src/share/classes/sun/security/tools/jarsigner/Resources_ja.java
Changeset: 4bb758a77fd7
Author:rriggs
Date: 2013-10-22 17:02 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bb758a77fd7
8026982: javadoc errors in core libs
Summary: Cleanup of javadoc -Xlint errors
Reviewed-by: lancea, mduigou, darcy, mullan, mchung
!
Changeset: 9fbf35589211
Author:smarks
Date: 2013-10-22 14:51 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9fbf35589211
8026427: deprecate obsolete APIs from java.rmi
Reviewed-by: alanb, dfuchs
! src/share/classes/java/rmi/RMISecurityManager.java
!
Changeset: 0913c3bab168
Author:henryjen
Date: 2013-10-22 15:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0913c3bab168
8025909: Lambda Library Spec Updates
8024179: Document limitations and performance characteristics of stream sources
and operations
8024138: (Spec
Changeset: 662c154d2749
Author:hseigel
Date: 2013-10-22 14:47 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/662c154d2749
8026394: Eclipse fails with JDK8 build 111
Summary: If the resolved interface does not itself contain clone or
finalize methods, the
Changeset: fc7a6fa3589a
Author:ascarpino
Date: 2013-10-22 19:37 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc7a6fa3589a
8025763: Provider does not override new Hashtable methods
Reviewed-by: mullan
! src/share/classes/java/security/Provider.java
Changeset: b065de1700d3
Changeset: 6cd16d8ed2b9
Author:rfield
Date: 2013-10-22 16:53 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6cd16d8ed2b9
8023668: Desugar serializable lambda bodies using more robust naming scheme
Summary: lambda / bridged method-reference naming overhaul
Reviewed-by:
Changeset: d545d67e2f68
Author:weijun
Date: 2013-10-23 08:32 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d545d67e2f68
8027026: Change keytool -genkeypair to use -keyalg RSA
Reviewed-by: alanb, chegar, mullan
! test/ProblemList.txt
!
On 22/10/2013 9:03 PM, Jaroslav Bachorik wrote:
On 22.10.2013 09:58, David Holmes wrote:
On 21/10/2013 9:55 PM, Jaroslav Bachorik wrote:
Please, review this small patch for a test failing due to the updated
implementation in JDK6.
Issue: https://bugs.openjdk.java.net/browse/JDK-6309226
Changeset: 351d6808c1a5
Author:jjg
Date: 2013-10-22 17:42 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/351d6808c1a5
8027119: Cleanup javadoc comments for taglet API
Reviewed-by: mduigou
! src/share/classes/com/sun/javadoc/Tag.java
Changeset: 41d3ffca22ff
Author:
Changeset: b8860472c377
Author:iklam
Date: 2013-10-22 14:29 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b8860472c377
8014910: deadlock between JVM/TI ClassPrepare event handler and CompilerThread
Summary: Revert changes in JDK-8008962
Reviewed-by: coleenp,
Hi Erik,
Sorry I hadn't had a chance to get back to this. This new approach seems
fine - though I had to convince myself of the no GC can occur part :)
A couple of typos:
JvmtiBreakpoint:s
The :s should just be s
Thanks,
David
On 21/10/2013 7:26 PM, Erik Helin wrote:
Hi all,
this is the
On 21/10/2013 7:50 PM, Dmitry Samersoff wrote:
Hi Everybody,
Please review a small fix.
http://cr.openjdk.java.net/~dsamersoff/JDK-8026950/webrev.01/
I don't understand why this is only a compile error on open hotspot?
PT_CONTINUE seems to be the necessary value for OSX and other BSD
Changeset: a997d762fa20
Author:hseigel
Date: 2013-10-22 15:54 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a997d762fa20
8026809: [TESTBUG] Create regression test for JDK-8026041
Summary: Created simple regression test for the bug
Reviewed-by: hseigel, lfoltan,
39 matches
Mail list logo
