Re: RFR: JDK-8027371 Add JDI tests for breakpointing and stepping in lambda code

Mandy, Serguei: Thanks for the reviews! On 28 okt 2013, at 22:10, serguei.spit...@oracle.com wrote: These are nice to have tests. They look good. Thanks, Serguei On 10/28/13 4:10 AM, Staffan Larsen wrote: We currently don't have any debugger tests that explicitly exercises lambdas. I

hg: jdk8/tl/jdk: 8027371: Add JDI tests for breakpointing and stepping in lambda code

Changeset: ecba02f6be31 Author:sla Date: 2013-10-29 08:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ecba02f6be31 8027371: Add JDI tests for breakpointing and stepping in lambda code Reviewed-by: mchung, sspitsyn + test/com/sun/jdi/LambdaBreakpointTest.java +

hg: jdk8/tl/jdk: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

Changeset: d34c5e860d5f Author:aefimov Date: 2013-10-24 17:23 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d34c5e860d5f 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing Reviewed-by: okutsu, mfang, alanb ! test/ProblemList.txt !

hg: jdk8/tl/nashorn: 3 new changesets

Changeset: 7985ec3782b5 Author:hannesw Date: 2013-10-25 10:20 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7985ec3782b5 8027042: Evaluation order for binary operators can be improved Reviewed-by: lagergren, jlaskey, attila !

RFR(S): 7145419 com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events.

This test fails if there are background threads that run while the test is running. I've modified the test to use the trace commands in jdb with the extra thread parameter. I have assumed that the main thread has thread id 1. trace with thread id behaves a little bit different so a couple of

hg: jdk8/tl: 26 new changesets

Changeset: 3dc55f0c1b6f Author:jlaskey Date: 2013-01-28 16:29 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/3dc55f0c1b6f 8006676: Integrate Nashorn into new build system Reviewed-by: jlaskey Contributed-by: james.las...@oracle.com ! common/autoconf/generated-configure.sh !

hg: jdk8/tl/jdk: 27 new changesets

Changeset: a8bbd962f34a Author:jlaskey Date: 2013-01-28 16:29 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8bbd962f34a 8006676: Integrate Nashorn into new build system Reviewed-by: jlaskey Contributed-by: james.las...@oracle.com ! THIRD_PARTY_README !

Re: RFR(S): 7145419 com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events.

Looks good, if we can assume main thread has id = 1 (main thread must use first j.l.Thread object that is created) /Erik Staffan Larsen skrev 2013-10-29 15:41: This test fails if there are background threads that run while the test is running. I've modified the test to use the trace

hg: jdk8/tl/jdk: 8027466: Revert jdk/THIRD_PARTY_README to known good version

Changeset: 121c34517841 Author:chegar Date: 2013-10-29 17:21 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/121c34517841 8027466: Revert jdk/THIRD_PARTY_README to known good version Reviewed-by: alanb ! THIRD_PARTY_README

RFR 8027358: sun/management/jmxremote/bootstrap/LocalManagementTest.java failing since JDK-8004926

Please, review this test fix. In agentvm mode the test can not rely on the co-location of the test class and the auxiliary classes the test class wants to start. It is necessary to explicitly provide the test class path when starting an external java process. Issue :

hg: jdk8/tl/jdk: 3 new changesets

Changeset: 6fc2889fe7d0 Author:mfang Date: 2013-10-29 11:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6fc2889fe7d0 8026108: [it, ja, zh_CN] wrong translation in jar example. Reviewed-by: okutsu, yhuang ! src/share/classes/sun/tools/jar/resources/jar_it.properties !

Re: RFR 8027358: sun/management/jmxremote/bootstrap/LocalManagementTest.java failing since JDK-8004926

Looks good. /Erik Jaroslav Bachorik skrev 2013-10-29 18:28: Please, review this test fix. In agentvm mode the test can not rely on the co-location of the test class and the auxiliary classes the test class wants to start. It is necessary to explicitly provide the test class path when

Re: RFR 8027358: sun/management/jmxremote/bootstrap/LocalManagementTest.java failing since JDK-8004926

On 29/10/2013 17:28, Jaroslav Bachorik wrote: Please, review this test fix. In agentvm mode the test can not rely on the co-location of the test class and the auxiliary classes the test class wants to start. It is necessary to explicitly provide the test class path when starting an external

hg: jdk8/tl/jdk: 8027358: sun/management/jmxremote/bootstrap/LocalManagementTest.java failing since JDK-8004926

Changeset: a3ac9c0b19a9 Author:jbachorik Date: 2013-10-29 21:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a3ac9c0b19a9 8027358: sun/management/jmxremote/bootstrap/LocalManagementTest.java failing since JDK-8004926 Reviewed-by: alanb, egahlin !

hg: jdk8/tl/jaxp: 8027484: Implementation error in SAX2DOM.java

Changeset: 1af33ab1bc58 Author:joehw Date: 2013-10-29 14:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/1af33ab1bc58 8027484: Implementation error in SAX2DOM.java Reviewed-by: alanb, lancea ! src/com/sun/org/apache/xalan/internal/xsltc/trax/SAX2DOM.java

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 8cfc73ad9f31 Author:mfang Date: 2013-10-29 15:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8cfc73ad9f31 8008647: [es] minor cosmetic issues in translated java command line outputs Reviewed-by: naoto !

hg: jdk8/tl/jdk: 8025521: [de] mnemonic conflict in FileChooser for GTK Style feellook

Changeset: bede752d1e3c Author:mfang Date: 2013-10-29 16:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bede752d1e3c 8025521: [de] mnemonic conflict in FileChooser for GTK Style feellook Reviewed-by: naoto !