Looks good! Reviewed.
Thanks,
/Staffan
On 30 okt 2013, at 10:27, Yekaterina Kantserova
yekaterina.kantser...@oracle.com wrote:
http://cr.openjdk.java.net/~ykantser/809/webrev.04/
Fixed your points and changed ./test/sun/tools/jstatd/TestJstatdUsage.java to
use JDKToolLauncher
On 2013-10-29 15:41, Staffan Larsen wrote:
This test fails if there are background threads that run while the
test is running. I've modified the test to use the trace commands
in jdb with the extra thread parameter. I have assumed that the main
thread has thread id 1. trace with thread id
I tried, that, but couldn't find what the jdb command for getting the current
thread is. Anyone?
/Staffan
On 30 okt 2013, at 11:17, Mikael Auno mikael.a...@oracle.com wrote:
On 2013-10-29 15:41, Staffan Larsen wrote:
This test fails if there are background threads that run while the
test is
On 24.10.2013 21:33, Mandy Chung wrote:
On 10/24/2013 7:01 AM, Jaroslav Bachorik wrote:
Hi Mandy,
On 24.10.2013 01:02, Mandy Chung wrote:
On 10/23/2013 7:32 AM, Jaroslav Bachorik wrote:
I've updated the patch. The GC is called even before the first attempt
to get the pool memory usage and
Could I have a reviewer to take a look at this, please?
Thanks,
-JB-
On 23.10.2013 18:18, Daniel Fuchs wrote:
Looks good to me!
-- daniel
On 10/23/13 6:13 PM, Jaroslav Bachorik wrote:
On 23.10.2013 17:49, Daniel Fuchs wrote:
On 10/23/13 5:35 PM, Jaroslav Bachorik wrote:
On 23.10.2013
Looks good!
Thanks,
/Staffan
On 30 okt 2013, at 12:27, Jaroslav Bachorik jaroslav.bacho...@oracle.com
wrote:
Could I have a reviewer to take a look at this, please?
Thanks,
-JB-
On 23.10.2013 18:18, Daniel Fuchs wrote:
Looks good to me!
-- daniel
On 10/23/13 6:13 PM, Jaroslav
The current thread number is part of the jdb prompt.
So something like this:
$ jdb Hello
Initializing jdb ...
stop in Hello.main
Deferring breakpoint Hello.main.
It will be set after the class is loaded.
run
run Hello
Set uncaught java.lang.Throwable
Set deferred uncaught java.lang.Throwable
But that does not seem to work correctly:
Initializing jdb ...
stop in JdbMethodExitTest.bkpt()
Deferring breakpoint JdbMethodExitTest.bkpt().
It will be set after the class is loaded.
run
run JdbMethodExitTest
Set uncaught java.lang.Throwable
Set deferred uncaught java.lang.Throwable
VM
Changeset: 5d1bda6c1fe3
Author:jbachorik
Date: 2013-10-30 14:50 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d1bda6c1fe3
8027058: sun/management/jmxremote/bootstrap/RmiBootstrapTest.sh Failed to
initialize connector
Summary: Dynamically discover the first available port
Could I have a review of this intermittently failing test.
Instead of doing Thread.sleep(2000) and assume principal is visible/set
the test now spins until principal is available. I also cleaned up code
to avoid warnings.
Thanks
Erik
Webrev:
http://cr.openjdk.java.net/~egahlin/8027209_2/
Not a reviewer, so just en observation. Seems like there are 2 jtreg
headers now:
24 /*
25 * @test
26 * @bug 6222826
27 * @summary Test that each thread in the thread pool runs
28 * in the context of the monitor.start() caller.
29 * @author Luis-Miguel Alventosa
30
Will fix, not used to see @test before imports. Same problem with 6849945.
Erik
Yekaterina Kantserova skrev 2013-10-30 15:40:
Not a reviewer, so just en observation. Seems like there are 2 jtreg
headers now:
24 /*
25 * @test
26 * @bug 6222826
27 * @summary Test that each thread in
Changeset: 9a5048dc7c0d
Author:chegar
Date: 2013-10-30 14:41 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9a5048dc7c0d
8026880: NetworkInterface native initializing code should check fieldID values
Reviewed-by: alanb
! src/solaris/native/java/net/NetworkInterface.c
!
Looks good.
I will sponsor the commit.
Thanks,
/Staffan
On 30 okt 2013, at 14:31, Yekaterina Kantserova
yekaterina.kantser...@oracle.com wrote:
I've forgot to mention one more fix. I've renamed JstatGcutilParser to
JstatGCUtilParser (a tip from Erik), to follow standards in testlibrary
Alex,
This looks much better! Thanks for spending the time.
README:
nit: contribuited - contributed
JdpTestUtilTest.java:
Can you add a comment saying this is a test for the tests - just like
PacketTest.java and PortAlreadyInUseTest.java?
PortFinder.java:
Please remove this and use
Changeset: b04b124418d8
Author:ykantser
Date: 2013-10-30 13:44 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b04b124418d8
809: Intermittent test failures in sun/tools/jstatd
Reviewed-by: sla, egahlin, jbachorik, allwin
+
Looks good, minus the extra @test tag.
/Staffan
On 30 okt 2013, at 15:45, Erik Gahlin erik.gah...@oracle.com wrote:
Could I have a review of this intermittently failing test.
There is a race between a thread being created and the request to get its CPU
time. The /proc/... structure might
Changeset: aa91bc6e8480
Author:mchung
Date: 2013-10-30 08:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/aa91bc6e8480
8027481: jdeps to handle classes with the same package name and correct profile
for javax.crypto.*
Reviewed-by: alanb, dfuchs
!
Changeset: 04778b00286a
Author:joehw
Date: 2013-10-30 08:58 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/04778b00286a
8024378: StAX parser shall support JAXP properties
Reviewed-by: dfuchs, lancea
!
Changeset: ea79ab313e98
Author:mgerdin
Date: 2013-10-30 15:35 +0100
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ea79ab313e98
8027252: Crash in interpreter because get_unsigned_2_byte_index_at_bcp reads 4
bytes
Summary: Use 2-byte loads to load indexes from the byte
On 10/30/2013 4:23 AM, Jaroslav Bachorik wrote:
Ok. I've added a big object and an initial call to System.gc(). But
I'm leaving the calls to System.gc() right before checking the pools
as well - just to be sure.
http://cr.openjdk.java.net/~jbachorik/8020467/webrev.04
The update looks okay
Changeset: 550244957351
Author:mfang
Date: 2013-10-30 09:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/550244957351
6192407: s10_70, ko, s1/dvd, minor misspelling under Select Software
Localizations
Reviewed-by: yhuang
!
On 30.10.2013 17:30, Mandy Chung wrote:
On 10/30/2013 4:23 AM, Jaroslav Bachorik wrote:
Ok. I've added a big object and an initial call to System.gc(). But
I'm leaving the calls to System.gc() right before checking the pools
as well - just to be sure.
Changeset: 2a714dabb624
Author:jbachorik
Date: 2013-10-30 17:54 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a714dabb624
8020467: Inconsistency between usage.getUsed() and isUsageThresholdExceeded()
with CMS Old Gen pool
Reviewed-by: mchung, brutisso
!
Changeset: 067355edfbf8
Author:vinnie
Date: 2013-10-30 17:31 +
URL: http://hg.openjdk.java.net/jdk8/tl/rev/067355edfbf8
8027567: JDK 8 build failure: the correct version of GNU make is being rejected
Reviewed-by: chegar, erikj
! common/autoconf/basics.m4
!
Changeset: 537fa895fd74
Author:vromero
Date: 2013-10-30 18:09 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/537fa895fd74
8027327: jar files related to test test/tools/javac/ExtDirs/ExtDirTest.java
should be removed from the repo
Reviewed-by: ksrini
!
Changeset: 7bc67bed3c14
Author:michaelm
Date: 2013-10-30 18:37 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7bc67bed3c14
8027570: NullPointerException in URLPermission.hashCode()
Reviewed-by: chegar
! src/share/classes/java/net/URLPermission.java
!
Changeset: fdd464c8d62e
Author:acorn
Date: 2013-10-30 09:11 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fdd464c8d62e
8027304: Lambda: inheriting abstract + 1 default - default, not ICCE
Reviewed-by: hseigel, zgu
! src/share/vm/classfile/defaultMethods.cpp
Changeset: b098ee22aa97
Author:erikj
Date: 2013-10-24 10:43 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/rev/b098ee22aa97
8009280: JCE jurisdiction policy files not copied into jdk/lib/security
Reviewed-by: tbell, ihse
! common/makefiles/JavaCompilation.gmk
Changeset:
Changeset: d6d8aeb2c2d4
Author:amurillo
Date: 2013-10-19 08:52 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d6d8aeb2c2d4
8026928: new hotspot build - hs25-b56
Reviewed-by: jcoomes
! make/hotspot_version
Changeset: 384c92148c68
Author:amurillo
Date:
Changeset: ddb0b681654a
Author:briangoetz
Date: 2013-10-29 12:31 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ddb0b681654a
8027318: Lambda Metafactory: generate serialization-hostile read/writeObject
methods for non-serializable lambdas
Reviewed-by: rfield, psandoz
!
Changeset: e8894e3224d9
Author:darcy
Date: 2013-10-30 17:27 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8894e3224d9
8005294: Consider default methods for additions to AnnotatedElement
Reviewed-by: jfranck, plevart, mchung, abuckley, sogoel
!
Changeset: 1ea1b24c1a04
Author:smarks
Date: 2013-10-30 18:39 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ea1b24c1a04
8023863: deprecate support for statically-generated stubs from RMI (JRMP)
4449028: exportObject() javadoc should specify behavior for null socket
Changeset: 0734e1584d9d
Author:bpb
Date: 2013-10-30 17:45 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0734e1584d9d
6910473: java.math.BigInteger.bitLength() may return negative int on large
numbers
8021203: BigInteger.doubleValue/floatValue returns 0.0 instead of
8026948: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint might not
work with anonymous classes
Summary: Walk methods in breakpoints for marking on stack so they aren't
deallocated by redefine classes. Use class_holder rather than
class_loader to keep GC from reclaiming class owning the
35 matches
Mail list logo
