Changeset: c4c84b5a3dfa
Author:alanb
Date: 2013-11-13 07:43 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4c84b5a3dfa
8028239: test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh with
NoClassDefFoundError
Reviewed-by: mchung, egahlin
! test/sun/jvmstat/monitor
Erik,
The fix looks good.
Thanks,
Serguei
On 11/12/13 12:33 PM, Erik Gahlin wrote:
Could I please have a review of a regression test that fails
intermittently because a full GC is not always triggered.
Fix is to call System.gc()
Webrev:
http://cr.openjdk.java.net/~egahlin/6954510_1
Bug:
ht
The patch looks okay to me.
Mandy
On 11/12/2013 1:35 PM, Alan Bateman wrote:
This test was liberated earlier today via JDK- 6543856 [1].
Unfortunately it is failing again, this time with a
NoClassDefFoundError because it can't locate the JavaProcess class.
The issue can be quickly fixed with
My fault, thanks for fixing. Looks good.
Erik
Alan Bateman skrev 2013-11-12 22:35:
This test was liberated earlier today via JDK- 6543856 [1].
Unfortunately it is failing again, this time with a
NoClassDefFoundError because it can't locate the JavaProcess class.
The issue can be quickly fix
This test was liberated earlier today via JDK- 6543856 [1].
Unfortunately it is failing again, this time with a NoClassDefFoundError
because it can't locate the JavaProcess class. The issue can be quickly
fixed with the attached patched (to add testlibrary to the classpah).
Alternatively we c
Could I please have a review of a regression test that fails
intermittently because a full GC is not always triggered.
Fix is to call System.gc()
Webrev:
http://cr.openjdk.java.net/~egahlin/6954510_1
Bug:
https://bugs.openjdk.java.net/browse/JDK-6954510
Thanks
Erik
Changeset: ebe27e1a2e2d
Author:rriggs
Date: 2013-11-12 14:03 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ebe27e1a2e2d
8028014: Doclint warning/error cleanup in javax.management
Summary: Improve generated html by fixing doclint warnings
Reviewed-by: sla, jbachorik
! src/sh
Changeset: 0c414ac10700
Author:alanb
Date: 2013-11-12 17:37 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c414ac10700
8028208: (aio) Assertion in clearPendingIoMap when closing at around time file
lock is acquired immediately (win)
Reviewed-by: chegar
! src/windows/classe
Changeset: 69432cb5bca2
Author:darcy
Date: 2013-11-12 09:44 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69432cb5bca2
8028229: Fix more raw types lint warning in core libraries
Reviewed-by: chegar, forax, lancea, alanb, jfranck
! src/share/classes/java/io/ObjectOutputStrea
Changeset: d9f827e4d20c
Author:egahlin
Date: 2013-11-12 18:12 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d9f827e4d20c
6849945: VM Periodic Task Thread CPU time = -1ns in
HotspotThreadMBean.getInternalThreadCpuTimes()
Reviewed-by: sla
! test/sun/management/HotspotThreadM
Changeset: 4cff9f59644f
Author:egahlin
Date: 2013-11-12 17:40 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4cff9f59644f
6543856: MonitorVmStartTerminate.sh fails intermittently
Reviewed-by: sla, dholmes
! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java
!
Changeset: f6012ca3bdd3
Author:smarks
Date: 2013-11-12 16:59 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f6012ca3bdd3
8028027: serialver should emit declaration with the 'private' modifier
Reviewed-by: darcy, mchung, alanb, chegar
! src/share/classes/sun/tools/serialver/S
Hi Vitaly,
Thanks for you input!
"You have some operator overloads for these that can compare them against
jlongs - doesn't that still make it easy to mix up what you're comparing?
Personally, since these are value types I'd make their API work only against
these new types and make calle
Changeset: 41dcb0c2e194
Author:egahlin
Date: 2013-11-12 14:52 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41dcb0c2e194
8027209: javax/management/monitor/ThreadPoolAccTest.java fails intermittently
Reviewed-by: sla, jbachorik
! test/javax/management/monitor/ThreadPoolAccTe
Greetings,
Kindly asking for reviews for the following changeset:
Webrev: http://cr.openjdk.java.net/~mgronlun/8028128/webrev01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8028128
Description:
Currently, when working with counter based data, the primary data type
representa
Changeset: e65a98146b94
Author:attila
Date: 2013-11-11 14:25 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e65a98146b94
8028020: Function parameter as last expression in comma in return value causes
bad type calculation
Reviewed-by: jlaskey, lagergren, sundar
! src/jdk
Looks good to me (not a reviewer).
/F
On 2013-11-12 09:45, Jaroslav Bachorik wrote:
Looks fine.
-JB-
On 11.11.2013 19:42, Staffan Larsen wrote:
Please review this small fix to output SA message to stdout instead
of stderr.
webrev: http://cr.openjdk.java.net/~sla/6626412/webrev.00/
bug: htt
Looks fine.
-JB-
On 11.11.2013 19:42, Staffan Larsen wrote:
Please review this small fix to output SA message to stdout instead of stderr.
webrev: http://cr.openjdk.java.net/~sla/6626412/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-6626412
Thanks,
/Staffan
Looks fine (not-a-reviewer)
-JB-
On 11.11.2013 21:25, Staffan Larsen wrote:
Ah, good catch.
Here is an updated review: http://cr.openjdk.java.net/~sla/6606002/webrev.01/
Thanks,
/Staffan
On 11 Nov 2013, at 21:06, serguei.spit...@oracle.com wrote:
It looks good.
The only one nit is about t
19 matches
Mail list logo
