Looks good!
Thanks for picking this up,
/Staffan
On 20 nov 2013, at 00:12, Mandy Chung mandy.ch...@oracle.com wrote:
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8028647/webrev.00/
This patch turns the trace on by default and also add the instrumentation to
print the
Hi Per,
Thanks for taking a look!
Inline.
Cheers
Markus
From: Per Liden
Sent: den 18 november 2013 13:22
To: Markus Gronlund; hotspot-runtime-...@openjdk.java.net;
hotspot-gc-...@openjdk.java.net; serviceability-dev@openjdk.java.net
serviceability-dev@openjdk.java.net
Subject:
Hi David,
I'm sorry I haven't got around to updating and re-posting a new version for the
webrev :(
Thanks very much for reviewing.
I intend to send out an updated webrev which will contain the updates from the
feedback I have gotten so far.
In addition, I have a few improvements to the
Thanks for your feedback
Here is an updated webrev where the file is renamed.
http://cr.openjdk.java.net/~egahlin/6402201_2/
Erik
Alan Bateman skrev 2013-11-19 09:45:
On 18/11/2013 23:29, Erik Gahlin wrote:
Could I have a review of this test fix.
It appears it takes more than 10 s to write
On 20/11/2013 11:25, Erik Gahlin wrote:
Thanks for your feedback
Here is an updated webrev where the file is renamed.
http://cr.openjdk.java.net/~egahlin/6402201_2/
That looks okay to me. One small improvement would be to use
try-with-resources around the file write. Alternatively you could
Hi,
It looks like 8024423 is already fixed in jdk 8 b115 and following
tests are passing as a result:
demo/jvmti/hprof/HeapAllTest.java
demo/jvmti/hprof/HeapBinaryFormatTest.java
demo/jvmti/hprof/HeapDumpTest.java
demo/jvmti/hprof/OptionsTest.java
Changeset: 894a4bae9e33
Author:egahlin
Date: 2013-11-20 12:32 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/894a4bae9e33
7141544: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails
Reviewed-by: sla
! test/com/sun/jdi/BreakpointWithFullGC.sh
Hi again,
I have created an updated webrev02 for the feedback I have gotten so far. In
addition, I have added a few improvements to the original suggestion.
Updated Webrev02: http://cr.openjdk.java.net/~mgronlun/8028128/webrev02/
Original Webrev01:
This is more or less a copy of a previous patch that was made to JDI [1], but
this patch applies to the SA implementation of JDI.
ReferenceType.visibleMethods() has some problems with diamond shaped interface
hierarchies. The solution here is to maintain a list of interfaces that we have
Taras,
*The only* correct way to take really free port is:
1. Chose random number between 49152 and 65535
2. Open socket
if socket fails - repeat step 1
if socket OK - return *socket*
If you can't keep the socket open (e.g. you have to pass port number as
property value) you shouldn't do any
Changeset: f39be11835ff
Author:jfranck
Date: 2013-11-20 13:12 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f39be11835ff
8027413: Clarify javadoc for j.l.a.Target and j.l.a.ElementType
Reviewed-by: darcy
! src/share/classes/java/lang/annotation/ElementType.java
!
Looks good!
Thanks for doing this,
/Staffan
On 20 nov 2013, at 12:49, Balchandra Vaidya balchandra.vai...@oracle.com
wrote:
Hi,
It looks like 8024423 is already fixed in jdk 8 b115 and following
tests are passing as a result:
demo/jvmti/hprof/HeapAllTest.java
On 20.11.2013 14:04, Dmitry Samersoff wrote:
Taras,
*The only* correct way to take really free port is:
1. Chose random number between 49152 and 65535
2. Open socket
if socket fails - repeat step 1
if socket OK - return *socket*
If you can't keep the socket open (e.g. you have to pass port
Hi,
Could you please review this fix.
Summary of changes:
1. The real test bug fix is to add flag -Xshare:off when starting the
Application instance. Without that flag, the test for ClassFileTransformer in
RedefineAgent.java fails intermittently. The flag is added in function
Out of curiosity, what is the reason for the rename? I ask because we
use Basic and similar names in many areas. Also anything in the test
tree should be a test.
-Alan.
On 20/11/2013 13:47, Mattias Tobiasson wrote:
Hi,
Could you please review this fix.
Summary of changes:
1. The real
I don't know if you are still looking for a Reviewer for this one. It
looks okay to me (initially it looked like a lot of changes to review
but its not the case). You might need to adjust the copyright dates on
the script, unless of course the plane you were involved time travel :-)
-Alan.
Thanks Alan!
I’ll fix the copyright. Do you know if the javacc-generated files require
copyright headers?
/Staffan
On 20 nov 2013, at 14:56, Alan Bateman alan.bate...@oracle.com wrote:
I don't know if you are still looking for a Reviewer for this one. It looks
okay to me (initially it
Jaroslav,
Generally speacking - test getting port number from command line should
get it from harness and harness have to maintain a pool of free ports.
But it's a long term goal.
Today we don't have better option than chose a random number and hope
this port is free.
Any pre-check just
On 20/11/2013 13:58, Staffan Larsen wrote:
Thanks Alan!
I’ll fix the copyright. Do you know if the javacc-generated files require
copyright headers?
I wondering that too, it's probably safer to keep them.
-Alan.
Will do.
On 20 nov 2013, at 15:04, Alan Bateman alan.bate...@oracle.com wrote:
On 20/11/2013 13:58, Staffan Larsen wrote:
Thanks Alan!
I’ll fix the copyright. Do you know if the javacc-generated files require
copyright headers?
I wondering that too, it's probably safer to keep them.
Hi,
Each test requires 2 files, the actual test code and a helper file.
The helper file will launch a separate java process (called Application), and
then start the actual test. The actual test will then attach to the Application.
For example:
PermissionTests.sh: Helper file that will launch
How about defining the class that you want to attach to as a static
inner class to the actual test? That would give you only one file, but
with two classes, each with its own main method and clear correlation
between them.
Mikael
On 2013-11-20 15:41, Mattias Tobiasson wrote:
Hi,
Each test
Hi,
fyi, The jdk.testlibrary.Utils.getFreePort() method will Open an free
Socket, close it and return
the port number.
And as Alan recommended, use (0) when possible to have the system assign
the port #.
Roger
On 11/20/2013 8:04 AM, Dmitry Samersoff wrote:
Taras,
*The only* correct way
Staffan, Chris,
Thanks for the review.
On 11/20/2013 3:59 AM, Chris Hegarty wrote:
Mandy,
The changes look ok to me, and the approach of adding additional
diagnostic information makes sense.
Trivially, you can remove 'trace', as I don't think it is being used
any more.
Will remove it
Hello all!
Any chance to have this simple fix approved?
The proposal is to get rid of == and [[ bash extensions, as this is the
only place they are used in jdk regtests and sh-shell is not happy with
them.
Thanks in advance,
Ivan Gerasimov
---
Reviewed.
/Staffan
On 20 nov 2013, at 17:34, Ivan Gerasimov ivan.gerasi...@oracle.com wrote:
Hello all!
Any chance to have this simple fix approved?
The proposal is to get rid of == and [[ bash extensions, as this is the only
place they are used in jdk regtests and sh-shell is not happy
Roger,
As soon as we close a socket nobody can guarantee that the port is free.
Moreover, port returned by getFreePort()[1] remains not accessible for
some time - it depends to system setup, take a look to discussions
around SO_REUSEPORT for Linux or SO_REUSEADDR and SO_LINGER for BSD.
So from
Changeset: 90e27a47ff28
Author:mchung
Date: 2013-11-20 10:00 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/90e27a47ff28
8028647: Add instrumentation in GetSafepointSyncTime.java and remove it from
ProblemList.txt
Reviewed-by: sla, chegar
! test/ProblemList.txt
!
Hi,
this is the second review round for 8024854: Basic changes and files to
build the class library on
AIXhttps://bugs.openjdk.java.net/browse/JDK-8024854.
The previous reviews can be found at the end of this mail in the references
section.
I've tried to address all the comments and suggestions
Changeset: ef44a2971cb1
Author:bpatel
Date: 2013-11-20 10:53 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ef44a2971cb1
8027977: javadoc dies on NumberFormat/DateFormat subclass
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javadoc/DocEnv.java
+
Changeset: ecd6c25b54ce
Author:alanb
Date: 2013-11-20 21:34 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ecd6c25b54ce
8028734: test/java/util/Locale/InternationalBAT.java changes does not restore
the default TimeZone
Reviewed-by: naoto
!
Hi Markus,
I couldn't quite work out if TracingTime is obsolete after these changes?
Otherwise I have no further comments.
Thanks,
David
On 20/11/2013 10:17 PM, Markus Gronlund wrote:
Hi again,
I have created an updated webrev02 for the feedback I have gotten so far. In
addition, I have
32 matches
Mail list logo
