Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently

2013-11-21 Thread Mattias Tobiasson
I agree that merging both files in a single file may be good. The main reason why I did not do that is that I wanted to keep the history of the existing test. If I copy the test to a new file, all history of the code is lost. But this test bug was reported 8 years ago, and I don't believe much

RE: RFR(M): 8028128: Add a type safe alternative for working with counter based data

2013-11-21 Thread Markus Gronlund
Hi David, Thanks for taking a look again. Once transitioned from the external API boundary, TracingTime is/can be used internally in the tracing framework. I would like to keep this possibility, so I will leave it in. I will considered this Reviewed if you don't disagree then? Many thanks

Re: Review request for 7195249: Some jtreg tests use hard coded ports

2013-11-21 Thread Jaroslav Bachorik
On 20.11.2013 18:38, Dmitry Samersoff wrote: Roger, As soon as we close a socket nobody can guarantee that the port is free. Moreover, port returned by getFreePort()[1] remains not accessible for some time - it depends to system setup, take a look to discussions around SO_REUSEPORT for Linux

Re: RFR: 6402201: ProcessAttachTest.sh needs better synchronization

2013-11-21 Thread Erik Gahlin
Thanks, didn't know about ATOMIC_MOVE. it will be useful for other tests as well. http://cr.openjdk.java.net/~egahlin/6402201_3/ Erik Alan Bateman skrev 2013-11-20 12:43: On 20/11/2013 11:25, Erik Gahlin wrote: Thanks for your feedback Here is an updated webrev where the file is renamed.

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

2013-11-21 Thread Alan Bateman
On 20/11/2013 18:26, Volker Simonis wrote: Hi, this is the second review round for 8024854: Basic changes and files to build the class library on AIX https://bugs.openjdk.java.net/browse/JDK-8024854. The previous reviews can be found at the end of this mail in the references section. I've

Re: RFR: 6402201: ProcessAttachTest.sh needs better synchronization

2013-11-21 Thread Alan Bateman
On 21/11/2013 11:41, Erik Gahlin wrote: Thanks, didn't know about ATOMIC_MOVE. it will be useful for other tests as well. http://cr.openjdk.java.net/~egahlin/6402201_3/ Erik This looks very good. -Alan.

Re: RFR(M): 8028128: Add a type safe alternative for working with counter based data

2013-11-21 Thread David Holmes
On 21/11/2013 8:49 PM, Markus Gronlund wrote: Hi David, Thanks for taking a look again. Once transitioned from the external API boundary, TracingTime is/can be used internally in the tracing framework. I would like to keep this possibility, so I will leave it in. Ok. I will considered

hg: hsx/hotspot-rt/langtools: 18 new changesets

2013-11-21 Thread john . coomes
Changeset: cc80c03c41e4 Author:vromero Date: 2013-11-01 19:08 + URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/cc80c03c41e4 8027660: javac crash while creating LVT entry for a local variable defined in an inner block Reviewed-by: jjg Contributed-by:

hg: jdk8/tl/jdk: 8028628: java/nio/channels/FileChannel/Size.java failed once in the same binary run

2013-11-21 Thread dan . xu
Changeset: 81708985c0a2 Author:dxu Date: 2013-11-21 14:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81708985c0a2 8028628: java/nio/channels/FileChannel/Size.java failed once in the same binary run Reviewed-by: alanb, chegar, mchung, lancea !

Re: jstack and the target output

2013-11-21 Thread Alan Bateman
On 21/11/2013 13:06, Piotr Bzdyl wrote: Hello, I wasn't sure which OpenJDK mailing list I should choose for my question. As I have issues with jstack SA related group seemed the best place. I have the following issue: On console one (let's call it pts/1) I start a sample java app (let's

hg: jdk8/tl/jdk: 7065902: (file) test/java/nio/file/Files/Misc.java fails on Solaris 11 when run as root

2013-11-21 Thread dan . xu
Changeset: a74d6aa51654 Author:dxu Date: 2013-11-21 14:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a74d6aa51654 7065902: (file) test/java/nio/file/Files/Misc.java fails on Solaris 11 when run as root Reviewed-by: alanb ! test/java/nio/file/Files/Misc.java

hg: jdk8/tl/jdk: 8028215: ORB.init fails with SecurityException if properties select the JDK default ORB

2013-11-21 Thread mark . sheppard
Changeset: d5d4b9a63174 Author:msheppar Date: 2013-11-21 11:36 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5d4b9a63174 8028215: ORB.init fails with SecurityException if properties select the JDK default ORB Summary: check for default ORBImpl and ORBSingleton set via

Re: RFR 6987597: ManagementFactory.getGarbageCollectorMXBeans() returns empty list with CMS

2013-11-21 Thread Mandy Chung
Hi Jaroslav, On 11/19/2013 6:23 AM, Jaroslav Bachorik wrote: Please, review this test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-6987597 Webrev: http://cr.openjdk.java.net/~jbachorik/6987597/webrev.03 The fix moves the execution of the test routine to the GarbageCollectorMXBean

hg: jdk8/tl/jdk: 8028049: Tidy warnings cleanup for packages java.nio/java.io

2013-11-21 Thread yuri . nesterenko
Changeset: 19ff80da8283 Author:yan Date: 2013-11-18 17:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19ff80da8283 8028049: Tidy warnings cleanup for packages java.nio/java.io Reviewed-by: alanb, darcy Contributed-by: Sergey Lugovoy sergey.lugo...@oracle.com !

hg: jdk8/tl/jdk: 6402201: ProcessAttachTest.sh needs better synchronization

2013-11-21 Thread erik . gahlin
Changeset: 91ec3bc92793 Author:egahlin Date: 2013-11-21 13:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/91ec3bc92793 6402201: ProcessAttachTest.sh needs better synchronization Reviewed-by: alanb ! test/ProblemList.txt ! test/com/sun/jdi/ProcessAttachDebuggee.java !

hg: jdk8/tl/jdk: 7174936: several String methods claim to always create new String

2013-11-21 Thread stuart . marks
Changeset: 4bc37b6c4133 Author:smarks Date: 2013-11-21 16:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bc37b6c4133 7174936: several String methods claim to always create new String Reviewed-by: dholmes, bchristi, alanb, lancea ! src/share/classes/java/lang/String.java

hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b117 for changeset fe56ba456fd3

2013-11-21 Thread john . coomes
Changeset: 76a598cf50c4 Author:cl Date: 2013-11-21 09:22 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/76a598cf50c4 Added tag jdk8-b117 for changeset fe56ba456fd3 ! .hgtags

hg: jdk8/tl/jdk: 2 new changesets

2013-11-21 Thread valerie . peng
Changeset: 93826827e8b4 Author:valeriep Date: 2013-11-19 15:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93826827e8b4 8026943: SQE test jce/Global/Cipher/SameBuffer failed Summary: Always use different input/output buffers when calling FeedbackCipher objects

Re: jstack and the target output

2013-11-21 Thread Piotr Bzdyl
I recreated this problem in RedHat 6.4 installed in a virtual machine where I login as the same user on tty1 and tty2 - the setup for tmp is the same. I also tried with VM running Fedora 19 with 2 terminal windows in the X session. I tried to read files from /tmp/hsperfdata_$username/* from the

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

2013-11-21 Thread Volker Simonis
Hi Alan, thanks a lot for the fast review and your valuable comments. Please find my answers inline: On Thu, Nov 21, 2013 at 1:01 PM, Alan Bateman alan.bate...@oracle.comwrote: On 20/11/2013 18:26, Volker Simonis wrote: Hi, this is the second review round for 8024854: Basic changes and

Re: jstack and the target output

2013-11-21 Thread David Holmes
On 21/11/2013 11:47 PM, Piotr Bzdyl wrote: I recreated this problem in RedHat 6.4 installed in a virtual machine where I login as the same user on tty1 and tty2 - the setup for tmp is the same. I also tried with VM running Fedora 19 with 2 terminal windows in the X session. I tried to read

hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b117 for changeset c1d234d4f164

2013-11-21 Thread john . coomes
Changeset: e4e5069250e7 Author:cl Date: 2013-11-21 09:22 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/e4e5069250e7 Added tag jdk8-b117 for changeset c1d234d4f164 ! .hgtags

hg: hsx/hotspot-rt/nashorn: 13 new changesets

2013-11-21 Thread john . coomes
Changeset: ae5f2130c3b9 Author:sundar Date: 2013-11-01 19:54 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/ae5f2130c3b9 8027700: function redeclaration checks missing for declaration binding instantiation Reviewed-by: jlaskey, lagergren !

hg: hsx/hotspot-rt: Added tag jdk8-b117 for changeset a4afb0a8d55e

2013-11-21 Thread john . coomes
Changeset: 0a6db1aac998 Author:cl Date: 2013-11-21 09:22 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/0a6db1aac998 Added tag jdk8-b117 for changeset a4afb0a8d55e ! .hgtags

hg: jdk8/tl/jdk: 2 new changesets

2013-11-21 Thread chris . hegarty
Changeset: 2972241cf7eb Author:tyan Date: 2013-11-21 13:37 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2972241cf7eb 703: test/com/sun/net/httpserver/Test9a.java fails intermittently Summary: Additional stacktrace information is printed on failure Reviewed-by: alanb,

hg: hsx/hotspot-rt/corba: 4 new changesets

2013-11-21 Thread john . coomes
Changeset: b99535e22efe Author:mchung Date: 2013-11-07 20:48 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/b99535e22efe 8027943: serial version of com.sun.corba.se.spi.orbutil.proxy.CompositeInvocationHandlerImpl changed in 7u45 Reviewed-by: msheppar, alanb,

Re: jstack and the target output

2013-11-21 Thread Staffan Larsen
It could also be that one of the processes do not have access to /tmp (or that it is mapped differently). /Staffan On 21 nov 2013, at 14:14, Alan Bateman alan.bate...@oracle.com wrote: On 21/11/2013 13:06, Piotr Bzdyl wrote: Hello, I wasn't sure which OpenJDK mailing list I should choose

Re: jstack and the target output

2013-11-21 Thread Alan Bateman
On 21/11/2013 14:47, David Holmes wrote: I can recreate this using the minimal VM, which doesn't support libattach. So it definitely seems like something is going wrong in the attach process, but I can't say what. Not sure what debugging hooks we have for the attach mechanism ?? The first

hg: jdk8/tl/corba: 8028215: ORB.init fails with SecurityException if properties select the JDK default ORB

2013-11-21 Thread mark . sheppard
Changeset: fe781b3badd6 Author:msheppar Date: 2013-11-21 11:30 + URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/fe781b3badd6 8028215: ORB.init fails with SecurityException if properties select the JDK default ORB Summary: check for default ORBImpl and ORBSingleton set via

hg: hsx/hotspot-rt/hotspot: 8028520: JVM should not throw VerifyError when a private method overrides a final method

2013-11-21 Thread harold . seigel
Changeset: 19146c82b6fc Author:hseigel Date: 2013-11-21 14:41 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/19146c82b6fc 8028520: JVM should not throw VerifyError when a private method overrides a final method Summary: Exclude private methods when checking for

jstack and the target output

2013-11-21 Thread Piotr Bzdyl
Hello, I wasn't sure which OpenJDK mailing list I should choose for my question. As I have issues with jstack SA related group seemed the best place. I have the following issue: On console one (let's call it pts/1) I start a sample java app (let's say its pid is 1234). On another console

hg: jdk8/tl/jdk: 8028632: Update jdk/test/ProblemList.txt to reflect fix JDK-8024423

2013-11-21 Thread staffan . larsen
Changeset: fc9f24b9408e Author:sla Date: 2013-11-21 12:57 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc9f24b9408e 8028632: Update jdk/test/ProblemList.txt to reflect fix JDK-8024423 Summary: Removed 5 testcases from the ProblemList Reviewed-by: sla Contributed-by:

hg: jdk8/tl/jdk: 6703075: (process) java/lang/ProcessBuilder/Basic.java fails with fastdebug

2013-11-21 Thread rob . mckenna
Changeset: 89fccc5a7469 Author:martin Date: 2013-11-21 16:06 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89fccc5a7469 6703075: (process) java/lang/ProcessBuilder/Basic.java fails with fastdebug Reviewed-by: alanb ! test/java/lang/ProcessBuilder/Basic.java

hg: jdk8/tl/nashorn: 5 new changesets

2013-11-21 Thread sundararajan . athijegannathan
Changeset: fea9f0f9bbde Author:sundar Date: 2013-11-14 15:53 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fea9f0f9bbde 8028161: nashorn: src/jdk/nashorn/api/scripting/ScriptEngineTest.java Reviewed-by: lagergren, hannesw !