Changeset: 1f45b24ffe4b
Author:psandoz
Date: 2013-11-25 09:55 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f45b24ffe4b
8028516: Java doc error in Int/Long/Double/Stream.peek
Reviewed-by: chegar
! src/share/classes/java/util/stream/DoubleStream.java
!
Please, review one-line fix
http://cr.openjdk.java.net/~dsamersoff/JDK-8028408/webrev.01/
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
Looks good, although you need to wait for the new repos to appear before you
can push it.
Thanks,
/Staffan
On 25 nov 2013, at 11:08, Dmitry Samersoff dmitry.samers...@oracle.com wrote:
Please, review one-line fix
http://cr.openjdk.java.net/~dsamersoff/JDK-8028408/webrev.01/
--
This is very simple and a safe fix. :)
Thanks,
Serguei
On 11/25/13 2:08 AM, Dmitry Samersoff wrote:
Please, review one-line fix
http://cr.openjdk.java.net/~dsamersoff/JDK-8028408/webrev.01/
Hi Everybody,
Please review the fix in VM testbase
http://cr.openjdk.java.net/~dsamersoff/JDK-8026319/webrev.01/
With this changes, we skip lines that doesn't look like pmap entry
rather than abort on it. Skipped lines logged to stderr.
-Dmitry
--
Dmitry Samersoff
Oracle Java development
Dmitry,
VM testbase is not part of OpenJDK and review requests should go on internal
email lists.
/Staffan
On 25 nov 2013, at 14:25, Dmitry Samersoff dmitry.samers...@oracle.com wrote:
Hi Everybody,
Please review the fix in VM testbase
Hi, Volker,
just a few very minor comments about the client changes:
1. mlib_sys.c: the change is fine, but it makes the following comment
obsolete.
2. XRBackendNative.c: the same comment here.
3. Awt2dLibraries.gmk: $(JDK_TOPDIR)/src/aix/porting/porting_aix.c would
be better than just
Hi,
The test has been updated after the first review.
The two java files for each test has been merged to a single file.
Updated summary of changes:
1. The real test bug fix is to add flag -Xshare:off when starting the
Application instance. Without that flag, the test for ClassFileTransformer
Hi
I have a couple of high-level questions.
On 11/25/2013 08:28 PM, Mattias Tobiasson wrote:
Hi,
The test has been updated after the first review.
The two java files for each test has been merged to a single file.
Updated summary of changes:
1. The real test bug fix is to add flag
Hi Everyone,
Please review an XS fix - missed free() call discovered by cppcheck tool.
http://cr.openjdk.java.net/~dsamersoff/JDK-6969276/webrev.01/
-Dmitry
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me
Hi Everyone,
Please review a day-1 typeo in jsdbproc64.sh
http://cr.openjdk.java.net/~dsamersoff/JDK-7050685/webrev.01/
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
Looks good! (Although we should probably remove these shell scripts sometime).
Thanks,
/Staffan
On 25 nov 2013, at 19:04, Dmitry Samersoff dmitry.samers...@oracle.com wrote:
Hi Everyone,
Please review a day-1 typeo in jsdbproc64.sh
Looks good!
Thanks,
/Staffan
On 25 nov 2013, at 18:49, Dmitry Samersoff dmitry.samers...@oracle.com wrote:
Hi Everyone,
Please review an XS fix - missed free() call discovered by cppcheck tool.
http://cr.openjdk.java.net/~dsamersoff/JDK-6969276/webrev.01/
-Dmitry
--
Dmitry
Changeset: 774c63629870
Author:cl
Date: 2013-11-14 09:05 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/774c63629870
Added tag jdk8-b116 for changeset 0fb1a427fbf6
! .hgtags
Changeset: 1db3d4e4d189
Author:lana
Date: 2013-11-15 07:16 -0800
URL:
Changeset: 64d119680f0a
Author:cl
Date: 2013-11-14 09:05 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/64d119680f0a
Added tag jdk8-b116 for changeset 3c040b04af05
! .hgtags
Changeset: 19de039a03a6
Author:lana
Date: 2013-11-15 07:15 -0800
URL:
Changeset: c1029b02ca87
Author:ihse
Date: 2013-11-08 09:36 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/rev/c1029b02ca87
8027836: Webrev should handle files that has been moved from a directory which
now is removed.
Reviewed-by: mduigou, tbell
! make/scripts/webrev.ksh
Changeset: 7299367c8aa4
Author:cl
Date: 2013-11-14 09:04 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/7299367c8aa4
Added tag jdk8-b116 for changeset 5fdc44652089
! .hgtags
Changeset: e53d1ee4d2ae
Author:lana
Date: 2013-11-14 23:33 -0800
URL:
Changeset: aec3226be72d
Author:cl
Date: 2013-11-14 09:04 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aec3226be72d
Added tag jdk8-b116 for changeset 52b076e6ffae
! .hgtags
Changeset: 20c72bec2707
Author:amurillo
Date: 2013-11-08 07:13 -0800
URL:
Changeset: fe56ba456fd3
Author:cl
Date: 2013-11-14 09:05 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/fe56ba456fd3
Added tag jdk8-b116 for changeset 587560c222a2
! .hgtags
Changeset: 76a598cf50c4
Author:cl
Date: 2013-11-21 09:22 -0800
URL:
Changeset: c1d234d4f164
Author:cl
Date: 2013-11-14 09:05 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/c1d234d4f164
Added tag jdk8-b116 for changeset e757eb9aee3d
! .hgtags
Changeset: e4e5069250e7
Author:cl
Date: 2013-11-21 09:22 -0800
URL:
Changeset: bdcba4854576
Author:erikj
Date: 2013-11-07 10:51 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bdcba4854576
8027698: Platform specific jars are not being signed by the sign-jars target
Reviewed-by: ihse, tbell, wetmore
! makefiles/SignJars.gmk
Changeset:
It looks good.
Checking 'name' instead of 'debug_name' before 'debug_name' is allocated
would be even better.
But it'd be a multi-line fix. :)
Thanks,
Serguei
On 11/25/13 10:04 AM, Dmitry Samersoff wrote:
Hi Everyone,
Please review a day-1 typeo in jsdbproc64.sh
Please, skip it.
My comment belongs to another review request.
I'll re-send it in a separate e-mail.
Thanks,
Serguei
On 11/25/13 11:42 AM, serguei.spit...@oracle.com wrote:
It looks good.
Checking 'name' instead of 'debug_name' before 'debug_name' is
allocated would be even better.
But it'd
It looks good.
Checking 'name' instead of 'debug_name' before 'debug_name' is allocated
would be even better.
But it'd be a multi-line fix. :)
Thanks,
Serguei
On 11/25/13 9:49 AM, Dmitry Samersoff wrote:
Hi Everyone,
Please review an XS fix - missed free() call discovered by cppcheck tool.
It looks good.
Thanks,
Serguei
On 11/25/13 10:04 AM, Dmitry Samersoff wrote:
Hi Everyone,
Please review a day-1 typeo in jsdbproc64.sh
http://cr.openjdk.java.net/~dsamersoff/JDK-7050685/webrev.01/
Agreed.
Thanks,
Serguei
On 11/25/13 11:53 AM, Dmitry Samersoff wrote:
Serguei,
Thank you for the review.
Actually, I don't see a reason to use malloc here - UNIX path is limited
to 1024 bytes so it's possible to just allocate on-stack buffer and use
snprintf to make sure we don't overflow
Hi Volker,
The security changes look fine. I'm not crazy that we now have to
maintain one additional java.security file which is the exact same as
java.security-linux, but this is really an existing issue with
duplicated content across the java.security files which I will try to
fix early in
Changeset: abd44ea60dbe
Author:mfang
Date: 2013-11-21 15:43 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/abd44ea60dbe
8028803: jdk8 l10n resource file translation update 5 - jaxp repo
Reviewed-by: joehw, yhuang
!
Hi Artem,
thanks a lot for your review. Please find my comments inline:
On Monday, November 25, 2013, Artem Ananiev wrote:
Hi, Volker,
just a few very minor comments about the client changes:
1. mlib_sys.c: the change is fine, but it makes the following comment
obsolete.
You're right.
Hi Sean,
thanks a lot for you review.
Please let me know once you start working on 6997010 so I can update the
corresponding AIX file accordingly.
Regards,
Volker
On Monday, November 25, 2013, Sean Mullan wrote:
Hi Volker,
The security changes look fine. I'm not crazy that we now have to
Changeset: 8d5a9245b9ca
Author:valeriep
Date: 2013-11-25 11:56 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d5a9245b9ca
7200306: SunPKCS11 provider delays the check of DSA key size for SHA1withDSA to
sign() instead of init()
Summary: Add key length checks to P11Signature
Hi,
I see you've already received a ton of good feedback on this v2.
I have just a few things to add.
I don't know what symlinks might exist on AIX but it seems odd to
me that you have :-
138 static char *fullAixFontPath[] = {
139 /usr/lpp/X11/lib/X11/fonts/Type1,
..
but the paths in the
Hi Eric,
On 11/24/2013 7:41 PM, Eric Wang wrote:
Hi Mandy All,
Sorry for late!
The webrev below is just finished based on the comments from peers,
please help to review.
http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/
http://cr.openjdk.java.net/%7Eewang/JDK-7067973/webrev.00/
Changeset: 0bf3a58a1783
Author:joehw
Date: 2013-11-25 16:53 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0bf3a58a1783
8027973: javax/xml/jaxp/transform/jdk8004476/XSLTExFuncTest.java hangs (win)
Reviewed-by: alanb, dfuchs, joehw
Contributed-by: patrick.zh...@oracle.com
+
Changeset: a78f51d6bd5e
Author:jjg
Date: 2013-11-25 17:42 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a78f51d6bd5e
8028318: [doclint] doclint will reject existing user-written doc comments using
custom tags that follow the recommended rules
Reviewed-by: darcy
!
Hi Mandy,
1. for L34-40, executing tests with 7 settings is trying to cover more
cases (normal cases and special cases), especially last 3 settings, as
found that the test hung if using vm option
-XX:+ExplicitGCInvokesConcurrent with one of 3 options -XX:+UseG1GC,
-XX:+UseConcMarkSweepGC or
36 matches
Mail list logo
