hg: jdk8/tl/jdk: 8029057: test/java/text/Bidi/Bug6665028.java can fail with OutOfMemoryError

2013-11-26 Thread yuka . kamiya
Changeset: 4d9078b1f25b Author:peytoia Date: 2013-11-26 14:49 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4d9078b1f25b 8029057: test/java/text/Bidi/Bug6665028.java can fail with OutOfMemoryError Reviewed-by: okutsu - test/java/text/Bidi/Bug6665028.java

Re: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

2013-11-26 Thread Volker Simonis
Hi Phil, thanks a lot for the review. Please find my comments inline: On Tue, Nov 26, 2013 at 12:24 AM, Phil Race philip.r...@oracle.com wrote: Hi, I see you've already received a ton of good feedback on this v2. I have just a few things to add. I don't know what symlinks might exist on

hg: jdk8/tl/langtools: 8028428: strictfp allowed as annotation element modifier

2013-11-26 Thread joel . franck
Changeset: 3ea55d523981 Author:jfranck Date: 2013-11-26 13:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ea55d523981 8028428: strictfp allowed as annotation element modifier Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java +

hg: jdk8/tl/langtools: 2 new changesets

2013-11-26 Thread jan . lahoda
Changeset: 8acb838c9b79 Author:jlahoda Date: 2013-11-26 15:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8acb838c9b79 8026374: javac accepts void as a method parameter Summary: Changing Check.validate to reject void types. Reviewed-by: jjg, vromero !

Re: RR(XS): JDK-7050685 jsdbproc64.sh has a typo in the package name

2013-11-26 Thread Krystal Mok
Hi all, I thought this was familiar...I reported the bug back in June 2011 to serviceability-dev, and Dan opened 7050685 for it. http://mail.openjdk.java.net/pipermail/serviceability-dev/2011-May/004056.html Nice to see the fix finally goes in. Thank you. - Kris On Tue, Nov 26, 2013 at 3:47

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

2013-11-26 Thread Volker Simonis
Hi, thanks to everybody for the prompt and helpful reviews. Here comes the final webrev which incorporates all the corrections and suggestions from the second review round: http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/ I've successfully build (and run some smoke tests) with these

Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently

2013-11-26 Thread Mattias Tobiasson
Hi, Thanks for the review. I have summarized the questions and answers: Q: What is the reason of this intermittent failure? A: The test expects the callback ClassFileTransformer.transform() to be called when it loads a new class. That function does not seem to be called when class sharing is

hg: hsx/hotspot-rt/hotspot: 8026065: InterfaceMethodref for invokespecial must name a direct superinterface

2013-11-26 Thread harold . seigel
Changeset: 22eaa15b7960 Author:hseigel Date: 2013-11-26 09:52 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/22eaa15b7960 8026065: InterfaceMethodref for invokespecial must name a direct superinterface Summary: Add verification to check that invokespecial of an

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

2013-11-26 Thread Alan Bateman
On 26/11/2013 16:23, Volker Simonis wrote: Hi, thanks to everybody for the prompt and helpful reviews. Here comes the final webrev which incorporates all the corrections and suggestions from the second review round: http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/ I've successfully

RE: AWT Dev RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

2013-11-26 Thread Iris Clark
Hi. http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/ + src/solaris/classes/java/lang/UNIXProcess.java.aix 2 * Copyright (c) 1995, 2013, Oracle and/or its affiliates. All rights reserved. 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. Oracle copyright in

Re: AWT Dev RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

2013-11-26 Thread Phil Race
Looking only at what you needed to change this time round, all seems fine now. -phil. On 11/26/13 8:23 AM, Volker Simonis wrote: Hi, thanks to everybody for the prompt and helpful reviews. Here comes the final webrev which incorporates all the corrections and suggestions from the second

hg: hsx/hotspot-rt/hotspot: 8028160: [TESTBUG] Exclude failing (runtime) jtreg tests using @ignore

2013-11-26 Thread harold . seigel
Changeset: e567d5afd4dd Author:hseigel Date: 2013-11-26 16:03 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e567d5afd4dd 8028160: [TESTBUG] Exclude failing (runtime) jtreg tests using @ignore Summary: Use @ignore to exclude failing tests Reviewed-by: coleenp,

hg: jdk8/tl/jdk: 8016839: JSR292: AME instead of IAE when calling a method

2013-11-26 Thread vladimir . kozlov
Changeset: e822676cd3cd Author:jrose Date: 2013-11-26 17:16 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e822676cd3cd 8016839: JSR292: AME instead of IAE when calling a method Summary: Catch missing-because-illegal case for itable entries and use an exception-throwing

hg: jdk8/tl/hotspot: 15 new changesets

2013-11-26 Thread lana . steuck
Changeset: 854a42db7069 Author:amurillo Date: 2013-11-15 07:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/854a42db7069 8028444: new hotspot build - hs25-b60 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 570aaefce624 Author:morris Date: 2013-11-18

Review Request (S) 8028126: nsk/jvmti/scenarios/hotswap/HS101/hs101t006 Crashed the vm on Solaris-sparc64 fastdebug builds: only current thread can flush its registers

2013-11-26 Thread serguei.spit...@oracle.com
Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-8028126 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8028126-JVMTI-HS101.1/ Summary: This is a fix for a possible race condition between the VMOp_GetCurrentLocation reaching a safepoint and

hg: jdk8/tl/jdk: 8029181: ts.sh generates invalid file after JDK-8027026

2013-11-26 Thread weijun . wang
Changeset: 1738dfb0c52a Author:weijun Date: 2013-11-27 09:56 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1738dfb0c52a 8029181: ts.sh generates invalid file after JDK-8027026 Reviewed-by: vinnie, mullan ! test/sun/security/tools/jarsigner/TimestampCheck.java

Re: Review quest for JDK-7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently

2013-11-26 Thread Mandy Chung
Hi Eric, I'll defer this to the serviceability team to sponsor it and also get one more review. I don't think you need all 7 @runs. -Xconcgc is equivalent to setting -XX:+UseConcMarkSweepGC. For G1 and CMS, you should use -XX:+ExplicitGCInvokesConcurrent so that System.gc will force a GC