Re: RR(XS): JDK-8002116 This JdbReadTwiceTest.sh gets an exit 1

On 22/01/2014 12:00 AM, Dmitry Samersoff wrote: Missed CR in subject. Sorry! http://cr.openjdk.java.net/~dsamersoff/JDK-8002116/webrev.01/ You already create the file with mkFiles so no need to echo something into it, a simple cat will suffice to see if it is unreadable. Not sure why this w

Re: RFR 6309226: TEST: java/lang/management/ThreadMXBean/SynchronizationStatistics.java didn't check Thread.sleep

Hi Jaroslav, I still see some suspect uses of p.arrive() instead of p.arriveAndAwaitAdvance(). David On 21/01/2014 11:14 PM, Jaroslav Bachorik wrote: Based on the experience while fixing https://bugs.openjdk.java.net/browse/JDK-8032377 I've updated the patch not to require an exact number fo

RFR: 8028391 - Make the Min/MaxHeapFreeRatio flags manageable

Hi, Could I have a few reviews of this change? Summary: To allow applications a more fine grained control over the GC over time, we'll make the flags MinHeapFreeRatio and MaxHeapFreeRatio manageable. The initial request that lead up to this change involved ParallelGC which is notoriously unw

hg: jdk8/tl/jdk: 8 new changesets

Changeset: 9683419eddef Author:lana Date: 2014-01-08 11:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9683419eddef Merge Changeset: 2551e7290450 Author:jeff Date: 2014-01-13 14:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2551e7290450 7129980

hg: jdk8/tl/jaxws: 5 new changesets

Changeset: 241e4effed6d Author:katleman Date: 2014-01-10 08:32 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/241e4effed6d Added tag jdk8-b123 for changeset 91f5c542ccad ! .hgtags Changeset: c71b6b41a2a1 Author:jeff Date: 2014-01-13 14:43 -0800 URL: http://

hg: jdk8/tl/corba: 5 new changesets

Changeset: afecd2878aee Author:katleman Date: 2014-01-10 08:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/afecd2878aee Added tag jdk8-b123 for changeset 1ecd4619f60c ! .hgtags Changeset: b509e2e0fc41 Author:jeff Date: 2014-01-13 14:42 -0800 URL: http://

hg: jdk8/tl/hotspot: 10 new changesets

Changeset: c89630a122b4 Author:katleman Date: 2014-01-10 08:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c89630a122b4 Added tag jdk8-b123 for changeset 591135a7d6f9 ! .hgtags Changeset: f898fdfc08a5 Author:jeff Date: 2014-01-13 14:42 -0800 URL: http:

hg: jdk8/tl/nashorn: 4 new changesets

Changeset: 3356919b1639 Author:jeff Date: 2014-01-13 14:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3356919b1639 7129980: Third Party License Readme update for JDK8 Reviewed-by: lana, tbell ! THIRD_PARTY_README Changeset: aefba9e5e35c Author:lana Date: 20

hg: jdk8/tl/jaxp: 5 new changesets

Changeset: 1a28f773c894 Author:katleman Date: 2014-01-10 08:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/1a28f773c894 Added tag jdk8-b123 for changeset 4e35b5b6d2e5 ! .hgtags Changeset: d906d69e24a3 Author:jeff Date: 2014-01-13 14:43 -0800 URL: http://h

hg: jdk8/tl/langtools: 6 new changesets

Changeset: d5aab8300d3b Author:katleman Date: 2014-01-10 08:32 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d5aab8300d3b Added tag jdk8-b123 for changeset a345cf28faca ! .hgtags Changeset: 4a5e16002234 Author:lana Date: 2014-01-08 11:39 -0800 URL: htt

hg: jdk8/tl: 5 new changesets

Changeset: ca4612164195 Author:lana Date: 2014-01-08 11:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ca4612164195 Merge Changeset: b5e1dad69605 Author:jeff Date: 2014-01-13 14:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b5e1dad69605 7129980: Third

Re: RR(XS): JDK-8002116 This JdbReadTwiceTest.sh gets an exit 1

Staffan, We already skip this test under MS Windows. But I'm OK to make the test fail. PS: This time the test was running as root - this is the reason of failure. -Dmitry On 2014-01-21 18:49, Staffan Larsen wrote: > Should we really be skipping the test if this fail? Isn’t it an > infrastructu

RFR 8031701: java/lang/management/ThreadMXBean/Locks.java: Thread WaitingThread is expected to wait on Object but got null Thread.State = RUNNABLE

Please, review the following test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8031701 Webrev: http://cr.openjdk.java.net/~jbachorik/8031701/webrev.00 The ThreadExecutionSynchronizer was replaced by Phaser - this should give more predictable results. Also, "checkBlockedObject()" failed

Re: RR(XS): JDK-8002116 This JdbReadTwiceTest.sh gets an exit 1

Should we really be skipping the test if this fail? Isn’t it an infrastructure bug if we can’t make the file unreadable? I think the test should fail, but say why it failed: “could not make $HOME/jdb.ini unreadable” and perhaps include the current permissions on the file and directory for debugg

RE: RFR(S): JDK-8032250 : Add trace event for VM flag changes

Looks good. /Markus -Original Message- From: Staffan Larsen Sent: den 21 januari 2014 14:48 To: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net; hotspot-runtime-dev Subject: RFR(S): JDK-8032250 : Add trace event for VM flag changes This is a patch to capture a t

Re: RR(XS): JDK-8002116 This JdbReadTwiceTest.sh gets an exit 1

Missed CR in subject. Sorry! http://cr.openjdk.java.net/~dsamersoff/JDK-8002116/webrev.01/ On 2014-01-21 17:49, Dmitry Samersoff wrote: > Hi Everyone, > > Please review. > > http://cr.openjdk.java.net/~dsamersoff/JDK-8002116/webrev.01/ > > I can't reproduce the issue locally, but suspect, the

RR(XS): This JdbReadTwiceTest.sh gets an exit 1

Hi Everyone, Please review. http://cr.openjdk.java.net/~dsamersoff/JDK-8002116/webrev.01/ I can't reproduce the issue locally, but suspect, the test failed because after chmod a-r the file is sill readable. So check it explicitly before run the test itself. -- Dmitry Samersoff Oracle Java deve

RFR(S): JDK-8032250 : Add trace event for VM flag changes

This is a patch to capture a trace event whenever a manageable VM flag is changed in runtime. webrev: http://cr.openjdk.java.net/~sla/8032250/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8032250 Thanks, /Staffan

Re: RFR 6309226: TEST: java/lang/management/ThreadMXBean/SynchronizationStatistics.java didn't check Thread.sleep

Based on the experience while fixing https://bugs.openjdk.java.net/browse/JDK-8032377 I've updated the patch not to require an exact number for the blocked count - it will pass whenever the reported blocked count is at least large as the the expected number. Webrev: http://cr.openjdk.java.net

RFR(XS) 6545321: jstatLineCounts4.sh has to be resilient to unexpected output

Hi, Could you please review this test fix. The current test is unstable and fails intermittently. The test parses output from jstat. It verifies number of header lines, data lines and total lines. The test sometimes fails because there are unexpected debug output from the jvm, which means that t

Re: RFR 8032377: test/java/lang/management/ThreadMXBean/ThreadBlockedCount.java still fails intermittently

I've seen this fail once since the original changes and also agree with the proposed change. -Alan. On 21/01/2014 11:57, David Holmes wrote: Ok. Thanks, David On 21/01/2014 9:31 PM, Jaroslav Bachorik wrote: Please, review the following test fix. Issue : https://bugs.openjdk.java.net/bro

Re: RFR 8032377: test/java/lang/management/ThreadMXBean/ThreadBlockedCount.java still fails intermittently

Ok. Thanks, David On 21/01/2014 9:31 PM, Jaroslav Bachorik wrote: Please, review the following test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8032377 Webrev: http://cr.openjdk.java.net/~jbachorik/8032377/webrev.00 test/java/lang/management/ThreadMXBean/ThreadBlockedCount.java stil

RFR 8032377: test/java/lang/management/ThreadMXBean/ThreadBlockedCount.java still fails intermittently

Please, review the following test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8032377 Webrev: http://cr.openjdk.java.net/~jbachorik/8032377/webrev.00 test/java/lang/management/ThreadMXBean/ThreadBlockedCount.java still fails intermittently due to locking happening at the class loading

Re: Review request for 7195249: Some jtreg tests use hard coded ports

Hi Taras, On 21.1.2014 10:30, taras ledkov wrote: Hi Jaroslav, Could you please review the last changes? Are you OK? Yes, the change looks ok. But I think we will need to get back to this problem eventually and implement a central port dispatcher if we want to be 100% sure the port conflict

Re: RR(S): JDK-8022323 [JavaSecurityScanner] review package com.sun.management.* Native methods should be private

Looks good! Thanks, /Staffan On 21 jan 2014, at 10:25, Dmitry Samersoff wrote: > Staffan, > > Updated webrev with mapfile-vers changes. > > http://cr.openjdk.java.net/~dsamersoff/JDK-8022323/webrev.02/ > > -Dmitry > > On 2014-01-21 11:46, Staffan Larsen wrote: >> Looks good, but you also ne

Re: Review request for 7195249: Some jtreg tests use hard coded ports

Hi Jaroslav, Could you please review the last changes? Are you OK? On 20.01.2014 19:21, Staffan Larsen wrote: Sorry for not replying earlier. Yes, I’m ok with these changes. Thanks, /Staffan On 20 jan 2014, at 16:07, taras ledkov wrote: Hi Staffan, I fixed the tests according with your co

Re: RR(S): JDK-8022323 [JavaSecurityScanner] review package com.sun.management.* Native methods should be private

Staffan, Updated webrev with mapfile-vers changes. http://cr.openjdk.java.net/~dsamersoff/JDK-8022323/webrev.02/ -Dmitry On 2014-01-21 11:46, Staffan Larsen wrote: > Looks good, but you also need to update > jdk/make/mapfiles/libmanagement/mapfile-vers. > > /Staffan > > On 20 jan 2014, at 20

Re: RFR 8019389: SA-JDI JSR292: sun.jvm.hotspot.jdi.StackFrame.thisObject() throws sun.jvm.hotspot.utilities.AssertionFailure: sanity check

Please find the new webrev with copyright date fixed (changed to 2014). Webrev: http://cr.openjdk.java.net/~olagneau/8019389/webrev.01/ Olivier. Olivier Lagneau said on date 1/20/2014 5:50 PM: Oops, right ! Will fix that. Olivier

Re: jmx-dev [ping] Re: RFR 8022221: Intermittent test failures in sun/management/jmxremote/startstop/JMXStartStopTest.sh

On 21.1.2014 08:59, Staffan Larsen wrote: Looks good! And very sorry for letting this slip. Thanks Staffan. NP! I guess I can leave the Utils in the patch for 8031559 :) -JB- Thanks, /Staffan On 14 jan 2014, at 14:13, Jaroslav Bachorik wrote: Thanks, Staffan! On 14.1.2014 13:13, St

Re: jmx-dev [ping] Re: RFR 8022221: Intermittent test failures in sun/management/jmxremote/startstop/JMXStartStopTest.sh

Looks good! And very sorry for letting this slip. Thanks, /Staffan On 14 jan 2014, at 14:13, Jaroslav Bachorik wrote: > Thanks, Staffan! > > On 14.1.2014 13:13, Staffan Larsen wrote: >> JMXStartStopTest.java:162 >> I see no path that calls testConnect with port == -1, so can we we remove >>