Re: JDK-7090324: gclog rotation via external tool

Hi Erik, Staffan, I've uploaded new webrev. Could you review this ? http://cr.openjdk.java.net/~ysuenaga/JDK-7090324/webrev.02/ This patch includes fixes from comments of Staffan and Erik. And I created new test of this patch as Test7090324 . This test works fine with jtreg. Thanks, Yasumasa

Re: RFR 6656031: SA: jmap -permstat number of classes is off by 1

Looks good to me. Makes sense to only count classes defined by the loader. David On 30/01/2014 7:21 AM, Jaroslav Bachorik wrote: Could I have a second HS reviewer for this, please? -JB- On 17.12.2013 14:34, Jaroslav Bachorik wrote: Thanks! I guess I will be needing a second reviewer since th

Re: RFR: 8028391 - Make the Min/MaxHeapFreeRatio flags manageable

Thanks for the review Bengt! The RFE is filed here: https://bugs.openjdk.java.net/browse/JDK-8033206 /Jesper Bengt Rutisson skrev 29/1/14 10:09 PM: Hi everyone, I just talked this through with Jesper. I'm fine with the latest webrev. To size the young gen the code relies on that an old GC has

Re: RFR: 8028391 - Make the Min/MaxHeapFreeRatio flags manageable

Hi Bernd, This change did not introduce setting the MinHeapFreeRatio to 99, I just moved it to a different place in the code. Currently it is allowed to set Min = Max. I can't say I have given this enough thought to determine if that is good or bad. Anyhow, changing that would affect all col

Re: RFR 6656031: SA: jmap -permstat number of classes is off by 1

Could I have a second HS reviewer for this, please? -JB- On 17.12.2013 14:34, Jaroslav Bachorik wrote: Thanks! I guess I will be needing a second reviewer since the change is in the hotspot repo. -JB- On 17.12.2013 14:32, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 17 dec 2013, a

Re: RFR: 8028391 - Make the Min/MaxHeapFreeRatio flags manageable

Hi everyone, I just talked this through with Jesper. I'm fine with the latest webrev. To size the young gen the code relies on that an old GC has happened. Currently there is nothing that guarantees this, so the implementation kind of relies on the application to call System.gc() to get the

Re: RFR: 8028391 - Make the Min/MaxHeapFreeRatio flags manageable

Hi Bengt, Just a short clarification inline. Looking forward to your comments later today. Bengt Rutisson skrev 29/1/14 4:41 PM: Hi Jesper, On 1/28/14 11:09 PM, Jesper Wilhelmsson wrote: Bengt, Thanks for looking at the change. Answers inline. Bengt Rutisson skrev 28/1/14 2:02 PM: Hi Jes

Re: JDK-7090324: gclog rotation via external tool

Hi Erik, On 2014/01/30 0:13, Erik Helin wrote: Hi Yasumasa, (have to use HTML email to get a width of more than 78 chars, sorry) why did you change the code in arguments.cpp in the method check_gc_log_consistency? In current implementation, check_gclog_consistency() checks three parameters:

Re: RFR 8031701: java/lang/management/ThreadMXBean/Locks.java: Thread WaitingThread is expected to wait on Object but got null Thread.State = RUNNABLE

On 1/29/2014 6:54 AM, Jaroslav Bachorik wrote: Hi Mandy, On 29.1.2014 00:50, Mandy Chung wrote: The change looks okay. I like the new assertNoLock method and as you indicate in the comment in L54-55 that the thread state is dummy and not verified, would it worth refactor checkBlockedObject?

Re: RFR: 8028391 - Make the Min/MaxHeapFreeRatio flags manageable

Hi Jesper, On 1/28/14 11:09 PM, Jesper Wilhelmsson wrote: Bengt, Thanks for looking at the change. Answers inline. Bengt Rutisson skrev 28/1/14 2:02 PM: Hi Jesper, On 2014-01-27 21:46, Jesper Wilhelmsson wrote: Staffan, Bengt, Mikael, Thanks for the reviews! I have made the changes you

RFR(S) 6545422: NativeErrors.java uses wrong path name in exec

Hi, Could you please review this test fix. Problems with the current version: It sometimes fails to find the correct executable for "native2ascii". It throws NullPointerExceptions from multiple locations without logs. Probably because it checks null values with "assert", which may not be enabled.

Re: JDK-7090324: gclog rotation via external tool

Hi Yasumasa, (have to use HTML email to get a width of more than 78 chars, sorry) why did you change the code in arguments.cpp in the method check_gc_log_consistency? Next, the gcLogFileStream::rotate_log method now does a lot of things. Could you separate out the first block into a new meth

Re: RFR: 8028391 - Make the Min/MaxHeapFreeRatio flags manageable

Thanks for the review Mikael! /Jesper Mikael Gerdin skrev 29/1/14 3:48 PM: Hi Jesper, On Monday 27 January 2014 21.46.01 Jesper Wilhelmsson wrote: Staffan, Bengt, Mikael, Thanks for the reviews! I have made the changes you have suggested and a new webrev is available at: http://cr.openjdk.j

Re: RFR 8031701: java/lang/management/ThreadMXBean/Locks.java: Thread WaitingThread is expected to wait on Object but got null Thread.State = RUNNABLE

Hi Mandy, On 29.1.2014 00:50, Mandy Chung wrote: Hi Jaroslav, On 1/21/14 7:50 AM, Jaroslav Bachorik wrote: Please, review the following test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8031701 Webrev: http://cr.openjdk.java.net/~jbachorik/8031701/webrev.00 The change looks okay.

Re: RFR: 8028391 - Make the Min/MaxHeapFreeRatio flags manageable

Hi Jesper, On Monday 27 January 2014 21.46.01 Jesper Wilhelmsson wrote: > Staffan, Bengt, Mikael, > > Thanks for the reviews! > > I have made the changes you have suggested and a new webrev is available at: > > http://cr.openjdk.java.net/~jwilhelm/8028391/webrev.5/ > > I agree with your assess

Re: JDK-7090324: gclog rotation via external tool

Hi Staffan, Thank you for reviewing! I've uploaded new webrev. http://cr.openjdk.java.net/~ysuenaga/JDK-7090324/webrev.01/ On 2014/01/29 20:56, Staffan Larsen wrote: Yasumasa, src/share/vm/runtime/arguments.cpp no comments src/share/vm/runtime/safepoint.cpp I was surprised that gc log size wa

Need Second Reviewer Re: RR(S): JDK-7127191 SA JSDB does not display native symbols correctly for transported Linux cores

Hi Everyone, Please review the fix. http://cr.openjdk.java.net/~dsamersoff/JDK-7127191/webrev.02/ -Dmitry On 2014-01-20 20:00, Dmitry Samersoff wrote: > Hi Everyone, > > Please review the fix. > > http://cr.openjdk.java.net/~dsamersoff/JDK-7127191/webrev.01/ > > This fix doesn't solve all pr

Re: JDK-7090324: gclog rotation via external tool

Yasumasa, src/share/vm/runtime/arguments.cpp no comments src/share/vm/runtime/safepoint.cpp I was surprised that gc log size was checked after each safe point. That seems an uneccssary burden to place on a safe point. Instead we should switch to a periodic task that checks the gc log size. Howe

Re: [PATCH] 7142035 assert in j.l.instrument agents during shutdown when daemon thread is running

The patch has been pushed: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/87fdc579dafc Thanks for contributing! /Staffan On 28 jan 2014, at 15:59, Chan, Sunny wrote: > Hi Staffan, > > I agreed with your assessment and have incorporated your extra change into my > patch. I have a couple of tes

Re: RFR(M): 8032462 Change the linux SDT implementation to use USDT2 instead of USDT1

Ok, thanks! It is Ok that you did not clean this up. The macro can still be used in the future. Thanks, Serguei On 1/29/14 12:28 AM, Staffan Larsen wrote: On 29 jan 2014, at 02:03, serguei.spit...@oracle.com wrote: Hi Staffan, Sorry for being late, I th

Re: RFR(M): 8032462 Change the linux SDT implementation to use USDT2 instead of USDT1

On 29 jan 2014, at 02:03, serguei.spit...@oracle.com wrote: > Hi Staffan, > > Sorry for being late, I thought it was already reviewed. :) > > It looks good, just a minor question below. Thanks! > make/bsd/makefiles/dtrace.make > > Can this line be removed as it is not used in this file anymo