Re: RFR 6835233 : Fedora 9 jdk regression test failed: java/lang/instrument/ParallelTransformerLoader.sh

2014-02-26 Thread Alan Bateman
On 26/02/2014 19:34, Brent Christian wrote: : The change is: # @bug 5088398 -# @ignore until bug 6835233 dealt with # @summary Test parallel class loading by parallel transformers. This looks okay to me too, I assume that if there is any residual issue that it will show up quickly once the t

Re: RFR 6835233 : Fedora 9 jdk regression test failed: java/lang/instrument/ParallelTransformerLoader.sh

2014-02-26 Thread Staffan Larsen
Looks good! Thanks, /Staffan On 26 feb 2014, at 20:34, Brent Christian wrote: > File under "chipping away at test stabilization issues." > > https://bugs.openjdk.java.net/browse/JDK-6835233 > > I've done some repeated runs of this test on my Linux machine. The test > fails every time with 6

hg: jdk8/tl/corba: 8035618: Four api/org_omg/CORBA TCK tests fail under plugin only

2014-02-26 Thread sean . coffey
Changeset: 0683ee308085 Author:coffeys Date: 2014-02-26 23:04 + URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0683ee308085 8035618: Four api/org_omg/CORBA TCK tests fail under plugin only Reviewed-by: mchung, chegar ! src/share/classes/com/sun/corba/se/spi/orb/ORB.java

RFR 6835233 : Fedora 9 jdk regression test failed: java/lang/instrument/ParallelTransformerLoader.sh

2014-02-26 Thread Brent Christian
File under "chipping away at test stabilization issues." https://bugs.openjdk.java.net/browse/JDK-6835233 I've done some repeated runs of this test on my Linux machine. The test fails every time with 6u3. It fails intermittently on 7 (after 145 iterations for 7u45, and 62 iterations for 7u60

Re: Review request for 7195249: Some jtreg tests use hard coded ports

2014-02-26 Thread Staffan Larsen
On 26 feb 2014, at 15:24, taras ledkov wrote: > Hi, > > Alan, Mandy could you please review the fix: > https://bugs.openjdk.java.net/browse/JDK-7195249. > > I had the discussion with Jaroslav and Staffan and they have approved my fix, > but they are not reviewers. I am a Reviewer. Thanks,

Re: RFR: 8035150 ShouldNotReachHere() in ConstantPool::copy_entry_to

2014-02-26 Thread Staffan Larsen
Thanks Dan and Markus! On 26 feb 2014, at 15:28, Daniel D. Daugherty wrote: > On 2/26/14 7:15 AM, Staffan Larsen wrote: >> >> On 26 feb 2014, at 15:03, Daniel D. Daugherty >> wrote: >> >>> On 2/26/14 1:31 AM, Staffan Larsen wrote: On 26 feb 2014, at 01:48, Daniel D. Daugherty wr

Re: RFR: 8035150 ShouldNotReachHere() in ConstantPool::copy_entry_to

2014-02-26 Thread Daniel D. Daugherty
On 2/26/14 7:15 AM, Staffan Larsen wrote: On 26 feb 2014, at 15:03, Daniel D. Daugherty mailto:daniel.daughe...@oracle.com>> wrote: On 2/26/14 1:31 AM, Staffan Larsen wrote: On 26 feb 2014, at 01:48, Daniel D. Daugherty mailto:daniel.daughe...@oracle.com>> wrote: I concur with Markus. P

Re: Review request for 7195249: Some jtreg tests use hard coded ports

2014-02-26 Thread taras ledkov
Hi, Alan, Mandy could you please review the fix: https://bugs.openjdk.java.net/browse/JDK-7195249. I had the discussion with Jaroslav and Staffan and they have approved my fix, but they are not reviewers. Webrev for jdk part: http://cr.openjdk.java.net/~anazarov/7195249/jdk/webrev.04/ Webr

Re: RFR: 8035150 ShouldNotReachHere() in ConstantPool::copy_entry_to

2014-02-26 Thread Staffan Larsen
On 26 feb 2014, at 15:03, Daniel D. Daugherty wrote: > On 2/26/14 1:31 AM, Staffan Larsen wrote: >> On 26 feb 2014, at 01:48, Daniel D. Daugherty >> wrote: >> >>> I concur with Markus. Pairing JVM_CONSTANT_UnresolvedClassInError with >>> JVM_CONSTANT_UnresolvedClass in the ConstantPool::copy

Re: RFR: 8035150 ShouldNotReachHere() in ConstantPool::copy_entry_to

2014-02-26 Thread Daniel D. Daugherty
On 2/26/14 1:31 AM, Staffan Larsen wrote: On 26 feb 2014, at 01:48, Daniel D. Daugherty wrote: I concur with Markus. Pairing JVM_CONSTANT_UnresolvedClassInError with JVM_CONSTANT_UnresolvedClass in the ConstantPool::copy_entry_to() switch looks like the right thing to do. Good - thanks. Th

Re: RFR: 8035150 ShouldNotReachHere() in ConstantPool::copy_entry_to

2014-02-26 Thread Staffan Larsen
On 26 feb 2014, at 01:48, Daniel D. Daugherty wrote: > I concur with Markus. Pairing JVM_CONSTANT_UnresolvedClassInError with > JVM_CONSTANT_UnresolvedClass in the ConstantPool::copy_entry_to() > switch looks like the right thing to do. Good - thanks. > > The usual questions: > > - why wasn