Re: Need comments on JEP-158: Unified JVM Logging

2014-05-30 Thread Thomas Stüfe
Hi all, I like you proposal and hope this tracing system turns out well. I'm with the SAP JVM; we have had our own homebrewn tracing system for years, which resembles your proposal a lot. If your solution turns out well, we may decide to abandon our propietary solution in favor of your proposal.

Re: Need comments on JEP-158: Unified JVM Logging

2014-05-30 Thread Fredrik Arvidsson
Hi Mario, thanks for the feedback! Pleas see my comments in-lined below. On 2014-05-16 13:41, Mario Torre wrote: On Fri, 2014-05-16 at 11:45 +0100, Richard Warburton wrote: Hi, Hi all, I share this same doubts, and I'm also a bit confused. I'm not saying that an abstract framework should de

Re: RFR 80044461: Cleanup new Boolean and single character strings

2014-05-30 Thread Alan Bateman
On 30/05/2014 19:30, roger riggs wrote: A quick sanity check please for these cleanup changes to remove uses of new Boolean and using chars instead of single character strings contributed by Otávio Gonçalves de Santana. These changes update multiple classes in the jdk9-dev repo (except clien

Re: RFR 80044461: Cleanup new Boolean and single character strings

2014-05-30 Thread Lance Andersen
Looks fine On May 30, 2014, at 2:30 PM, roger riggs wrote: > A quick sanity check please for these cleanup changes to remove uses of > new Boolean and using chars instead of single character strings contributed > by Otávio Gonçalves de Santana. > > These changes update multiple classes in th

RFR 80044461: Cleanup new Boolean and single character strings

2014-05-30 Thread roger riggs
A quick sanity check please for these cleanup changes to remove uses of new Boolean and using chars instead of single character strings contributed by Otávio Gonçalves de Santana. These changes update multiple classes in the jdk9-dev repo (except client packages). webrev: http://cr.openjdk.ja

Re: RFR: 8044418 Add com/sun/jdi/JdbReadTwiceTest.sh to ProblemList.txt

2014-05-30 Thread Staffan Larsen
Thanks ! On 30 maj 2014, at 15:04, Peter Allwin wrote: > Looks good to me, > > /peter > > On 30 May 2014, at 14:52, Alan Bateman wrote: > >> On 30/05/2014 13:50, Staffan Larsen wrote: >>> This test has problem running under root. Please review the following >>> update to ProblemList.txt >>>

Re: RFR: 8044398 Attach code should propagate errors in Diagnostic Commands as errors

2014-05-30 Thread Staffan Larsen
Thanks Dan! On 30 maj 2014, at 15:26, Daniel D. Daugherty wrote: > > webrev: http://cr.openjdk.java.net/~sla/8044398/webrev.00/ > > src/share/vm/services/attachListener.cpp >No comment. > > Thumbs up! > > Dan > > > On 5/30/14 12:51 AM, Staffan Larsen wrote: >> The code in attachListene

Re: RFR: 8044398 Attach code should propagate errors in Diagnostic Commands as errors

2014-05-30 Thread Daniel D. Daugherty
> webrev: http://cr.openjdk.java.net/~sla/8044398/webrev.00/ src/share/vm/services/attachListener.cpp No comment. Thumbs up! Dan On 5/30/14 12:51 AM, Staffan Larsen wrote: The code in attachListener.cpp does this: DCmd::parse_and_execute(DCmd_Source_AttachAPI, out, op->arg(0), ' ', T

Re: RFR: 8044418 Add com/sun/jdi/JdbReadTwiceTest.sh to ProblemList.txt

2014-05-30 Thread Peter Allwin
Looks good to me, /peter On 30 May 2014, at 14:52, Alan Bateman wrote: > On 30/05/2014 13:50, Staffan Larsen wrote: >> This test has problem running under root. Please review the following update >> to ProblemList.txt >> >> Thanks, >> /Staffan >> >> > Then don't run it under root :-) > > T

Re: RFR: 8044418 Add com/sun/jdi/JdbReadTwiceTest.sh to ProblemList.txt

2014-05-30 Thread Alan Bateman
On 30/05/2014 13:50, Staffan Larsen wrote: This test has problem running under root. Please review the following update to ProblemList.txt Thanks, /Staffan Then don't run it under root :-) The change looks fine, pending resolution of the issue. -Alan.

RFR: 8044418 Add com/sun/jdi/JdbReadTwiceTest.sh to ProblemList.txt

2014-05-30 Thread Staffan Larsen
This test has problem running under root. Please review the following update to ProblemList.txt Thanks, /Staffan diff --git a/test/ProblemList.txt b/test/ProblemList.txt --- a/test/ProblemList.txt +++ b/test/ProblemList.txt @@ -261,6 +261,10 @@ # 8041934 com/sun/jdi/RepStep.java

Re: RFR(S): 8043915: Tests get ClassNotFoundException: com.oracle.java.testlibrary.StreamPumper

2014-05-30 Thread Peter Allwin
Hi Katja, Is it necessary to @build classes used in @run statements? I see you added it to some but GetObjectSizeOverflow.java is missing ClassFileInstaller. Other than that it looks good! Thanks, /peter On 28 May 2014, at 13:58, Yekaterina Kantserova wrote: > Hi, > > Could I please have

Re: RFR(S): 8043915: Tests get ClassNotFoundException: com.oracle.java.testlibrary.StreamPumper

2014-05-30 Thread Staffan Larsen
Looks good! Thanks, /Staffan On 28 maj 2014, at 13:58, Yekaterina Kantserova wrote: > Hi, > > Could I please have a review of this fix. > > webrev: http://cr.openjdk.java.net/~ykantser/8043915/webrev.00/ > bug: https://bugs.openjdk.java.net/browse/JDK-8043915 > > When using @library in a JT

Re: RFR: 8044398 Attach code should propagate errors in Diagnostic Commands as errors

2014-05-30 Thread Staffan Larsen
Thanks, Markus! On 30 maj 2014, at 09:26, Markus Grönlund wrote: > Looks good. > > /Markus > > -Original Message- > From: Staffan Larsen > Sent: den 30 maj 2014 08:51 > To: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net; > hotspot-runtime-dev > Subject: RFR:

RE: RFR: 8044398 Attach code should propagate errors in Diagnostic Commands as errors

2014-05-30 Thread Markus Grönlund
Looks good. /Markus -Original Message- From: Staffan Larsen Sent: den 30 maj 2014 08:51 To: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net; hotspot-runtime-dev Subject: RFR: 8044398 Attach code should propagate errors in Diagnostic Commands as errors The code