Re: RFR [8055338]: (process) Add instrumentation to help diagnose JDK-6573254

2014-08-18 Thread Ivan Gerasimov
Thanks Kelly and David! On 19.08.2014 6:14, David Holmes wrote: On 19/08/2014 9:04 AM, Kelly O'Hair wrote: 454 if (vm_getting_terminated && thread->is_Java_thread()) { 455 JavaThread* java_thread = (JavaThread*)thread; 456 if (java_thread && java_lang_Thread::is_daemon(java_thr

Re: RFR [8055338]: (process) Add instrumentation to help diagnose JDK-6573254

2014-08-18 Thread David Holmes
On 19/08/2014 10:12 AM, Ioi Lam wrote: With the Windows/x86/x64 memory model, is the write to vm_getting_terminated guaranteed to be observable by java_start()? In the general case, not immediately. For the threads actually of interest the logic that tells the threads to terminate happens afte

Re: RFR [8055338]: (process) Add instrumentation to help diagnose JDK-6573254

2014-08-18 Thread David Holmes
On 19/08/2014 9:04 AM, Kelly O'Hair wrote: 454 if (vm_getting_terminated && thread->is_Java_thread()) { 455 JavaThread* java_thread = (JavaThread*)thread; 456 if (java_thread && java_lang_Thread::is_daemon(java_thread->threadObj())) { 457 return 70115; 458 } Seems

Re: RFR [8055338]: (process) Add instrumentation to help diagnose JDK-6573254

2014-08-18 Thread Ioi Lam
With the Windows/x86/x64 memory model, is the write to vm_getting_terminated guaranteed to be observable by java_start()? - Ioi On 8/18/14, 2:19 PM, Ivan Gerasimov wrote: Hello! This is a request to temporarily add some instrumentation code to hotspot to help diagnose the intermittent failur

Re: RFR [8055338]: (process) Add instrumentation to help diagnose JDK-6573254

2014-08-18 Thread Kelly O'Hair
454 if (vm_getting_terminated && thread->is_Java_thread()) { 455 JavaThread* java_thread = (JavaThread*)thread; 456 if (java_thread && java_lang_Thread::is_daemon(java_thread->threadObj())) { 457 return 70115; 458 } Seems like the check for java_thread being null on line

Re: RFR [8055338]: (process) Add instrumentation to help diagnose JDK-6573254

2014-08-18 Thread Daniel D. Daugherty
On 8/18/14 3:19 PM, Ivan Gerasimov wrote: Hello! This is a request to temporarily add some instrumentation code to hotspot to help diagnose the intermittent failure on Windows, which results in a wrong exit code of (sub-)process. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8055338 WEBR

RFR [8055338]: (process) Add instrumentation to help diagnose JDK-6573254

2014-08-18 Thread Ivan Gerasimov
Hello! This is a request to temporarily add some instrumentation code to hotspot to help diagnose the intermittent failure on Windows, which results in a wrong exit code of (sub-)process. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8055338 WEBREV: http://cr.openjdk.java.net/~igerasim/805

Re: 8055111: [TESTBUG] jdk.testlibrary.Utils.removeGcOpts doesn't remove -Xconcgc

2014-08-18 Thread Bengt Rutisson
Hi Stefan, On 2014-08-18 13:43, Stefan Karlsson wrote: Jon suggested that I should add -Xincgc. Here's the updated webrev: http://cr.openjdk.java.net/~stefank/8055111/webrev.01/ Looks good. Thanks, Bengt thanks, StefanK On 2014-08-14 14:04, Stefan Karlsson wrote: Hi all, Please, revie

Re: 8055111: [TESTBUG] jdk.testlibrary.Utils.removeGcOpts doesn't remove -Xconcgc

2014-08-18 Thread Stefan Karlsson
Jon suggested that I should add -Xincgc. Here's the updated webrev: http://cr.openjdk.java.net/~stefank/8055111/webrev.01/ thanks, StefanK On 2014-08-14 14:04, Stefan Karlsson wrote: Hi all, Please, review this patch to add -Xconcgc to the set of flags to be filtered out by Utils.removeGcOpt

Re: RFR(XS): 8055012 - [TESTBUG] NMTHelper fails to parse NMT output

2014-08-18 Thread olivier.lagn...@oracle.com
Hi Christian, Looks good ! Olivier. On 15/08/2014 16:55, Christian Tornqvist wrote: Hi, This is a small update to NMTHelper.java to make it work with recent changes in the NMT implementation that changed the output format a bit. I’ve tested the change locally using java\lang\instrument\Re