Looks good for me.
On 2014-09-10 07:36, Yasumasa Suenaga wrote:
> Hi Dmitry,
>
> Okay, I've uploaded new webrev for JDK-8057556:
> http://cr.openjdk.java.net/~ysuenaga/JDK-8057556/webrev.2/
>
> This change fixes a comment from Jarosalv as below:
> L103 Please, move "else" to the previous li
Ok, Reviewed.
-JB-
On 09/10/2014 05:36 AM, Yasumasa Suenaga wrote:
Hi Dmitry,
Okay, I've uploaded new webrev for JDK-8057556:
http://cr.openjdk.java.net/~ysuenaga/JDK-8057556/webrev.2/
This change fixes a comment from Jarosalv as below:
L103 Please, move "else" to the previous line
Could y
Hi Dmitry,
Okay, I've uploaded new webrev for JDK-8057556:
http://cr.openjdk.java.net/~ysuenaga/JDK-8057556/webrev.2/
This change fixes a comment from Jarosalv as below:
L103 Please, move "else" to the previous line
Could you review it again?
Thanks,
Yasumasa
(2014/09/10 6:40), Dmitry Sa
Yasumasa,
To allow multiple application to use the same *multicast* address:port
you probably just need to move
channel.setOption(StandardSocketOptions.SO_REUSEADDR, true);
before bind.
As for bind call lets leave this question out of scope of these two
fixes. Different OS'es behave different
On 2014-09-09 16:19, Jaroslav Bachorik wrote:
Thumbs up!
Thanks.
StefanK
-JB-
On 09/09/2014 02:29 PM, Stefan Karlsson wrote:
Hi Jaroslav,
Thanks a lot for looking at the test change.
On 2014-09-09 14:04, Jaroslav Bachorik wrote:
Hi Stefan,
* test/java/lang/management/MemoryMXBean/LowM
Thumbs up!
-JB-
On 09/09/2014 02:29 PM, Stefan Karlsson wrote:
Hi Jaroslav,
Thanks a lot for looking at the test change.
On 2014-09-09 14:04, Jaroslav Bachorik wrote:
Hi Stefan,
* test/java/lang/management/MemoryMXBean/LowMemoryTest.java
L71 - `g1Flag` is not used anywhere; should it be rem
On 2014-09-09 14:49, Daniel Fuchs wrote:
Hi,
Looks good to me - although I'm not a specialist of -XX options ;-)
:)
Thanks, Daniel.
StefanK
-- daniel
On 9/9/14 2:29 PM, Stefan Karlsson wrote:
Hi Jaroslav,
Thanks a lot for looking at the test change.
On 2014-09-09 14:04, Jaroslav Bacho
Hi Jesper,
On 2014-09-09 15:08, Jesper Wilhelmsson wrote:
Hi Stefan,
g1Flag is only used in one place. In my opinion it doesn't add any
value having it as a variable rather than just putting the flag
directly where it is used (keeping the comment of course):
RunUtil.runTestClearGcOpts(main,
Hi Stefan,
g1Flag is only used in one place. In my opinion it doesn't add any value having
it as a variable rather than just putting the flag directly where it is used
(keeping the comment of course):
RunUtil.runTestClearGcOpts(main, nmFlag, lpFlag, "-XX:+UseSerialGC");
RunUtil.runTestClearGc
Hi,
Looks good to me - although I'm not a specialist of -XX options ;-)
-- daniel
On 9/9/14 2:29 PM, Stefan Karlsson wrote:
Hi Jaroslav,
Thanks a lot for looking at the test change.
On 2014-09-09 14:04, Jaroslav Bachorik wrote:
Hi Stefan,
* test/java/lang/management/MemoryMXBean/LowMemoryT
Hi Jaroslav,
Thanks a lot for looking at the test change.
On 2014-09-09 14:04, Jaroslav Bachorik wrote:
Hi Stefan,
* test/java/lang/management/MemoryMXBean/LowMemoryTest.java
L71 - `g1Flag` is not used anywhere; should it be removed?
It should be used. I've updated the patch:
http://cr.openj
Hi Stefan,
* test/java/lang/management/MemoryMXBean/LowMemoryTest.java
L71 - `g1Flag` is not used anywhere; should it be removed?
Other than that the change looks fine.
-JB-
On 09/09/2014 01:45 PM, Stefan Karlsson wrote:
(Adding GC)
Hi,
Could I get a couple of reviews for this test fix?
St
(Adding GC)
Hi,
Could I get a couple of reviews for this test fix?
StefanK
On 2014-09-05 14:01, Stefan Karlsson wrote:
Hi all,
Here's an updated version of the test:
http://cr.openjdk.java.net/~stefank/8057174/webrev.01.delta/
http://cr.openjdk.java.net/~stefank/8057174/webrev.01/
1) The ma
13 matches
Mail list logo
