Re: RFR 8068233: java/lang/management/ThreadMXBean/ThreadMXBeanStateTest.java is still in exclude list

2014-12-29 Thread serguei.spit...@oracle.com
Reviewed. Thanks, Serguei On 12/29/14 3:04 AM, Jaroslav Bachorik wrote: Please, review this simple ProblemList.txt update Issue : https://bugs.openjdk.java.net/browse/JDK-8068233 Webrev: http://cr.openjdk.java.net/~jbachorik/8068233/webrev.00 Part of the fix for JDK-8058506 was lost after inc

Review request JDK-8068242: quarantine the test IsModifiableClassAgent.java until JDK-8068162 is resolved

2014-12-29 Thread Alexander Kulyakhtin
Hi, Could I, please, have a review of this fix. This is a oneline change to quarantine a test until JDK-8068162 is resolved bug: https://bugs.openjdk.java.net/browse/JDK-8068242 webrev: http://cr.openjdk.java.net/~eistepan/~akulyakhtin/8068242/webrev.00/ @ignore JDK-8068162 added to the test to

Re: Review request JDK-8068242: quarantine the test IsModifiableClassAgent.java until JDK-8068162 is resolved

2014-12-29 Thread Alexander Kulyakhtin
Hi, Could someone, please, push the fix reviewed below? This is just one-line change to quarantine a test while the fix is being worked on. bug: https://bugs.openjdk.java.net/browse/JDK-8068242 webrev: http://cr.openjdk.java.net/~eistepan/~akulyakhtin/8068242/webrev.00 / Thank you very mu

Re: Review request JDK-8068242: quarantine the test IsModifiableClassAgent.java until JDK-8068162 is resolved

2014-12-29 Thread Alexander Kulyakhtin
Alan, Thank you very much for the information. I'm going to remove the @ignore annotation from the JDK-8068242 test as soon as it's fixed, and will be using the ProblemList.txt for any future quarantine requests. Best regards, Alexander - Original Message - From: alan.bate...@oracle

RFR: 8028357: Unnecessary allocation in AliasFileParser

2014-12-29 Thread Claes Redestad
Hi, some classes in jvmstat/perfdata code contains debug logging code predating the logging APIs, which provokes some unnecessary allocation in certain applications. Since the debug logging can't have been used for quite some time, I propose to remove it altogether rather than converting it

Re: RFR 8068233: java/lang/management/ThreadMXBean/ThreadMXBeanStateTest.java is still in exclude list

2014-12-29 Thread Chris Hegarty
> On 29 Dec 2014, at 11:04, Jaroslav Bachorik > wrote: > > Please, review this simple ProblemList.txt update > > Issue : https://bugs.openjdk.java.net/browse/JDK-8068233 > Webrev: http://cr.openjdk.java.net/~jbachorik/8068233/webrev.00 > > Part of the fix for JDK-8058506 was lost after incorr

RFR 8068233: java/lang/management/ThreadMXBean/ThreadMXBeanStateTest.java is still in exclude list

2014-12-29 Thread Jaroslav Bachorik
Please, review this simple ProblemList.txt update Issue : https://bugs.openjdk.java.net/browse/JDK-8068233 Webrev: http://cr.openjdk.java.net/~jbachorik/8068233/webrev.00 Part of the fix for JDK-8058506 was lost after incorrect merging of repo during modularization of JDK. This fix reintroduces