>
http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8068162-JVMTI-old.4/
src/share/vm/memory/universe.hpp
No comments.
src/share/vm/memory/universe.cpp
No comments.
src/share/vm/prims/jvmtiRedefineClasses.cpp
So redefining the Unsafe class is now very expensive because
On 1/16/15 3:32 PM, John Rose wrote:
On Jan 16, 2015, at 3:03 PM, Coleen Phillimore
mailto:coleen.phillim...@oracle.com>>
wrote:
I was sort of wondering about this along the same lines. You're
setting the second bit, right? :)
That sounds good, much better than the string prefix hack.
Par
On 1/16/15 3:10 PM, serguei.spit...@oracle.com wrote:
On 1/16/15 3:03 PM, Coleen Phillimore wrote:
On 1/16/15, 6:01 PM, serguei.spit...@oracle.com wrote:
John R. suggested to use the CPSlot(Symbol* ptr) to mark pseudo-strings.
I was sort of wondering about this along the same lines. You're
On Jan 16, 2015, at 3:03 PM, Coleen Phillimore
wrote:
>
> I was sort of wondering about this along the same lines. You're setting the
> second bit, right? :)
That sounds good, much better than the string prefix hack.
Parsing the string would introduce too much coupling between the JVM and ra
On 1/16/15 3:03 PM, Coleen Phillimore wrote:
On 1/16/15, 6:01 PM, serguei.spit...@oracle.com wrote:
John R. suggested to use the CPSlot(Symbol* ptr) to mark pseudo-strings.
I was sort of wondering about this along the same lines. You're
setting the second bit, right? :)
I'm not sure yet.
On 1/16/15, 6:01 PM, serguei.spit...@oracle.com wrote:
John R. suggested to use the CPSlot(Symbol* ptr) to mark pseudo-strings.
I was sort of wondering about this along the same lines. You're setting
the second bit, right? :)
Coleen
The updated webrev is going to be close to the .3 webrev
John R. suggested to use the CPSlot(Symbol* ptr) to mark pseudo-strings.
The updated webrev is going to be close to the .3 webrev.
I will send it soon.
Thanks,
Serguei
On 1/16/15 2:53 PM, Coleen Phillimore wrote:
This change looks good to me also.
Thanks,
Coleen
On 1/16/15, 3:07 PM, serguei.s
Thanks, Coleen!
Serguei
On 1/16/15 2:50 PM, Coleen Phillimore wrote:
Hi Serguei,
Sorry this got lost in my mailbox, twice. This change looks great!
Thank you for re-enabling the test.
Thanks,
Coleen
On 1/16/15, 5:38 PM, serguei.spit...@oracle.com wrote:
Just wanted to tell that Dan is
This change looks good to me also.
Thanks,
Coleen
On 1/16/15, 3:07 PM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-8008678
Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8008678-JVMTI-pseudo.3/
Summary:
Cu
Hi Serguei,
Sorry this got lost in my mailbox, twice. This change looks great!
Thank you for re-enabling the test.
Thanks,
Coleen
On 1/16/15, 5:38 PM, serguei.spit...@oracle.com wrote:
Just wanted to tell that Dan is the second reviewer,
so there is no pressure on others to review this.
Just wanted to tell that Dan is the second reviewer,
so there is no pressure on others to review this. :)
Thanks, Dan!
Serguei
On 1/16/15 11:16 AM, serguei.spit...@oracle.com wrote:
Sorry for the re-post.
Forgot to add review candidates to the to-list.
Thanks,
Serguei
On 1/16/15 11:14 AM, ser
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-8008678
Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8008678-JVMTI-pseudo.3/
Summary:
Currently, a JVM_CONSTANT_String CP entry having a NULL reference to
Symbol*
indicates that it is a pse
Sorry for the re-post.
Forgot to add review candidates to the to-list.
Thanks,
Serguei
On 1/16/15 11:14 AM, serguei.spit...@oracle.com wrote:
Dan, David H. or David C.,
May I ask one of you to look at the webrev below?
The issue itself is a little bit tricky, so it is not easy to review
despi
Dan, David H. or David C.,
May I ask one of you to look at the webrev below?
The issue itself is a little bit tricky, so it is not easy to review
despite the small size.
Coleen,
Does the webrev matches what we discussed with you?
Do you give me a thumbs up?
Thanks,
Serguei
May I ask
On 1/1
Thanks Serguei, thanks Dan!
On 16/01/2015 17:51, Daniel D. Daugherty wrote:
> src/share/vm/prims/jvmtiClassFileReconstituter.hpp
These lines allocate:
line 59: _symmap = new SymbolHashMap();
line 60: _classmap = new SymbolHashMap();
and these lines free incorrectly:
> src/share/vm/prims/jvmtiClassFileReconstituter.hpp
These lines allocate:
line 59: _symmap = new SymbolHashMap();
line 60: _classmap = new SymbolHashMap();
and these lines free incorrectly:
line 71:os::free(_symmap);
line 75:os::free(_classmap
The fix looks good.
Thanks,
Serguei
On 1/16/15 2:17 AM, Mattis Castegren wrote:
Hi
This bug is targeted for 7u80, with rdp2 next Tuesday. It would be great to get
a review for this fix as soon as possible, so that we can get this fix out in
the last public JDK 7 release.
Kind Regards
/Matti
David,
Thank you!
-Dmitry
On 2015-01-16 09:36, David Holmes wrote:
> On 13/01/2015 7:00 PM, Dmitry Samersoff wrote:
>> David,
>>
>> On 2015-01-13 08:10, David Holmes wrote:
>>>
>>> Short version: okay but I'm going to file a bug to have sun.misc.Perf
>>> fixed properly.
>>
>> Thank you and please
Hi
This bug is targeted for 7u80, with rdp2 next Tuesday. It would be great to get
a review for this fix as soon as possible, so that we can get this fix out in
the last public JDK 7 release.
Kind Regards
/Mattis
-Original Message-
From: Kevin Walls
Sent: den 15 januari 2015 15:18
To
19 matches
Mail list logo
