Re: RFR 8077327: ThreadStackTrace.java throws exception: BlockedThread expected to have BLOCKED but got RUNNABLE

Jaroslav, Nice fix. I've checked all the synchronization/check points and they look correct. I hope, the test will be stable now! Thanks, Serguei On 4/9/15 11:11 AM, Jaroslav Bachorik wrote: Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8077327 Webr

Re: RFR 8041565: JMX ObjectName could be refactored to save memory

Hi Roger, On 13.4.2015 16:07, Roger Riggs wrote: Hi Jaroslav, Minor comments: 1488+: In forms like: _pattern_flag &= (~PROPLIST_PATTERN & 0xff);" The &0xff seems unnecessary since the store is to a byte field. Fixed: http://cr.openjdk.java.net/~jbachorik/8041565/webrev.01 1644: the

Re: RFR 8041565: JMX ObjectName could be refactored to save memory

Hi Jaroslav, Minor comments: 1488+: In forms like: _pattern_flag &= (~PROPLIST_PATTERN & 0xff);" The &0xff seems unnecessary since the store is to a byte field. 1644: the ? and : operators should be surrounded by spaces. There are other style issues, such as then statements on the same li

Re: RFR 8041565: JMX ObjectName could be refactored to save memory

Hi Jaroslav, Looks good to me. Nice to save 8 bytes on object name insatnces (~ 20%) ! Olivier Le 13/04/2015 11:43, Jaroslav Bachorik a écrit : Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8041565 Webrev: http://cr.openjdk.java.net/~jbachorik/8041565/w

Re: RFR: 8077408 javax/management/remote/mandatory/notif/NotSerializableNotifTest.java fails due to Port already in use: 2468

Looks good! -JB- On 13.4.2015 11:45, Shanliang Jiang wrote: Hi, Please review this test fix. Instead to specify a port, we use "0" to get a free port. I also remove the test waiting time variable, better to reply on directly the test harness timeout. bug: https://bugs.openjdk.java.net/brows

RFR: 8077408 javax/management/remote/mandatory/notif/NotSerializableNotifTest.java fails due to Port already in use: 2468

Hi, Please review this test fix. Instead to specify a port, we use "0" to get a free port. I also remove the test waiting time variable, better to reply on directly the test harness timeout. bug: https://bugs.openjdk.java.net/browse/JDK-8077408 webrev: http://cr.openjdk.java.net/~sjiang/JDK-

RFR 8041565: JMX ObjectName could be refactored to save memory

Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8041565 Webrev: http://cr.openjdk.java.net/~jbachorik/8041565/webrev.00 In situations when there are 10s of thousands ObjectNname instances around (enterprise setups etc.) the 3 separate internal boolean fields

[ping] Re: RFR 8077327: ThreadStackTrace.java throws exception: BlockedThread expected to have BLOCKED but got RUNNABLE

On 9.4.2015 20:11, Jaroslav Bachorik wrote: Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8077327 Webrev: http://cr.openjdk.java.net/~jbachorik/8077327/webrev.00 This fix is for an intermittent failure due to timing issues. The test is using an arbitr