Looks good. Thanks Stefan.
David
On 25/04/2015 12:41 AM, Stefan Karlsson wrote:
Hi,
Please review this patch to fix an incorrect usage of #if INCLUDE_ALL_GCS.
http://cr.openjdk.java.net/~stefank/8078601/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8078601
This code in thread.cpp is gu
On 4/23/2015 10:58 PM, Alan Bateman wrote:
On 24/04/2015 02:54, Joseph D. Darcy wrote:
Hello,
Any additional comments on marking with tests in question with a
"randomness" keyword?
Thanks,
-Joe
I don't object to this keyword although I should say that most of the
(apparent) randomness tha
Looks good!
Thanks
Markus
-Original Message-
From: Staffan Larsen
Sent: den 24 april 2015 11:09
To: Stefan Karlsson
Cc: Serviceability Dev
Subject: Re: RFR: 8078601: print_concurrent_locks should be guarded with
INCLUDE_SERVICES
Looks good!
Thanks,
/Staffan
> On 24 apr 2015, at 16:41
Looks good!
Thanks,
/Staffan
> On 24 apr 2015, at 16:41, Stefan Karlsson wrote:
>
> Hi,
>
> Please review this patch to fix an incorrect usage of #if INCLUDE_ALL_GCS.
>
> http://cr.openjdk.java.net/~stefank/8078601/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8078601
>
> This code i
Hi,
Please review this patch to fix an incorrect usage of #if INCLUDE_ALL_GCS.
http://cr.openjdk.java.net/~stefank/8078601/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8078601
This code in thread.cpp is guarded by INCLUDE_ALL_GCS:
#if INCLUDE_ALL_GCS
// Dump concurrent locks
Concurre
Hi,
Could I, please, have a review of this tests-only change:
https://bugs.openjdk.java.net/browse/JDK-8067013: Rename the
com.oracle.java.testlibary package
Webrev: http://cr.openjdk.java.net/~akulyakh/8067013/webrev.00/index.html
The change renames com.oracle.java.testlibrary package to jdk.t
All suggestions have been implemented. Please find new webrevs here:
webrev root: http://cr.openjdk.java.net/~ykantser/8059047/webrev.02
webrev jdk: http://cr.openjdk.java.net/~ykantser/8059047.jdk/webrev.02
webrev hotspot:
http://cr.openjdk.java.net/~ykantser/8059047.hotspot/webrev.01
// Katj
I think this looks good.
jtreg is not very good at cleaning up processes that are launched by a test
since there are no APIs in Java to find these processes. However, such APIs are
being added as part of JEP 102 and once present, jtreg will make use of them to
try to clean up better.
/Staffan
Please, review the following test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8077402
Webrev: http://cr.openjdk.java.net/~jbachorik/8077402/webrev.00
Currently, the test waits for 5*{timeout.factor} seconds for the target
application to start up before timing out. On extremely slow
Looks good!
Thanks,
/Staffan
> On 24 apr 2015, at 12:23, Jaroslav Bachorik
> wrote:
>
> Please, review the following test change
>
> Issue : https://bugs.openjdk.java.net/browse/JDK-8076971
> Webrev: http://cr.openjdk.java.net/~jbachorik/8076971/webrev.00
>
> The tests trying to access targe
Please, review the following test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8076971
Webrev: http://cr.openjdk.java.net/~jbachorik/8076971/webrev.00
The tests trying to access target JVMs via eg. 'jcmd' will fail on
embedded configurations if the flag '-XX:+UsePerfData' is not spec
> On 24 apr 2015, at 11:34, Yekaterina Kantserova
> wrote:
>
> Hi,
>
> Here comes the updated version.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8059047
>
> webrev root: http://cr.openjdk.java.net/~ykantser/8059047/webrev.01/
> webrev jdk: http://cr.openjdk.java.net/~ykantser/8059047
Hi,
Here comes the updated version.
bug: https://bugs.openjdk.java.net/browse/JDK-8059047
webrev root: http://cr.openjdk.java.net/~ykantser/8059047/webrev.01/
webrev jdk: http://cr.openjdk.java.net/~ykantser/8059047.jdk/webrev.01/
webrev hotspot:
http://cr.openjdk.java.net/~ykantser/8059047.ho
13 matches
Mail list logo
